test-version22
/
MeterSphere
mirror of https://gitee.com/fit2cloud-feizhiyun/MeterSphere.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

refactor(UI自动化): 报告error代码可读性

This commit is contained in:
zhangdahai112 2022-09-13 19:23:33 +08:00 committed by f2c-ci-robot[bot]
parent e76a394d12
commit 98e40f8cb3
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
backend/src/main/java/io/metersphere/api/service/ApiScenarioReportService.java
View File

@ -914,21 +914,23 @@ public class ApiScenarioReportService {
*/ */
private long getUiErrorSize(ResultDTO dto) { private long getUiErrorSize(ResultDTO dto) {
int errorSize = 0; int errorSize = 0;
boolean success = false;
String processType = null;
String cmdName = null;
for (RequestResult r : dto.getRequestResults()) { for (RequestResult r : dto.getRequestResults()) {
if (StringUtils.isNotEmpty(r.getResponseResult().getHeaders())) { if (StringUtils.isNotEmpty(r.getResponseResult().getHeaders())) {
JSONArray responseArr = JSONArray.parseArray(r.getResponseResult().getHeaders()); JSONArray responseArr = JSONArray.parseArray(r.getResponseResult().getHeaders());
for (int i = 0; i < responseArr.size(); i++) { for (int i = 0; i < responseArr.size(); i++) {
JSONObject stepResult = responseArr.getJSONObject(i); JSONObject stepResult = responseArr.getJSONObject(i);
if (stepResult.containsKey("success") && !stepResult.getBoolean("success")) { success = Optional.ofNullable(stepResult.getBoolean("success")).orElse(Boolean.FALSE);
if ((stepResult.containsKey("processType") && StringUtils.equalsIgnoreCase("MAIN", stepResult.getString("processType"))) processType = Optional.ofNullable(stepResult.getString("processType")).orElse("");
|| (stepResult.containsKey("cmdName") cmdName = Optional.ofNullable(stepResult.getString("cmdName")).orElse("");
&& ((stepResult.getString("cmdName").startsWith("verify")) || stepResult.getString("cmdName").startsWith("assert")))) { if (!success && (StringUtils.equalsIgnoreCase("MAIN", processType) || cmdName.startsWith("verify") || cmdName.startsWith("assert"))) {
errorSize++; errorSize++;
} }
} }
} }
} }
}
return errorSize; return errorSize;
} }