refactor(功能用例): 功能用例联调问题处理

This commit is contained in:
WangXu10 2024-01-10 10:34:49 +08:00 committed by 刘瑞斌
parent 28fc68f13d
commit c0476e26a0
7 changed files with 18 additions and 9 deletions

View File

@ -192,15 +192,13 @@
<select id="listByProviderRequest" resultType="io.metersphere.dto.BugProviderDTO"> <select id="listByProviderRequest" resultType="io.metersphere.dto.BugProviderDTO">
SELECT SELECT
b.id id, b.id id,
b.title title, b.title name,
b.handle_user handleUser, b.handle_user handleUser,
u.`name` name,
b.`status` status, b.`status` status,
b.tag tag, b.tag tag,
b.create_time createTime b.create_time createTime
FROM FROM
bug b bug b
LEFT JOIN `user` u ON b.create_user = u.id
WHERE WHERE
b.deleted = #{deleted} b.deleted = #{deleted}
AND b.id NOT IN AND b.id NOT IN

View File

@ -16,6 +16,7 @@ public interface ExtBugRelateCaseMapper {
/** /**
* 统计缺陷关联的用例数量 * 统计缺陷关联的用例数量
*
* @param bugIds 缺陷ID集合 * @param bugIds 缺陷ID集合
* @return 缺陷关联DTO * @return 缺陷关联DTO
*/ */
@ -23,10 +24,11 @@ public interface ExtBugRelateCaseMapper {
/** /**
* 缺陷关联用例列表查询 * 缺陷关联用例列表查询
*
* @param request 请求参数 * @param request 请求参数
* @return 缺陷关联用例列表 * @return 缺陷关联用例列表
*/ */
List<BugRelateCaseDTO> list(@Param("request") BugRelatedCasePageRequest request); List<BugRelateCaseDTO> list(@Param("request") BugRelatedCasePageRequest request);
List<BugProviderDTO> getAssociateBugs(@Param("request") AssociateBugPageRequest request); List<BugProviderDTO> getAssociateBugs(@Param("request") AssociateBugPageRequest request, @Param("sort") String sort);
} }

View File

@ -32,6 +32,13 @@
INNER JOIN bug b ON brc.bug_id = b.id INNER JOIN bug b ON brc.bug_id = b.id
where b.deleted = false where b.deleted = false
<include refid="queryWhereConditionByProvider"/> <include refid="queryWhereConditionByProvider"/>
order by
<if test="sort != null and sort != ''">
brc.${sort}
</if>
<if test="sort == null or sort == ''">
brc.create_time desc
</if>
</select> </select>
<sql id="queryWhereConditionByProvider"> <sql id="queryWhereConditionByProvider">

View File

@ -75,7 +75,7 @@ public class AssociateBugProvider implements BaseAssociateBugProvider {
@Override @Override
public List<BugProviderDTO> hasAssociateBugPage(AssociateBugPageRequest request) { public List<BugProviderDTO> hasAssociateBugPage(AssociateBugPageRequest request) {
return extBugRelateCaseMapper.getAssociateBugs(request); return extBugRelateCaseMapper.getAssociateBugs(request, request.getSortString());
//TODO 需要转义状态和处理人属性 //TODO 需要转义状态和处理人属性
} }
} }

View File

@ -39,7 +39,7 @@ public class FunctionalCaseRelationshipController {
private FunctionalCaseRelationshipEdgeService functionalCaseRelationshipEdgeService; private FunctionalCaseRelationshipEdgeService functionalCaseRelationshipEdgeService;
@GetMapping("/get-ids/{caseId}") @GetMapping("/get-ids/{caseId}")
@Operation(summary = "用例管理-功能用例-评审列表-评审详情-获取已关联用例id集合(关联用例弹窗前调用)") @Operation(summary = "用例管理-功能用例-用例详情-前后置关系-获取已关联用例id集合(关联用例弹窗前调用)")
@CheckOwner(resourceId = "#reviewId", resourceType = "case_review") @CheckOwner(resourceId = "#reviewId", resourceType = "case_review")
public List<String> getCaseIds(@PathVariable String caseId) { public List<String> getCaseIds(@PathVariable String caseId) {
return functionalCaseRelationshipEdgeService.getExcludeIds(caseId); return functionalCaseRelationshipEdgeService.getExcludeIds(caseId);

View File

@ -126,8 +126,7 @@ public class FunctionalTestCaseController {
@RequiresPermissions(value = {PermissionConstants.FUNCTIONAL_CASE_READ_ADD, PermissionConstants.FUNCTIONAL_CASE_READ_UPDATE, PermissionConstants.FUNCTIONAL_CASE_READ_DELETE}, logical = Logical.OR) @RequiresPermissions(value = {PermissionConstants.FUNCTIONAL_CASE_READ_ADD, PermissionConstants.FUNCTIONAL_CASE_READ_UPDATE, PermissionConstants.FUNCTIONAL_CASE_READ_DELETE}, logical = Logical.OR)
@CheckOwner(resourceId = "#request.getProjectId()", resourceType = "project") @CheckOwner(resourceId = "#request.getProjectId()", resourceType = "project")
public Pager<List<BugProviderDTO>> getAssociateBugList(@Validated @RequestBody AssociateBugPageRequest request) { public Pager<List<BugProviderDTO>> getAssociateBugList(@Validated @RequestBody AssociateBugPageRequest request) {
Page<Object> page = PageHelper.startPage(request.getCurrent(), request.getPageSize(), Page<Object> page = PageHelper.startPage(request.getCurrent(), request.getPageSize());
StringUtils.isNotBlank(request.getSortString()) ? request.getSortString() : "create_time desc");
return PageUtils.setPageInfo(page, functionalTestCaseService.hasAssociateBugPage(request)); return PageUtils.setPageInfo(page, functionalTestCaseService.hasAssociateBugPage(request));
} }
} }

View File

@ -105,9 +105,12 @@ public class CaseReviewFunctionalCaseControllerTests extends BaseTest {
put("type", "List"); put("type", "List");
}})); }}));
request.setCombine(map); request.setCombine(map);
request.setViewFlag(false); request.setViewFlag(true);
request.setProjectId("wx_test_project"); request.setProjectId("wx_test_project");
this.requestPostWithOkAndReturn(REVIEW_CASE_PAGE, request); this.requestPostWithOkAndReturn(REVIEW_CASE_PAGE, request);
this.requestPostWithOkAndReturn(REVIEW_FUNCTIONAL_CASE_MODULE_COUNT, request);
request.setViewFlag(false);
this.requestPostWithOkAndReturn(REVIEW_CASE_PAGE, request);
request.setSort(new HashMap<>() {{ request.setSort(new HashMap<>() {{
put("createTime", "desc"); put("createTime", "desc");