Merge remote-tracking branch 'origin/master' into master
This commit is contained in:
commit
da97ae04fd
|
@ -144,7 +144,7 @@ public class MailService {
|
||||||
context.put("testCaseName", testCaseWithBLOBs.getName());
|
context.put("testCaseName", testCaseWithBLOBs.getName());
|
||||||
context.put("description", request.getDescription());
|
context.put("description", request.getDescription());
|
||||||
context.put("url", baseSystemConfigDTO.getUrl());
|
context.put("url", baseSystemConfigDTO.getUrl());
|
||||||
context.put("id", testCaseWithBLOBs.getId());
|
context.put("id", request.getReviewId());
|
||||||
try {
|
try {
|
||||||
String commentTemplate = IOUtils.toString(this.getClass().getResource("/mail/ReviewComments.html"), StandardCharsets.UTF_8);
|
String commentTemplate = IOUtils.toString(this.getClass().getResource("/mail/ReviewComments.html"), StandardCharsets.UTF_8);
|
||||||
sendReviewNotice(addresseeIdList(messageDetail, userIds, eventType), context, commentTemplate);
|
sendReviewNotice(addresseeIdList(messageDetail, userIds, eventType), context, commentTemplate);
|
||||||
|
|
|
@ -7,5 +7,6 @@ import lombok.Setter;
|
||||||
@Getter
|
@Getter
|
||||||
@Setter
|
@Setter
|
||||||
public class SaveCommentRequest extends TestCaseComment {
|
public class SaveCommentRequest extends TestCaseComment {
|
||||||
|
private String reviewId;
|
||||||
|
|
||||||
}
|
}
|
||||||
|
|
|
@ -10,7 +10,7 @@
|
||||||
${testCaseName}<br/>
|
${testCaseName}<br/>
|
||||||
添加评论:${description}<br/>
|
添加评论:${description}<br/>
|
||||||
点击下面链接进入用例评审页面</p>
|
点击下面链接进入用例评审页面</p>
|
||||||
<a href="${url}/#/track/review/view">${url}/#/track/review/view</a>
|
<a href="${url}/#/track/review/view/${id}">${url}/#/track/review/view/${id}</a>
|
||||||
</div>
|
</div>
|
||||||
</body>
|
</body>
|
||||||
</html>
|
</html>
|
|
@ -1393,7 +1393,6 @@ class JMXGenerator {
|
||||||
for (let index in request.headers) {
|
for (let index in request.headers) {
|
||||||
if (request.headers.hasOwnProperty(index)) {
|
if (request.headers.hasOwnProperty(index)) {
|
||||||
if (request.headers[index].name === 'Content-Type' && request.headers[index].enable != false) {
|
if (request.headers[index].name === 'Content-Type' && request.headers[index].enable != false) {
|
||||||
request.headers.splice(index, 1);
|
|
||||||
hasContentType = true;
|
hasContentType = true;
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
|
|
|
@ -204,7 +204,11 @@ export default {
|
||||||
})
|
})
|
||||||
},
|
},
|
||||||
removeRowTask(index, data) { //移除
|
removeRowTask(index, data) { //移除
|
||||||
|
if (!data[index].identification) {
|
||||||
data.splice(index, 1)
|
data.splice(index, 1)
|
||||||
|
} else {
|
||||||
|
data[index].isSet = false
|
||||||
|
}
|
||||||
},
|
},
|
||||||
deleteRowTask(index, data) { //删除
|
deleteRowTask(index, data) { //删除
|
||||||
this.result = this.$get("/notice/delete/message/" + data.identification, response => {
|
this.result = this.$get("/notice/delete/message/" + data.identification, response => {
|
||||||
|
|
|
@ -205,7 +205,12 @@ export default {
|
||||||
})
|
})
|
||||||
},
|
},
|
||||||
removeRowTask(index, data) { //移除
|
removeRowTask(index, data) { //移除
|
||||||
|
if (!data[index].identification) {
|
||||||
data.splice(index, 1)
|
data.splice(index, 1)
|
||||||
|
} else {
|
||||||
|
data[index].isSet = false
|
||||||
|
}
|
||||||
|
|
||||||
},
|
},
|
||||||
deleteRowTask(index, data) { //删除
|
deleteRowTask(index, data) { //删除
|
||||||
this.result = this.$get("/notice/delete/message/" + data.identification, response => {
|
this.result = this.$get("/notice/delete/message/" + data.identification, response => {
|
||||||
|
|
|
@ -196,7 +196,11 @@ export default {
|
||||||
})
|
})
|
||||||
},
|
},
|
||||||
removeRowTask(index, data) { //移除
|
removeRowTask(index, data) { //移除
|
||||||
|
if (!data[index].identification) {
|
||||||
data.splice(index, 1)
|
data.splice(index, 1)
|
||||||
|
} else {
|
||||||
|
data[index].isSet = false
|
||||||
|
}
|
||||||
},
|
},
|
||||||
deleteRowTask(index, data) { //删除
|
deleteRowTask(index, data) { //删除
|
||||||
this.result = this.$get("/notice/delete/message/" + data.identification, response => {
|
this.result = this.$get("/notice/delete/message/" + data.identification, response => {
|
||||||
|
|
|
@ -210,7 +210,11 @@ export default {
|
||||||
})
|
})
|
||||||
},
|
},
|
||||||
removeRowTask(index, data) { //移除
|
removeRowTask(index, data) { //移除
|
||||||
|
if (!data[index].identification) {
|
||||||
data.splice(index, 1)
|
data.splice(index, 1)
|
||||||
|
} else {
|
||||||
|
data[index].isSet = false
|
||||||
|
}
|
||||||
},
|
},
|
||||||
deleteRowTask(index, data) { //删除
|
deleteRowTask(index, data) { //删除
|
||||||
this.result = this.$get("/notice/delete/message/" + data.identification, response => {
|
this.result = this.$get("/notice/delete/message/" + data.identification, response => {
|
||||||
|
|
|
@ -211,7 +211,11 @@ export default {
|
||||||
})
|
})
|
||||||
},
|
},
|
||||||
removeRowTask(index, data) { //移除
|
removeRowTask(index, data) { //移除
|
||||||
|
if (!data[index].identification) {
|
||||||
data.splice(index, 1)
|
data.splice(index, 1)
|
||||||
|
} else {
|
||||||
|
data[index].isSet = false
|
||||||
|
}
|
||||||
},
|
},
|
||||||
deleteRowTask(index, data) { //删除
|
deleteRowTask(index, data) { //删除
|
||||||
this.result = this.$get("/notice/delete/message/" + data.identification, response => {
|
this.result = this.$get("/notice/delete/message/" + data.identification, response => {
|
||||||
|
|
|
@ -40,7 +40,8 @@ export default {
|
||||||
components: {ReviewCommentItem},
|
components: {ReviewCommentItem},
|
||||||
props: {
|
props: {
|
||||||
caseId: String,
|
caseId: String,
|
||||||
comments: Array
|
comments: Array,
|
||||||
|
reviewId:String,
|
||||||
},
|
},
|
||||||
data() {
|
data() {
|
||||||
return {
|
return {
|
||||||
|
@ -53,6 +54,7 @@ export default {
|
||||||
let comment = {};
|
let comment = {};
|
||||||
comment.caseId = this.caseId;
|
comment.caseId = this.caseId;
|
||||||
comment.description = this.textarea;
|
comment.description = this.textarea;
|
||||||
|
comment.reviewId=this.reviewId;
|
||||||
if (!this.textarea) {
|
if (!this.textarea) {
|
||||||
this.$warning(this.$t('test_track.comment.description_is_null'));
|
this.$warning(this.$t('test_track.comment.description_is_null'));
|
||||||
return;
|
return;
|
||||||
|
|
|
@ -229,7 +229,7 @@
|
||||||
<i class="el-icon-refresh" @click="getComments(testCase)"
|
<i class="el-icon-refresh" @click="getComments(testCase)"
|
||||||
style="margin-left:10px;font-size: 14px; cursor: pointer"/>
|
style="margin-left:10px;font-size: 14px; cursor: pointer"/>
|
||||||
</template>
|
</template>
|
||||||
<review-comment :comments="comments" :case-id="testCase.caseId" @getComments="getComments"/>
|
<review-comment :comments="comments" :case-id="testCase.caseId" :review-id="testCase.reviewId" @getComments="getComments"/>
|
||||||
</el-card>
|
</el-card>
|
||||||
</el-col>
|
</el-col>
|
||||||
</div>
|
</div>
|
||||||
|
|
|
@ -300,6 +300,7 @@ export default {
|
||||||
return path + "/" + this.currentPage + "/" + this.pageSize;
|
return path + "/" + this.currentPage + "/" + this.pageSize;
|
||||||
},
|
},
|
||||||
handleEdit(testCase, index) {
|
handleEdit(testCase, index) {
|
||||||
|
console.log(testCase)
|
||||||
this.isReadOnly = false;
|
this.isReadOnly = false;
|
||||||
if (!checkoutTestManagerOrTestUser()) {
|
if (!checkoutTestManagerOrTestUser()) {
|
||||||
this.isReadOnly = true;
|
this.isReadOnly = true;
|
||||||
|
|
Loading…
Reference in New Issue