test0908
/
django
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #3549 from psagers/master 

Fixes a race condition in the documentation.

The example for django.contrib.admin.ModelAdmin.get_form was modifying self.exclude. However, since ModelAdmin instances are global and have no thread- or request-locality, this is not safe for concurrent requests. This updated documentation demonstrates a safe method to override admin forms on a per-request basis.
This commit is contained in:
Julien Phalip 2014-11-16 12:25:05 +01:00
parent 4024dd0c98 0d1a9d203a
commit 05e0e4674c
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
docs/ref/contrib/admin/index.txt
View File

@ -1488,16 +1488,20 @@ templates used by the :class:`ModelAdmin` views:
Returns a :class:`~django.forms.ModelForm` class for use in the admin add Returns a :class:`~django.forms.ModelForm` class for use in the admin add
and change views, see :meth:`add_view` and :meth:`change_view`. and change views, see :meth:`add_view` and :meth:`change_view`.
If you wanted to hide a field from non-superusers, for example, you could The base implementation uses :func:`~django.forms.models.modelform_factory`
override ``get_form`` as follows:: to subclass :attr:`~form`, modified by attributes such as :attr:`~fields`
and :attr:`~exclude`. So, for example, if you wanted to offer additional
fields to superusers, you could swap in a different base form like so::
class MyModelAdmin(admin.ModelAdmin): class MyModelAdmin(admin.ModelAdmin):
def get_form(self, request, obj=None, **kwargs): def get_form(self, request, obj=None, **kwargs):
self.exclude = [] if request.user.is_superuser:
if not request.user.is_superuser: kwargs['form'] = MySuperuserForm
self.exclude.append('field_to_hide')
return super(MyModelAdmin, self).get_form(request, obj, **kwargs) return super(MyModelAdmin, self).get_form(request, obj, **kwargs)
You may also simply return a custom :class:`~django.forms.ModelForm` class
directly.
.. method:: ModelAdmin.get_formsets(request, obj=None) .. method:: ModelAdmin.get_formsets(request, obj=None)
.. deprecated:: 1.7 .. deprecated:: 1.7