test0908
/
django
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Refs #30033 -- Fixed schema's test_m2m_rename_field_in_target_model test failure on SQLite < 3.20. 

Mixing local test models with non-local models resulted in a referential
integrity error during tear down since the models are removed in separate
schema editor instances which each check constraints.

Failure appeared after 7289874adc.
This commit is contained in:
Tim Graham 2018-12-26 11:24:11 -05:00
parent b74b6736d0
commit 0b54ab0675
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tests/schema/tests.py
View File

@ -1455,14 +1455,14 @@ class SchemaTests(TransactionTestCase):
@isolate_apps('schema') @isolate_apps('schema')
def test_m2m_rename_field_in_target_model(self): def test_m2m_rename_field_in_target_model(self):
class TagM2MTest(Model): class LocalTagM2MTest(Model):
title = CharField(max_length=255) title = CharField(max_length=255)
class Meta: class Meta:
app_label = 'schema' app_label = 'schema'
class LocalM2M(Model): class LocalM2M(Model):
tags = ManyToManyField(TagM2MTest) tags = ManyToManyField(LocalTagM2MTest)
class Meta: class Meta:
app_label = 'schema' app_label = 'schema'
@ -1470,18 +1470,19 @@ class SchemaTests(TransactionTestCase):
# Create the tables. # Create the tables.
with connection.schema_editor() as editor: with connection.schema_editor() as editor:
editor.create_model(LocalM2M) editor.create_model(LocalM2M)
editor.create_model(TagM2MTest) editor.create_model(LocalTagM2MTest)
self.isolated_local_models = [LocalM2M, LocalTagM2MTest]
# Ensure the m2m table is there. # Ensure the m2m table is there.
self.assertEqual(len(self.column_classes(LocalM2M)), 1) self.assertEqual(len(self.column_classes(LocalM2M)), 1)
# Alter a field in TagM2MTest. # Alter a field in LocalTagM2MTest.
old_field = TagM2MTest._meta.get_field('title') old_field = LocalTagM2MTest._meta.get_field('title')
new_field = CharField(max_length=254) new_field = CharField(max_length=254)
new_field.contribute_to_class(TagM2MTest, 'title1') new_field.contribute_to_class(LocalTagM2MTest, 'title1')
# @isolate_apps() and inner models are needed to have the model # @isolate_apps() and inner models are needed to have the model
# relations populated, otherwise this doesn't act as a regression test. # relations populated, otherwise this doesn't act as a regression test.
self.assertEqual(len(new_field.model._meta.related_objects), 1) self.assertEqual(len(new_field.model._meta.related_objects), 1)
with connection.schema_editor() as editor: with connection.schema_editor() as editor:
editor.alter_field(TagM2MTest, old_field, new_field, strict=True) editor.alter_field(LocalTagM2MTest, old_field, new_field, strict=True)
# Ensure the m2m table is still there. # Ensure the m2m table is still there.
self.assertEqual(len(self.column_classes(LocalM2M)), 1) self.assertEqual(len(self.column_classes(LocalM2M)), 1)