From 16ee53d7bb01819859c78a88e3fc93eda985f71a Mon Sep 17 00:00:00 2001 From: Tim Graham Date: Mon, 5 Feb 2018 10:29:38 -0500 Subject: [PATCH] Fixed #29113 -- Simplified django.forms.formsets.all_valid() and clarified docstring. --- django/forms/formsets.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/django/forms/formsets.py b/django/forms/formsets.py index 5133164f7a..1b95bfa4c5 100644 --- a/django/forms/formsets.py +++ b/django/forms/formsets.py @@ -436,9 +436,8 @@ def formset_factory(form, formset=BaseFormSet, extra=1, can_order=False, def all_valid(formsets): - """Return True if every formset in formsets is valid.""" + """Validate every formset and return True if all are valid.""" valid = True for formset in formsets: - if not formset.is_valid(): - valid = False + valid &= formset.is_valid() return valid