From 179b247e07592a11708fa0ffdd23dc3f9af042fb Mon Sep 17 00:00:00 2001 From: Mariusz Felisiak Date: Tue, 5 Sep 2017 11:17:06 +0200 Subject: [PATCH] Removed useless condition from Oracle's NullBooleanField's check constraint. NULL cannot be compare with standard operators on Oracle, it works only with IS NULL and IS NOT NULL operators. Therefore 'OR ... IS NULL' condition in NullBooleanField's check constraint is redundant. Nullability is checked in a separate constraint. --- django/db/backends/oracle/base.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/django/db/backends/oracle/base.py b/django/db/backends/oracle/base.py index b13bab1798..ae77de57d0 100644 --- a/django/db/backends/oracle/base.py +++ b/django/db/backends/oracle/base.py @@ -111,7 +111,7 @@ class DatabaseWrapper(BaseDatabaseWrapper): } data_type_check_constraints = { 'BooleanField': '%(qn_column)s IN (0,1)', - 'NullBooleanField': '(%(qn_column)s IN (0,1)) OR (%(qn_column)s IS NULL)', + 'NullBooleanField': '%(qn_column)s IN (0,1)', 'PositiveIntegerField': '%(qn_column)s >= 0', 'PositiveSmallIntegerField': '%(qn_column)s >= 0', }