test0908
/
django
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed #31616 -- Added hint about middleware ordering for SessionMiddleware admin check.

This commit is contained in:
Hasan Ramezani 2020-05-25 16:41:24 +02:00 committed by Mariusz Felisiak
parent f24b59267b
commit 18759b2209
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
django/contrib/admin/checks.py
View File

@ -132,6 +132,12 @@ def check_dependencies(**kwargs):
errors.append(checks.Error( errors.append(checks.Error(
"'django.contrib.sessions.middleware.SessionMiddleware' must " "'django.contrib.sessions.middleware.SessionMiddleware' must "
"be in MIDDLEWARE in order to use the admin application.", "be in MIDDLEWARE in order to use the admin application.",
hint=(
"Insert "
"'django.contrib.sessions.middleware.SessionMiddleware' "
"before "
"'django.contrib.auth.middleware.AuthenticationMiddleware'."
),
id='admin.E410', id='admin.E410',
)) ))
return errors return errors

6
tests/admin_checks/tests.py
View File

@ -214,6 +214,12 @@ class SystemChecksTestCase(SimpleTestCase):
checks.Error( checks.Error(
"'django.contrib.sessions.middleware.SessionMiddleware' " "'django.contrib.sessions.middleware.SessionMiddleware' "
"must be in MIDDLEWARE in order to use the admin application.", "must be in MIDDLEWARE in order to use the admin application.",
hint=(
"Insert "
"'django.contrib.sessions.middleware.SessionMiddleware' "
"before "
"'django.contrib.auth.middleware.AuthenticationMiddleware'."
),
id='admin.E410', id='admin.E410',
), ),
] ]