test0908
/
django
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed crash comparing CheckMessage objects to non-CheckMessage objects.

This commit is contained in:
Adam Chainz 2016-08-05 14:18:12 +01:00 committed by Tim Graham
parent 68b580323b
commit 19e20a2a3f
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
django/core/checks/messages.py
View File

@ -23,8 +23,11 @@ class CheckMessage(object):
self.id = id self.id = id
def __eq__(self, other): def __eq__(self, other):
return all(getattr(self, attr) == getattr(other, attr) return (
for attr in ['level', 'msg', 'hint', 'obj', 'id']) isinstance(other, self.__class__) and
all(getattr(self, attr) == getattr(other, attr)
for attr in ['level', 'msg', 'hint', 'obj', 'id'])
)
def __ne__(self, other): def __ne__(self, other):
return not (self == other) return not (self == other)

4
tests/check_framework/tests.py
View File

@ -124,6 +124,10 @@ class MessageTests(SimpleTestCase):
e2 = Error("Error2", obj=SimpleModel) e2 = Error("Error2", obj=SimpleModel)
self.assertNotEqual(e1, e2) self.assertNotEqual(e1, e2)
def test_not_equal_to_non_check(self):
e = Error("Error", obj=DummyObj())
self.assertNotEqual(e, 'a string')
def simple_system_check(**kwargs): def simple_system_check(**kwargs):
simple_system_check.kwargs = kwargs simple_system_check.kwargs = kwargs