Refs #32355 -- Used addClassCleanup() in tests.
Inspired by Adam Johnson talk on DjangoCon Europe 2021.
This commit is contained in:
parent
2e4711c611
commit
213850b4b9
|
@ -58,11 +58,7 @@ class FileUploadTests(TestCase):
|
|||
def setUpClass(cls):
|
||||
super().setUpClass()
|
||||
os.makedirs(MEDIA_ROOT, exist_ok=True)
|
||||
|
||||
@classmethod
|
||||
def tearDownClass(cls):
|
||||
shutil.rmtree(MEDIA_ROOT)
|
||||
super().tearDownClass()
|
||||
cls.addClassCleanup(shutil.rmtree, MEDIA_ROOT)
|
||||
|
||||
def test_upload_name_is_validated(self):
|
||||
candidates = [
|
||||
|
@ -678,11 +674,7 @@ class DirectoryCreationTests(SimpleTestCase):
|
|||
def setUpClass(cls):
|
||||
super().setUpClass()
|
||||
os.makedirs(MEDIA_ROOT, exist_ok=True)
|
||||
|
||||
@classmethod
|
||||
def tearDownClass(cls):
|
||||
shutil.rmtree(MEDIA_ROOT)
|
||||
super().tearDownClass()
|
||||
cls.addClassCleanup(shutil.rmtree, MEDIA_ROOT)
|
||||
|
||||
def setUp(self):
|
||||
self.obj = FileModel()
|
||||
|
|
|
@ -53,13 +53,8 @@ class SetupDefaultLoggingMixin:
|
|||
@classmethod
|
||||
def setUpClass(cls):
|
||||
super().setUpClass()
|
||||
cls._logging = settings.LOGGING
|
||||
logging.config.dictConfig(DEFAULT_LOGGING)
|
||||
|
||||
@classmethod
|
||||
def tearDownClass(cls):
|
||||
super().tearDownClass()
|
||||
logging.config.dictConfig(cls._logging)
|
||||
cls.addClassCleanup(logging.config.dictConfig, settings.LOGGING)
|
||||
|
||||
|
||||
class DefaultLoggingTests(SetupDefaultLoggingMixin, LoggingCaptureMixin, SimpleTestCase):
|
||||
|
|
|
@ -1442,13 +1442,9 @@ class SMTPBackendTestsBase(SimpleTestCase):
|
|||
EMAIL_HOST="127.0.0.1",
|
||||
EMAIL_PORT=cls.server.socket.getsockname()[1])
|
||||
cls._settings_override.enable()
|
||||
cls.addClassCleanup(cls._settings_override.disable)
|
||||
cls.server.start()
|
||||
|
||||
@classmethod
|
||||
def tearDownClass(cls):
|
||||
cls._settings_override.disable()
|
||||
cls.server.stop()
|
||||
super().tearDownClass()
|
||||
cls.addClassCleanup(cls.server.stop)
|
||||
|
||||
|
||||
class SMTPBackendTests(BaseEmailBackendTests, SMTPBackendTestsBase):
|
||||
|
|
Loading…
Reference in New Issue