test0908
/
django
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[1.7.x] Fixed #23156 -- Added missing BinaryField.deconstruct() method. 

Backport of 72f1eb48df from master.
This commit is contained in:
Baptiste Mispelon 2014-08-03 12:59:21 +02:00
parent 0b1d0afc92
commit 23b0d636d3
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
django/db/models/fields/__init__.py
View File

@ -2014,6 +2014,11 @@ class BinaryField(Field):
if self.max_length is not None: if self.max_length is not None:
self.validators.append(validators.MaxLengthValidator(self.max_length)) self.validators.append(validators.MaxLengthValidator(self.max_length))
def deconstruct(self):
name, path, args, kwargs = super(BinaryField, self).deconstruct()
del kwargs['editable']
return name, path, args, kwargs
def get_internal_type(self): def get_internal_type(self):
return "BinaryField" return "BinaryField"

7
tests/field_deconstruction/tests.py
View File

@ -364,3 +364,10 @@ class FieldDeconstructionTests(TestCase):
self.assertEqual(path, "django.db.models.URLField") self.assertEqual(path, "django.db.models.URLField")
self.assertEqual(args, []) self.assertEqual(args, [])
self.assertEqual(kwargs, {"max_length": 231}) self.assertEqual(kwargs, {"max_length": 231})
def test_binary_field(self):
field = models.BinaryField()
name, path, args, kwargs = field.deconstruct()
self.assertEqual(path, "django.db.models.BinaryField")
self.assertEqual(args, [])
self.assertEqual(kwargs, {})