test0908
/
django
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Removed unneeded Value wraps in Substr. 

Unneeded since e2d6e14662.
This commit is contained in:
Sergey Fedoseev 2017-03-23 19:50:56 +05:00 committed by Tim Graham
parent 7b6524e0ff
commit 40ffabe8dc
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
django/db/models/functions/base.py
View File

@ -222,11 +222,8 @@ class Substr(Func):
if not hasattr(pos, 'resolve_expression'): if not hasattr(pos, 'resolve_expression'):
if pos < 1: if pos < 1:
raise ValueError("'pos' must be greater than 0") raise ValueError("'pos' must be greater than 0")
pos = Value(pos)
expressions = [expression, pos] expressions = [expression, pos]
if length is not None: if length is not None:
if not hasattr(length, 'resolve_expression'):
length = Value(length)
expressions.append(length) expressions.append(length)
super().__init__(*expressions, **extra) super().__init__(*expressions, **extra)