test0908
/
django
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed #21486 -- Prevented settings config in signal connection 

This was particularly problematic in the chain get_wsgi_application
-> db.connections import -> signal connection -> settings configuration.
Thanks Jon Dufresne for the report.
This commit is contained in:
Claude Paroz 2013-11-23 18:18:42 +01:00
parent e112654fc8
commit 42fef29446
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
django/dispatch/dispatcher.py
View File

@ -85,7 +85,7 @@ class Signal(object):
from django.conf import settings from django.conf import settings
# If DEBUG is on, check that we got a good receiver # If DEBUG is on, check that we got a good receiver
if settings.DEBUG: if settings.configured and settings.DEBUG:
import inspect import inspect
assert callable(receiver), "Signal receivers must be callable." assert callable(receiver), "Signal receivers must be callable."

2
docs/releases/1.6.1.txt
View File

@ -35,3 +35,5 @@ Bug fixes
promised: Support of multiple locale names separated by commas. It's still promised: Support of multiple locale names separated by commas. It's still
possible to specify multiplle locales in one run by suing the option possible to specify multiplle locales in one run by suing the option
multiple times (#21488, #17181). multiple times (#21488, #17181).
* Fixed a regression that unnecessarily triggered settings configuration when
importing ``get_wsgi_application`` (#21486).