Fixed #25878 -- Documented requirement that handler404 return a 404 response.

This commit is contained in:
Tim Graham 2016-01-04 20:11:20 -05:00
parent 186b6c61bf
commit 49eeb0f570
2 changed files with 18 additions and 8 deletions

View File

@ -94,8 +94,9 @@ A callable, or a string representing the full Python import path to the view
that should be called if the HTTP client has sent a request that caused an error that should be called if the HTTP client has sent a request that caused an error
condition and a response with a status code of 400. condition and a response with a status code of 400.
By default, this is ``'django.views.defaults.bad_request'``. That default By default, this is ``'django.views.defaults.bad_request'``. If you
value should suffice. implement a custom view, be sure it returns an
:class:`~django.http.HttpResponseBadRequest`.
See the documentation about :ref:`the 400 (bad request) view See the documentation about :ref:`the 400 (bad request) view
<http_bad_request_view>` for more information. <http_bad_request_view>` for more information.
@ -109,8 +110,9 @@ A callable, or a string representing the full Python import path to the view
that should be called if the user doesn't have the permissions required to that should be called if the user doesn't have the permissions required to
access a resource. access a resource.
By default, this is ``'django.views.defaults.permission_denied'``. That default By default, this is ``'django.views.defaults.permission_denied'``. If you
value should suffice. implement a custom view, be sure it returns an
:class:`~django.http.HttpResponseForbidden`.
See the documentation about :ref:`the 403 (HTTP Forbidden) view See the documentation about :ref:`the 403 (HTTP Forbidden) view
<http_forbidden_view>` for more information. <http_forbidden_view>` for more information.
@ -123,8 +125,9 @@ handler404
A callable, or a string representing the full Python import path to the view A callable, or a string representing the full Python import path to the view
that should be called if none of the URL patterns match. that should be called if none of the URL patterns match.
By default, this is ``'django.views.defaults.page_not_found'``. That default By default, this is ``'django.views.defaults.page_not_found'``. If you
value should suffice. implement a custom view, be sure it returns an
:class:`~django.http.HttpResponseNotFound`.
See the documentation about :ref:`the 404 (HTTP Not Found) view See the documentation about :ref:`the 404 (HTTP Not Found) view
<http_not_found_view>` for more information. <http_not_found_view>` for more information.
@ -138,8 +141,9 @@ A callable, or a string representing the full Python import path to the view
that should be called in case of server errors. Server errors happen when you that should be called in case of server errors. Server errors happen when you
have runtime errors in view code. have runtime errors in view code.
By default, this is ``'django.views.defaults.server_error'``. That default By default, this is ``'django.views.defaults.server_error'``. If you
value should suffice. implement a custom view, be sure it returns an
:class:`~django.http.HttpResponseServerError`.
See the documentation about :ref:`the 500 (HTTP Internal Server Error) view See the documentation about :ref:`the 500 (HTTP Internal Server Error) view
<http_internal_server_error_view>` for more information. <http_internal_server_error_view>` for more information.

View File

@ -1147,6 +1147,12 @@ Miscellaneous
* ``ForeignRelatedObjectsDescriptor`` is ``ReverseManyToOneDescriptor`` * ``ForeignRelatedObjectsDescriptor`` is ``ReverseManyToOneDescriptor``
* ``ManyRelatedObjectsDescriptor`` is ``ManyToManyDescriptor`` * ``ManyRelatedObjectsDescriptor`` is ``ManyToManyDescriptor``
* If you implement a custom :data:`~django.conf.urls.handler404` view, it must
return a response with an HTTP 404 status code. Use
:class:`~django.http.HttpResponseNotFound` or pass ``status=404`` to the
:class:`~django.http.HttpResponse`. Otherwise, :setting:`APPEND_SLASH` won't
work correctly with ``DEBUG=False``.
.. _deprecated-features-1.9: .. _deprecated-features-1.9:
Features deprecated in 1.9 Features deprecated in 1.9