Refs #17215: Avoid generating 47 leftover tmp dirs during a clean test run.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@17094 bcc190cf-cafb-0310-a4f2-bffc1f526a37
This commit is contained in:
Karen Tracey 2011-11-13 19:05:02 +00:00
parent b8353016b7
commit 5de31cb8cb
7 changed files with 11 additions and 7 deletions

View File

@ -1,3 +1,4 @@
import os
import tempfile import tempfile
from django import forms from django import forms
@ -10,7 +11,7 @@ from django.contrib.auth.models import User
from django.contrib.formtools.wizard.views import WizardView from django.contrib.formtools.wizard.views import WizardView
temp_storage_location = tempfile.mkdtemp() temp_storage_location = tempfile.mkdtemp(dir=os.environ.get('DJANGO_TEST_TEMP_DIR'))
temp_storage = FileSystemStorage(location=temp_storage_location) temp_storage = FileSystemStorage(location=temp_storage_location)
class Page1(forms.Form): class Page1(forms.Form):

View File

@ -7,13 +7,14 @@ and the examples are probably a poor fit for the ``ModelForm`` syntax. In other
words, most of these tests should be rewritten. words, most of these tests should be rewritten.
""" """
import os
import tempfile import tempfile
from django.core.files.storage import FileSystemStorage from django.core.files.storage import FileSystemStorage
from django.db import models from django.db import models
temp_storage_dir = tempfile.mkdtemp() temp_storage_dir = tempfile.mkdtemp(dir=os.environ['DJANGO_TEST_TEMP_DIR'])
temp_storage = FileSystemStorage(temp_storage_dir) temp_storage = FileSystemStorage(temp_storage_dir)
ARTICLE_STATUS = ( ARTICLE_STATUS = (

View File

@ -260,7 +260,7 @@ class OldSubscriberAdmin(admin.ModelAdmin):
actions = None actions = None
temp_storage = FileSystemStorage(tempfile.mkdtemp()) temp_storage = FileSystemStorage(tempfile.mkdtemp(dir=os.environ['DJANGO_TEST_TEMP_DIR']))
UPLOAD_TO = os.path.join(temp_storage.location, 'test_upload') UPLOAD_TO = os.path.join(temp_storage.location, 'test_upload')

View File

@ -246,7 +246,7 @@ class EmptyModel(models.Model):
return "Primary key = %s" % self.id return "Primary key = %s" % self.id
temp_storage = FileSystemStorage(tempfile.mkdtemp()) temp_storage = FileSystemStorage(tempfile.mkdtemp(dir=os.environ['DJANGO_TEST_TEMP_DIR']))
UPLOAD_TO = os.path.join(temp_storage.location, 'test_upload') UPLOAD_TO = os.path.join(temp_storage.location, 'test_upload')

View File

@ -1,4 +1,5 @@
# -*- coding: utf-8 -*- # -*- coding: utf-8 -*-
import os
import datetime import datetime
import tempfile import tempfile
@ -6,7 +7,7 @@ from django.core.files.storage import FileSystemStorage
from django.db import models from django.db import models
temp_storage_location = tempfile.mkdtemp() temp_storage_location = tempfile.mkdtemp(dir=os.environ['DJANGO_TEST_TEMP_DIR'])
temp_storage = FileSystemStorage(location=temp_storage_location) temp_storage = FileSystemStorage(location=temp_storage_location)

View File

@ -100,7 +100,7 @@ class BaseCollectionTestCase(BaseStaticFilesTestCase):
def setUp(self): def setUp(self):
super(BaseCollectionTestCase, self).setUp() super(BaseCollectionTestCase, self).setUp()
self.old_root = settings.STATIC_ROOT self.old_root = settings.STATIC_ROOT
settings.STATIC_ROOT = tempfile.mkdtemp() settings.STATIC_ROOT = tempfile.mkdtemp(dir=os.environ['DJANGO_TEST_TEMP_DIR'])
self.run_collectstatic() self.run_collectstatic()
# Use our own error handler that can handle .svn dirs on Windows # Use our own error handler that can handle .svn dirs on Windows
#self.addCleanup(shutil.rmtree, settings.STATIC_ROOT, #self.addCleanup(shutil.rmtree, settings.STATIC_ROOT,

View File

@ -19,6 +19,7 @@ CONTRIB_DIR = os.path.dirname(contrib.__file__)
MODEL_TEST_DIR = os.path.join(RUNTESTS_DIR, MODEL_TESTS_DIR_NAME) MODEL_TEST_DIR = os.path.join(RUNTESTS_DIR, MODEL_TESTS_DIR_NAME)
REGRESSION_TEST_DIR = os.path.join(RUNTESTS_DIR, REGRESSION_TESTS_DIR_NAME) REGRESSION_TEST_DIR = os.path.join(RUNTESTS_DIR, REGRESSION_TESTS_DIR_NAME)
TEMP_DIR = tempfile.mkdtemp(prefix='django_') TEMP_DIR = tempfile.mkdtemp(prefix='django_')
os.environ['DJANGO_TEST_TEMP_DIR'] = TEMP_DIR
REGRESSION_SUBDIRS_TO_SKIP = ['locale'] REGRESSION_SUBDIRS_TO_SKIP = ['locale']