From 66312066a01af1325280b07d8e6942b03a46d650 Mon Sep 17 00:00:00 2001 From: Gabriel Hurley Date: Mon, 7 Feb 2011 23:56:39 +0000 Subject: [PATCH] Fixed #14861 -- Added an admonition about the potential for circular imports with custom logging handlers (which produces an extremely confusing error message) to the logging docs. Thanks to donspaulding for the report and adamv for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@15449 bcc190cf-cafb-0310-a4f2-bffc1f526a37 --- docs/topics/logging.txt | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/docs/topics/logging.txt b/docs/topics/logging.txt index 845db20d48..062cd7f0f5 100644 --- a/docs/topics/logging.txt +++ b/docs/topics/logging.txt @@ -349,6 +349,36 @@ This logging configuration does the following things: printed to the console; ``ERROR`` and ``CRITICAL`` messages will also be output via e-mail. +.. admonition:: Custom handlers and circular imports + + If your ``settings.py`` specifies a custom handler class and the file + defining that class also imports ``settings.py`` a circular import will + occur. + + For example, if ``settings.py`` contains the following config for + :setting:`LOGGING`:: + + LOGGING = { + 'version': 1, + 'handlers': { + 'custom_handler': { + 'level': 'INFO', + 'class': 'myproject.logconfig.MyHandler', + } + } + } + + and ``myproject/logconfig.py`` has the following line before the + ``MyHandler`` definition:: + + from django.conf import settings + + then the ``dictconfig`` module will raise an exception like the following:: + + ValueError: Unable to configure handler 'custom_handler': + Unable to configure handler 'custom_handler': + 'module' object has no attribute 'logconfig' + .. _formatter documentation: http://docs.python.org/library/logging.html#formatter-objects Custom logging configuration