diff --git a/django/contrib/admin/templatetags/admin_list.py b/django/contrib/admin/templatetags/admin_list.py index a374bf58f7..21401caf43 100644 --- a/django/contrib/admin/templatetags/admin_list.py +++ b/django/contrib/admin/templatetags/admin_list.py @@ -70,7 +70,7 @@ pagination = register.inclusion_tag('admin/pagination.html')(pagination) def result_headers(cl): lookup_opts = cl.lookup_opts - + for i, field_name in enumerate(cl.list_display): attr = None try: @@ -97,7 +97,7 @@ def result_headers(cl): raise AttributeError, \ "'%s' model or '%s' objects have no attribute '%s'" % \ (lookup_opts.object_name, cl.model_admin.__class__, field_name) - + try: header = attr.short_description except AttributeError: @@ -237,7 +237,7 @@ def items_for_result(cl, result, form): result_repr = conditional_escape(result_repr) yield mark_safe(u'%s' % (row_class, result_repr)) if form: - yield mark_safe(force_unicode(form[cl.model._meta.pk.attname])) + yield mark_safe(force_unicode(form[cl.model._meta.pk.name])) def results(cl): if cl.formset: diff --git a/tests/regressiontests/admin_views/models.py b/tests/regressiontests/admin_views/models.py index e5e112fa43..354646344b 100644 --- a/tests/regressiontests/admin_views/models.py +++ b/tests/regressiontests/admin_views/models.py @@ -143,10 +143,10 @@ class Person(models.Model): name = models.CharField(max_length=100) gender = models.IntegerField(choices=GENDER_CHOICES) alive = models.BooleanField() - + def __unicode__(self): return self.name - + class Meta: ordering = ["id"] @@ -236,6 +236,18 @@ def redirect_to(request, selected): class ExternalSubscriberAdmin(admin.ModelAdmin): actions = [external_mail, redirect_to] +class Media(models.Model): + name = models.CharField(max_length=60) + +class Podcast(Media): + release_date = models.DateField() + +class PodcastAdmin(admin.ModelAdmin): + list_display = ('name', 'release_date') + list_editable = ('release_date',) + + ordering = ('name',) + admin.site.register(Article, ArticleAdmin) admin.site.register(CustomArticle, CustomArticleAdmin) admin.site.register(Section, inlines=[ArticleInline]) @@ -246,6 +258,7 @@ admin.site.register(Person, PersonAdmin) admin.site.register(Persona, PersonaAdmin) admin.site.register(Subscriber, SubscriberAdmin) admin.site.register(ExternalSubscriber, ExternalSubscriberAdmin) +admin.site.register(Podcast, PodcastAdmin) # We intentionally register Promo and ChapterXtra1 but not Chapter nor ChapterXtra2. # That way we cover all four cases: @@ -259,5 +272,3 @@ admin.site.register(ExternalSubscriber, ExternalSubscriberAdmin) admin.site.register(Book, inlines=[ChapterInline]) admin.site.register(Promo) admin.site.register(ChapterXtra1) - - diff --git a/tests/regressiontests/admin_views/tests.py b/tests/regressiontests/admin_views/tests.py index ce6356726f..2fd4c076b0 100644 --- a/tests/regressiontests/admin_views/tests.py +++ b/tests/regressiontests/admin_views/tests.py @@ -1,6 +1,7 @@ # coding: utf-8 import re +import datetime from django.test import TestCase from django.contrib.auth.models import User, Permission @@ -12,7 +13,7 @@ from django.contrib.admin.helpers import ACTION_CHECKBOX_NAME from django.utils.html import escape # local test models -from models import Article, CustomArticle, Section, ModelWithStringPrimaryKey, Person, Persona, FooAccount, BarAccount, Subscriber, ExternalSubscriber +from models import Article, CustomArticle, Section, ModelWithStringPrimaryKey, Person, Persona, FooAccount, BarAccount, Subscriber, ExternalSubscriber, Podcast try: set @@ -740,6 +741,12 @@ class AdminViewListEditable(TestCase): def tearDown(self): self.client.logout() + def test_inheritance(self): + Podcast.objects.create(name="This Week in Django", + release_date=datetime.date.today()) + response = self.client.get('/test_admin/admin/admin_views/podcast/') + self.failUnlessEqual(response.status_code, 200) + def test_changelist_input_html(self): response = self.client.get('/test_admin/admin/admin_views/person/') # 2 inputs per object(the field and the hidden id field) = 6