Fixed #26541 -- Allowed MySQL transaction detection to work without table creation.

This commit is contained in:
Mariusz Felisiak 2016-09-29 21:05:35 +02:00 committed by Tim Graham
parent fa2f55cfd5
commit 6e4e0f4ce4
2 changed files with 25 additions and 1 deletions

View File

@ -78,3 +78,10 @@ class DatabaseFeatures(BaseDatabaseFeatures):
cursor.execute('SELECT @@SQL_AUTO_IS_NULL')
result = cursor.fetchone()
return result and result[0] == 1
@cached_property
def supports_transactions(self):
"""
All storage engines except MyISAM support transactions.
"""
return self._mysql_storage_engine != 'MyISAM'

View File

@ -1,8 +1,25 @@
from unittest import skipUnless
from django.db import connection
from django.test import TestCase
from django.test import TestCase, mock
class TestDatabaseFeatures(TestCase):
def test_nonexistent_feature(self):
self.assertFalse(hasattr(connection.features, 'nonexistent'))
@skipUnless(connection.vendor == 'mysql', 'MySQL backend tests')
class TestMySQLFeatures(TestCase):
def test_mysql_supports_transactions(self):
"""
All storage engines except MyISAM support transactions.
"""
with mock.patch('django.db.connection.features._mysql_storage_engine', 'InnoDB'):
self.assertTrue(connection.features.supports_transactions)
del connection.features.supports_transactions
with mock.patch('django.db.connection.features._mysql_storage_engine', 'MyISAM'):
self.assertFalse(connection.features.supports_transactions)
del connection.features.supports_transactions