From 710af68dee4abaaec7a9817c0c44fe8782525d4e Mon Sep 17 00:00:00 2001 From: Mariusz Felisiak Date: Tue, 19 Jul 2022 09:45:11 +0200 Subject: [PATCH] [4.1.x] Fixed #33855 -- Removed unnecessary system check calls from test worker initialization. Regression in 3b3f38b3b09b0f2373e51406ecb8c9c45d36aebc. Backport of 24effbceb871e71d3bc320b91252f743714722df from main --- django/test/runner.py | 9 +-------- tests/check_framework/tests.py | 7 +++++++ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/django/test/runner.py b/django/test/runner.py index 55d902bb09..270ddf5b59 100644 --- a/django/test/runner.py +++ b/django/test/runner.py @@ -20,12 +20,7 @@ from io import StringIO from django.core.management import call_command from django.db import connections from django.test import SimpleTestCase, TestCase -from django.test.utils import ( - NullTimeKeeper, - TimeKeeper, - captured_stdout, - iter_test_cases, -) +from django.test.utils import NullTimeKeeper, TimeKeeper, iter_test_cases from django.test.utils import setup_databases as _setup_databases from django.test.utils import setup_test_environment from django.test.utils import teardown_databases as _teardown_databases @@ -433,8 +428,6 @@ def _init_worker( if value := serialized_contents.get(alias): connection._test_serialized_contents = value connection.creation.setup_worker_connection(_worker_id) - with captured_stdout(): - call_command("check", databases=connections) def _run_subsuite(args): diff --git a/tests/check_framework/tests.py b/tests/check_framework/tests.py index d064a7c403..f926308fd7 100644 --- a/tests/check_framework/tests.py +++ b/tests/check_framework/tests.py @@ -1,5 +1,7 @@ +import multiprocessing import sys from io import StringIO +from unittest import skipIf from django.apps import apps from django.core import checks @@ -361,6 +363,11 @@ class CheckFrameworkReservedNamesTests(SimpleTestCase): self.assertEqual(errors, expected) +@skipIf( + multiprocessing.get_start_method() == "spawn", + "Spawning reimports modules, overwriting my_check.did_run to False, making this " + "test useless.", +) class ChecksRunDuringTests(SimpleTestCase): databases = "__all__"