From 75f16982d839be682b4f54d9f179caa4a86c07a5 Mon Sep 17 00:00:00 2001 From: Jannis Leidel Date: Tue, 21 Dec 2010 15:07:09 +0000 Subject: [PATCH] Fixed #13782 -- Added CSS for errors in textareas and multiple fields in one line. Thanks, julien. git-svn-id: http://code.djangoproject.com/svn/django/trunk@14999 bcc190cf-cafb-0310-a4f2-bffc1f526a37 --- django/contrib/admin/helpers.py | 3 +++ django/contrib/admin/media/css/base.css | 2 +- .../contrib/admin/templates/admin/includes/fieldset.html | 7 ++++--- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/django/contrib/admin/helpers.py b/django/contrib/admin/helpers.py index 1f6d6de552..b90f5ecd79 100644 --- a/django/contrib/admin/helpers.py +++ b/django/contrib/admin/helpers.py @@ -127,6 +127,9 @@ class AdminField(object): attrs = classes and {'class': u' '.join(classes)} or {} return self.field.label_tag(contents=contents, attrs=attrs) + def errors(self): + return mark_safe(self.field.errors.as_ul()) + class AdminReadonlyField(object): def __init__(self, form, field, is_first, model_admin=None): label = label_for_field(field, form._meta.model, model_admin) diff --git a/django/contrib/admin/media/css/base.css b/django/contrib/admin/media/css/base.css index 57d6bfaba3..efae1acfc0 100644 --- a/django/contrib/admin/media/css/base.css +++ b/django/contrib/admin/media/css/base.css @@ -509,7 +509,7 @@ td ul.errorlist li { background: #ffc; } -.errors input, .errors select { +.errors input, .errors select, .errors textarea { border: 1px solid red; } diff --git a/django/contrib/admin/templates/admin/includes/fieldset.html b/django/contrib/admin/templates/admin/includes/fieldset.html index e3b1c6a38b..addfd0854c 100644 --- a/django/contrib/admin/templates/admin/includes/fieldset.html +++ b/django/contrib/admin/templates/admin/includes/fieldset.html @@ -4,10 +4,11 @@
{{ fieldset.description|safe }}
{% endif %} {% for line in fieldset %} -
- {{ line.errors }} +
+ {% if line.fields|length_is:'1' %}{{ line.errors }}{% endif %} {% for field in line %} - + + {% if not line.fields|length_is:'1' and not field.is_readonly %}{{ field.errors }}{% endif %} {% if field.is_checkbox %} {{ field.field }}{{ field.label_tag }} {% else %}