test0908
/
django
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Improved deprecation warning for change in form boolean values. 

refs #20684

Thanks jacob, jcd, and shai for the suggestions.
This commit is contained in:
Tim Graham 2013-09-10 14:23:31 -04:00
parent 4e96dac450
commit 8165c2cfd1
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
django/forms/util.py
View File

@ -23,11 +23,18 @@ def flatatt(attrs):
The result is passed through 'mark_safe'. The result is passed through 'mark_safe'.
""" """
if [v for v in attrs.values() if v is True or v is False]: for attr_name, value in attrs.items():
warnings.warn( if type(value) is bool:
'The meaning of boolean values for widget attributes will change in Django 1.8', warnings.warn(
DeprecationWarning "In Django 1.8, widget attribute %(attr_name)s=%(bool_value)s "
) "will %(action)s. To preserve current behavior, use the "
"string '%(bool_value)s' instead of the boolean value." % {
'attr_name': attr_name,
'action': "be rendered as '%s'" % attr_name if value else "not be rendered",
'bool_value': value,
},
DeprecationWarning
)
return format_html_join('', ' {0}="{1}"', sorted(attrs.items())) return format_html_join('', ' {0}="{1}"', sorted(attrs.items()))
@python_2_unicode_compatible @python_2_unicode_compatible