test0908
/
django
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed #28079 -- Restored "No POST data" (rather than an empty table) in HTML debug page. 

Regression in 7b6dccc82f
This commit is contained in:
Tim Graham 2017-04-15 09:21:35 -04:00 committed by GitHub
parent 89a080fc05
commit 8c6a3062dd
3 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
django/views/debug.py
View File

@ -299,7 +299,7 @@ class ExceptionReporter:
'frames': frames, 'frames': frames,
'request': self.request, 'request': self.request,
'user_str': user_str, 'user_str': user_str,
'filtered_POST_items': self.filter.get_post_parameters(self.request).items(), 'filtered_POST_items': list(self.filter.get_post_parameters(self.request).items()),
'settings': get_safe_settings(), 'settings': get_safe_settings(),
'sys_executable': sys.executable, 'sys_executable': sys.executable,
'sys_version_info': '%d.%d.%d' % sys.version_info[0:3], 'sys_version_info': '%d.%d.%d' % sys.version_info[0:3],

3
docs/releases/1.11.1.txt
View File

@ -21,3 +21,6 @@ Bugfixes
* Fixed ``QuerySet.filter()`` crash when it references the name of a * Fixed ``QuerySet.filter()`` crash when it references the name of a
``OneToOneField`` primary key (:ticket:`28047`). ``OneToOneField`` primary key (:ticket:`28047`).
* Fixed empty POST data table appearing instead of "No POST data" in HTML debug
page (:ticket:`28079`).

1
tests/view_tests/tests/test_debug.py
View File

@ -290,6 +290,7 @@ class ExceptionReporterTests(SimpleTestCase):
self.assertIn('<h2>Traceback ', html) self.assertIn('<h2>Traceback ', html)
self.assertIn('<h2>Request information</h2>', html) self.assertIn('<h2>Request information</h2>', html)
self.assertNotIn('<p>Request data not supplied</p>', html) self.assertNotIn('<p>Request data not supplied</p>', html)
self.assertIn('<p>No POST data</p>', html)
def test_no_request(self): def test_no_request(self):
"An exception report can be generated without request" "An exception report can be generated without request"