test0908
/
django
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Renamed an assertion in the dispatch tests.

This commit is contained in:
Tim Graham 2015-01-02 11:29:06 -05:00
parent 8958170755
commit 937fab030d
1 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
tests/dispatch/tests.py
View File

@ -45,7 +45,7 @@ d_signal = Signal(providing_args=["val"], use_caching=True)
class DispatcherTests(unittest.TestCase): class DispatcherTests(unittest.TestCase):
"""Test suite for dispatcher (barely started)""" """Test suite for dispatcher (barely started)"""
def _testIsClean(self, signal): def assertTestIsClean(self, signal):
"""Assert that everything has been cleaned up automatically""" """Assert that everything has been cleaned up automatically"""
# Note that dead weakref cleanup happens as side effect of using # Note that dead weakref cleanup happens as side effect of using
# the signal's receivers through the signals API. So, first do a # the signal's receivers through the signals API. So, first do a
@ -59,7 +59,7 @@ class DispatcherTests(unittest.TestCase):
result = a_signal.send(sender=self, val="test") result = a_signal.send(sender=self, val="test")
self.assertEqual(result, expected) self.assertEqual(result, expected)
a_signal.disconnect(receiver_1_arg, sender=self) a_signal.disconnect(receiver_1_arg, sender=self)
self._testIsClean(a_signal) self.assertTestIsClean(a_signal)
def test_ignored_sender(self): def test_ignored_sender(self):
a_signal.connect(receiver_1_arg) a_signal.connect(receiver_1_arg)
@ -67,7 +67,7 @@ class DispatcherTests(unittest.TestCase):
result = a_signal.send(sender=self, val="test") result = a_signal.send(sender=self, val="test")
self.assertEqual(result, expected) self.assertEqual(result, expected)
a_signal.disconnect(receiver_1_arg) a_signal.disconnect(receiver_1_arg)
self._testIsClean(a_signal) self.assertTestIsClean(a_signal)
def test_garbage_collected(self): def test_garbage_collected(self):
a = Callable() a = Callable()
@ -77,7 +77,7 @@ class DispatcherTests(unittest.TestCase):
garbage_collect() garbage_collect()
result = a_signal.send(sender=self, val="test") result = a_signal.send(sender=self, val="test")
self.assertEqual(result, expected) self.assertEqual(result, expected)
self._testIsClean(a_signal) self.assertTestIsClean(a_signal)
def test_cached_garbaged_collected(self): def test_cached_garbaged_collected(self):
""" """
@ -111,7 +111,7 @@ class DispatcherTests(unittest.TestCase):
del a del a
del result del result
garbage_collect() garbage_collect()
self._testIsClean(a_signal) self.assertTestIsClean(a_signal)
def test_uid_registration(self): def test_uid_registration(self):
def uid_based_receiver_1(**kwargs): def uid_based_receiver_1(**kwargs):
@ -124,10 +124,10 @@ class DispatcherTests(unittest.TestCase):
a_signal.connect(uid_based_receiver_2, dispatch_uid="uid") a_signal.connect(uid_based_receiver_2, dispatch_uid="uid")
self.assertEqual(len(a_signal.receivers), 1) self.assertEqual(len(a_signal.receivers), 1)
a_signal.disconnect(dispatch_uid="uid") a_signal.disconnect(dispatch_uid="uid")
self._testIsClean(a_signal) self.assertTestIsClean(a_signal)
def test_robust(self): def test_robust(self):
"""Test the sendRobust function""" """Test the send_robust() function"""
def fails(val, **kwargs): def fails(val, **kwargs):
raise ValueError('this') raise ValueError('this')
a_signal.connect(fails) a_signal.connect(fails)
@ -138,7 +138,7 @@ class DispatcherTests(unittest.TestCase):
self.assertTrue(hasattr(err, '__traceback__')) self.assertTrue(hasattr(err, '__traceback__'))
self.assertTrue(isinstance(err.__traceback__, TracebackType)) self.assertTrue(isinstance(err.__traceback__, TracebackType))
a_signal.disconnect(fails) a_signal.disconnect(fails)
self._testIsClean(a_signal) self.assertTestIsClean(a_signal)
def test_disconnection(self): def test_disconnection(self):
receiver_1 = Callable() receiver_1 = Callable()
@ -151,7 +151,7 @@ class DispatcherTests(unittest.TestCase):
del receiver_2 del receiver_2
garbage_collect() garbage_collect()
a_signal.disconnect(receiver_3) a_signal.disconnect(receiver_3)
self._testIsClean(a_signal) self.assertTestIsClean(a_signal)
def test_has_listeners(self): def test_has_listeners(self):
self.assertFalse(a_signal.has_listeners()) self.assertFalse(a_signal.has_listeners())
@ -168,7 +168,6 @@ class DispatcherTests(unittest.TestCase):
class ReceiverTestCase(unittest.TestCase): class ReceiverTestCase(unittest.TestCase):
""" """
Test suite for receiver. Test suite for receiver.
""" """
def test_receiver_single_signal(self): def test_receiver_single_signal(self):
@receiver(a_signal) @receiver(a_signal)