test0908
/
django
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed #26940 -- Removed makemessages from no_settings_commands whitelist 

As makemessages uses several settings for proper run (FILE_CHARSET,
LOCALE_PATHS, MEDIA_ROOT, and STATIC_ROOT), we should require settings
configuration for this command.
This commit is contained in:
Claude Paroz 2016-08-07 20:05:07 +02:00
parent 74105b2636
commit a6baada7bd
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
django/core/management/__init__.py
View File

@ -308,8 +308,7 @@ class ManagementUtility(object):
no_settings_commands = [ no_settings_commands = [
'help', 'version', '--help', '--version', '-h', 'help', 'version', '--help', '--version', '-h',
'compilemessages', 'makemessages', 'startapp', 'startproject', 'compilemessages',
'startapp', 'startproject',
] ]
try: try:

3
docs/releases/1.11.txt
View File

@ -374,6 +374,9 @@ Miscellaneous
called a second time before calling called a second time before calling
:func:`~django.test.utils.teardown_test_environment`. :func:`~django.test.utils.teardown_test_environment`.
* The :djadmin:`makemessages` command now requires configured settings, like
most other commands.
.. _deprecated-features-1.11: .. _deprecated-features-1.11:
Features deprecated in 1.11 Features deprecated in 1.11