test0908
/
django
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Removed unnecessary transaction wrapping in expressions test.

This commit is contained in:
Simon Charette 2019-01-15 23:39:23 -06:00 committed by Tim Graham
parent 876dc306cd
commit aa5d0a5a90
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tests/expressions/tests.py
View File

@ -5,7 +5,7 @@ import uuid
from copy import deepcopy from copy import deepcopy
from django.core.exceptions import FieldError from django.core.exceptions import FieldError
from django.db import DatabaseError, connection, models, transaction from django.db import DatabaseError, connection, models
from django.db.models import CharField, Q, TimeField, UUIDField from django.db.models import CharField, Q, TimeField, UUIDField
from django.db.models.aggregates import ( from django.db.models.aggregates import (
Avg, Count, Max, Min, StdDev, Sum, Variance, Avg, Count, Max, Min, StdDev, Sum, Variance,
@ -237,12 +237,11 @@ class BasicExpressionsTests(TestCase):
"foo", "foo",
) )
with transaction.atomic(): msg = "Joined field references are not permitted in this query"
msg = "Joined field references are not permitted in this query" with self.assertRaisesMessage(FieldError, msg):
with self.assertRaisesMessage(FieldError, msg): Company.objects.exclude(
Company.objects.exclude( ceo__firstname=F('point_of_contact__firstname')
ceo__firstname=F('point_of_contact__firstname') ).update(name=F('point_of_contact__lastname'))
).update(name=F('point_of_contact__lastname'))
def test_object_update(self): def test_object_update(self):
# F expressions can be used to update attributes on single objects # F expressions can be used to update attributes on single objects