From b131462d76d028ef8b0aaebdfcf3e63370e57c49 Mon Sep 17 00:00:00 2001 From: James Bennett Date: Sun, 5 Oct 2008 16:03:58 +0000 Subject: [PATCH] Add note to 1.0 porting guide about removal of dictionary access to HTTP request objects git-svn-id: http://code.djangoproject.com/svn/django/trunk@9153 bcc190cf-cafb-0310-a4f2-bffc1f526a37 --- docs/releases/1.0-porting-guide.txt | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/docs/releases/1.0-porting-guide.txt b/docs/releases/1.0-porting-guide.txt index c1605e4293..ba1a918e9a 100644 --- a/docs/releases/1.0-porting-guide.txt +++ b/docs/releases/1.0-porting-guide.txt @@ -567,6 +567,22 @@ it to ``_`` yourself:: HTTP request/response objects ----------------------------- +Dictionary access to ``HttpRequest`` +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +``HttpRequest`` objects no longer directly support dictionary-style +access; previously, both ``GET`` and ``POST`` data were directly +available on the ``HttpRequest`` object (e.g., you could check for a +piece of form data by using ``if 'some_form_key' in request`` or by +reading ``request['some_form_key']``. This is no longer supported; if +you need access to the combined ``GET`` and ``POST`` data, use +``request.REQUEST`` instead. + +It is strongly suggested, however, that you always explicitly look in +the appropriate dictionary for the type of request you expect to +receive (``request.GET`` or ``request.POST``); relying on the combined +``request.REQUEST`` dictionary can mask the origin of incoming data. + Accessing ``HTTPResponse`` headers ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~