test0908
/
django
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[1.7.X] Fixed #23602 -- Add comment on get_absolute_url regarding user input 

Backport of 04bd84786d from master.
This commit is contained in:
Carl Meyer 2014-10-06 11:30:33 -06:00
parent 082abce81e
commit b3569b3a82
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
docs/ref/models/instances.txt
View File

@ -592,6 +592,19 @@ framework </ref/contrib/syndication>`, use ``get_absolute_url()`` when it is
defined. If it makes sense for your model's instances to each have a unique defined. If it makes sense for your model's instances to each have a unique
URL, you should define ``get_absolute_url()``. URL, you should define ``get_absolute_url()``.
.. warning::
You should avoid building the URL from un-validated user input, in order to
reduce possibilities of link or redirect poisoning::
def get_absolute_url(self):
return '/%s/' % self.name
If ``self.name`` is ``'/example.com'`` this returns ``'//example.com/'``
which, in turn, is a valid schema relative URL but not the expected
``'/%2Fexample.com/'``.
It's good practice to use ``get_absolute_url()`` in templates, instead of It's good practice to use ``get_absolute_url()`` in templates, instead of
hard-coding your objects' URLs. For example, this template code is bad: hard-coding your objects' URLs. For example, this template code is bad: