From b4dce7c37ab7666b023ac791d2c46dad6c8aa637 Mon Sep 17 00:00:00 2001 From: Ramiro Morales Date: Fri, 15 Aug 2014 16:19:04 -0300 Subject: [PATCH] Fixed #23298 -- Made makemessages actually ignore specified dirs on Windows. This was detected by two failures in the i18n.test_extraction of our test suite. Refs #20422, refs #22336 --- django/core/management/commands/makemessages.py | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/django/core/management/commands/makemessages.py b/django/core/management/commands/makemessages.py index 335cfab238..0b0d200094 100644 --- a/django/core/management/commands/makemessages.py +++ b/django/core/management/commands/makemessages.py @@ -364,8 +364,17 @@ class Command(BaseCommand): fnmatch.fnmatchcase(path, pattern)) return any(ignore(pattern) for pattern in ignore_patterns) - dir_suffix = '%s*' % os.sep - norm_patterns = [p[:-len(dir_suffix)] if p.endswith(dir_suffix) else p for p in self.ignore_patterns] + ignore_patterns = [os.path.normcase(p) for p in self.ignore_patterns] + dir_suffixes = {'%s*' % path_sep for path_sep in {'/', os.sep}} + norm_patterns = [] + for p in ignore_patterns: + for dir_suffix in dir_suffixes: + if p.endswith(dir_suffix): + norm_patterns.append(p[:-len(dir_suffix)]) + break + else: + norm_patterns.append(p) + all_files = [] for dirpath, dirnames, filenames in os.walk(root, topdown=True, followlinks=self.symlinks): for dirname in dirnames[:]: