Fixed #25262 -- Removed the enable_comments field from FlatPageAdmin.

This commit is contained in:
Y3K 2015-08-28 14:13:41 -05:00 committed by Tim Graham
parent e75882332c
commit b649f68649
4 changed files with 44 additions and 4 deletions

View File

@ -8,11 +8,13 @@ class FlatPageAdmin(admin.ModelAdmin):
form = FlatpageForm form = FlatpageForm
fieldsets = ( fieldsets = (
(None, {'fields': ('url', 'title', 'content', 'sites')}), (None, {'fields': ('url', 'title', 'content', 'sites')}),
(_('Advanced options'), {'classes': ('collapse',), (_('Advanced options'), {
'fields': ('enable_comments', 'registration_required', 'template_name')}), 'classes': ('collapse',),
'fields': ('registration_required', 'template_name'),
}),
) )
list_display = ('url', 'title') list_display = ('url', 'title')
list_filter = ('sites', 'enable_comments', 'registration_required') list_filter = ('sites', 'registration_required')
search_fields = ('url', 'title') search_fields = ('url', 'title')
admin.site.register(FlatPage, FlatPageAdmin) admin.site.register(FlatPage, FlatPageAdmin)

View File

@ -330,7 +330,7 @@ subclass::
}), }),
('Advanced options', { ('Advanced options', {
'classes': ('collapse',), 'classes': ('collapse',),
'fields': ('enable_comments', 'registration_required', 'template_name') 'fields': ('registration_required', 'template_name'),
}), }),
) )

View File

@ -170,6 +170,8 @@ For more on middleware, read the :doc:`middleware docs
How to add, change and delete flatpages How to add, change and delete flatpages
======================================= =======================================
.. _flatpages-admin:
Via the admin interface Via the admin interface
----------------------- -----------------------
@ -177,6 +179,38 @@ If you've activated the automatic Django admin interface, you should see a
"Flatpages" section on the admin index page. Edit flatpages as you edit any "Flatpages" section on the admin index page. Edit flatpages as you edit any
other object in the system. other object in the system.
The ``FlatPage`` model has an ``enable_comments`` field that isn't used by
``contrib.flatpages``, but that could be useful for your project or third-party
apps. It doesn't appear in the admin interface, but you can add it by
registering a custom ``ModelAdmin`` for ``FlatPage``::
from django.contrib import admin
from django.contrib.flatpages.admin import FlatPageAdmin
from django.contrib.flatpages.models import FlatPage
from django.utils.translation import ugettext_lazy as _
# Define a new FlatPageAdmin
class FlatPageAdmin(FlatPageAdmin):
fieldsets = (
(None, {'fields': ('url', 'title', 'content', 'sites')}),
(_('Advanced options'), {
'classes': ('collapse', ),
'fields': (
'enable_comments',
'registration_required',
'template_name',
),
}),
)
# Re-register FlatPageAdmin
admin.site.unregister(FlatPage)
admin.site.register(FlatPage, FlatPageAdmin)
.. versionchanged:: 1.9
The ``enable_comments`` field was removed from ``FlatPageAdmin``.
Via the Python API Via the Python API
------------------ ------------------

View File

@ -996,6 +996,10 @@ Miscellaneous
levels. Previously, messages of ``ERROR`` level or higher were printed to the levels. Previously, messages of ``ERROR`` level or higher were printed to the
console. console.
* The ``FlatPage.enable_comments`` field is removed from the ``FlatPageAdmin``
as it's unused by the application. If your project or a third-party app makes
use of it, :ref:`create a custom ModelAdmin <flatpages-admin>` to add it back.
.. _deprecated-features-1.9: .. _deprecated-features-1.9:
Features deprecated in 1.9 Features deprecated in 1.9