From bb145e2c47d71b7f68280c00ced727442d2effa2 Mon Sep 17 00:00:00 2001 From: Thomas Sorrel Date: Sun, 21 Jul 2013 11:02:36 +0200 Subject: [PATCH] Fixed #13629 -- Added CSS classes to the `` tag of some admin templates to allow style customizations per app or per model. --- AUTHORS | 1 + django/contrib/admin/sites.py | 1 + .../admin/templates/admin/app_index.html | 2 + .../admin/templates/admin/change_form.html | 2 +- .../admin/templates/admin/change_list.html | 2 +- .../templates/admin/delete_confirmation.html | 2 + .../admin/delete_selected_confirmation.html | 2 + docs/releases/1.6.txt | 4 ++ tests/admin_views/tests.py | 53 +++++++++++++++++++ 9 files changed, 67 insertions(+), 2 deletions(-) diff --git a/AUTHORS b/AUTHORS index 640a31b7ba..a7f12d6e48 100644 --- a/AUTHORS +++ b/AUTHORS @@ -544,6 +544,7 @@ answer newbie questions, and generally made Django that much better: George Song sopel Leo Soto + Thomas Sorrel Wiliam Alves de Souza Don Spaulding Calvin Spealman diff --git a/django/contrib/admin/sites.py b/django/contrib/admin/sites.py index e0f43dfbfe..8abf49331b 100644 --- a/django/contrib/admin/sites.py +++ b/django/contrib/admin/sites.py @@ -439,6 +439,7 @@ class AdminSite(object): context = { 'title': _('%s administration') % capfirst(app_label), 'app_list': [app_dict], + 'app_label': app_label, } context.update(extra_context or {}) diff --git a/django/contrib/admin/templates/admin/app_index.html b/django/contrib/admin/templates/admin/app_index.html index 9f65357292..7aff935126 100644 --- a/django/contrib/admin/templates/admin/app_index.html +++ b/django/contrib/admin/templates/admin/app_index.html @@ -1,6 +1,8 @@ {% extends "admin/index.html" %} {% load i18n %} +{% block bodyclass %}app-{{ app_label }} {{ block.super }}{% endblock %} + {% if not is_popup %} {% block breadcrumbs %}
diff --git a/django/contrib/admin/templates/admin/change_form.html b/django/contrib/admin/templates/admin/change_form.html index d4935ed781..e35c7328f4 100644 --- a/django/contrib/admin/templates/admin/change_form.html +++ b/django/contrib/admin/templates/admin/change_form.html @@ -10,7 +10,7 @@ {% block coltype %}colM{% endblock %} -{% block bodyclass %}{{ opts.app_label }}-{{ opts.object_name.lower }} change-form{% endblock %} +{% block bodyclass %}app-{{ opts.app_label }} model-{{ opts.object_name.lower }} change-form{% endblock %} {% if not is_popup %} {% block breadcrumbs %} diff --git a/django/contrib/admin/templates/admin/change_list.html b/django/contrib/admin/templates/admin/change_list.html index 15583d1a8c..ce5c5b37a4 100644 --- a/django/contrib/admin/templates/admin/change_list.html +++ b/django/contrib/admin/templates/admin/change_list.html @@ -32,7 +32,7 @@ {% endif %}{% endif %} {% endblock %} -{% block bodyclass %}change-list{% endblock %} +{% block bodyclass %}app-{{ opts.app_label }} model-{{ opts.object_name.lower }} change-list{% endblock %} {% if not is_popup %} {% block breadcrumbs %} diff --git a/django/contrib/admin/templates/admin/delete_confirmation.html b/django/contrib/admin/templates/admin/delete_confirmation.html index 3ed60807b7..2e94b61485 100644 --- a/django/contrib/admin/templates/admin/delete_confirmation.html +++ b/django/contrib/admin/templates/admin/delete_confirmation.html @@ -1,6 +1,8 @@ {% extends "admin/base_site.html" %} {% load i18n admin_urls %} +{% block bodyclass %}app-{{ opts.app_label }} model-{{ opts.object_name.lower }} delete-confirmation{% endblock %} + {% block breadcrumbs %}
{% trans 'Home' %} diff --git a/django/contrib/admin/templates/admin/delete_selected_confirmation.html b/django/contrib/admin/templates/admin/delete_selected_confirmation.html index 36527dcbf5..a80f4e4a54 100644 --- a/django/contrib/admin/templates/admin/delete_selected_confirmation.html +++ b/django/contrib/admin/templates/admin/delete_selected_confirmation.html @@ -1,6 +1,8 @@ {% extends "admin/base_site.html" %} {% load i18n l10n admin_urls %} +{% block bodyclass %}app-{{ opts.app_label }} model-{{ opts.object_name.lower }} delete-confirmation delete-selected-confirmation{% endblock %} + {% block breadcrumbs %}
{% trans 'Home' %} diff --git a/docs/releases/1.6.txt b/docs/releases/1.6.txt index 1419f0915c..b8babe1843 100644 --- a/docs/releases/1.6.txt +++ b/docs/releases/1.6.txt @@ -199,6 +199,10 @@ Minor features * The admin list columns have a ``column-`` class in the HTML so the columns header can be styled with CSS, e.g. to set a column width. +* Some admin templates now have ``app-`` and ``model-`` + classes in their ```` tag to allow customizing the CSS per app or per + model. + * The :ref:`isolation level` can be customized under PostgreSQL. diff --git a/tests/admin_views/tests.py b/tests/admin_views/tests.py index a83c756a25..7decf6f471 100644 --- a/tests/admin_views/tests.py +++ b/tests/admin_views/tests.py @@ -3824,6 +3824,59 @@ class CSSTest(TestCase): self.assertContains(response, '') self.assertContains(response, '') + def testAppModelInFormBodyClass(self): + """ + Ensure app and model tag are correcly read by change_form template + """ + response = self.client.get('/test_admin/admin/admin_views/section/add/') + self.assertEqual(response.status_code, 200) + self.assertContains(response, + '