test0908
/
django
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed #15852 -- Modified cookie parsing so it can handle duplicate invalid cookie names. Thanks goes to Fredrik Stålnacke for the report and to vung for the patch. 

git-svn-id: http://code.djangoproject.com/svn/django/trunk@16452 bcc190cf-cafb-0310-a4f2-bffc1f526a37
This commit is contained in:
Ramiro Morales 2011-06-25 16:18:40 +00:00
parent 25c5251acd
commit c159374a33
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
django/http/__init__.py
View File

@ -91,7 +91,7 @@ else:
if not _cookie_allows_colon_in_names: if not _cookie_allows_colon_in_names:
def load(self, rawdata, ignore_parse_errors=False): def load(self, rawdata, ignore_parse_errors=False):
if ignore_parse_errors: if ignore_parse_errors:
self.bad_cookies = [] self.bad_cookies = set()
self._BaseCookie__set = self._loose_set self._BaseCookie__set = self._loose_set
super(SimpleCookie, self).load(rawdata) super(SimpleCookie, self).load(rawdata)
if ignore_parse_errors: if ignore_parse_errors:
@ -105,8 +105,8 @@ else:
try: try:
self._strict_set(key, real_value, coded_value) self._strict_set(key, real_value, coded_value)
except Cookie.CookieError: except Cookie.CookieError:
self.bad_cookies.append(key) self.bad_cookies.add(key)
dict.__setitem__(self, key, None) dict.__setitem__(self, key, Cookie.Morsel())
class CompatCookie(SimpleCookie): class CompatCookie(SimpleCookie):

6
tests/regressiontests/httpwrappers/tests.py
View File

@ -285,3 +285,9 @@ class CookieTests(unittest.TestCase):
Test that a single non-standard cookie name doesn't affect all cookies. Ticket #13007. Test that a single non-standard cookie name doesn't affect all cookies. Ticket #13007.
""" """
self.assertTrue('good_cookie' in parse_cookie('good_cookie=yes;bad:cookie=yes').keys()) self.assertTrue('good_cookie' in parse_cookie('good_cookie=yes;bad:cookie=yes').keys())
def test_repeated_nonstandard_keys(self):
"""
Test that a repeated non-standard name doesn't affect all cookies. Ticket #15852
"""
self.assertTrue('good_cookie' in parse_cookie('a,=b; a,=c; good_cookie=yes').keys())