From c305471610e8da8589b8b7b20a1a2b6c0dcbc3d9 Mon Sep 17 00:00:00 2001 From: Malcolm Tredinnick Date: Wed, 27 Aug 2008 07:04:58 +0000 Subject: [PATCH] Fixed get_absolute_url() for comments. Previously, it relied on "view on site" for admin being reversible or required people to set up their own version. Now we ship a default pattern in the comments URLs in a way that is unlikely to clash with anything else. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8614 bcc190cf-cafb-0310-a4f2-bffc1f526a37 --- django/contrib/comments/models.py | 5 ++--- django/contrib/comments/urls.py | 4 ++++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/django/contrib/comments/models.py b/django/contrib/comments/models.py index 779d67b691..7424ec041a 100644 --- a/django/contrib/comments/models.py +++ b/django/contrib/comments/models.py @@ -30,11 +30,10 @@ class BaseCommentAbstractModel(models.Model): def get_content_object_url(self): """ - Get a URL suitable for redirecting to the content object. Uses the - ``django.views.defaults.shortcut`` view, which thus must be installed. + Get a URL suitable for redirecting to the content object. """ return urlresolvers.reverse( - "django.views.defaults.shortcut", + "comments-url-redirect", args=(self.content_type_id, self.object_pk) ) diff --git a/django/contrib/comments/urls.py b/django/contrib/comments/urls.py index ed4f89d376..8fe4fbb6e4 100644 --- a/django/contrib/comments/urls.py +++ b/django/contrib/comments/urls.py @@ -13,3 +13,7 @@ urlpatterns = patterns('django.contrib.comments.views', url(r'^approved/$', 'moderation.approve_done', name='comments-approve-done'), ) +urlpatterns += patterns('', + url(r'^cr/(\d+)/(\w+)/$', 'django.views.defaults.shortcut', name='comments-url-redirect'), +) +