test0908
/
django
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed get_absolute_url() for comments. Previously, it relied on "view on site" 

for admin being reversible or required people to set up their own version. Now
we ship a default pattern in the comments URLs in a way that is unlikely to
clash with anything else.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@8614 bcc190cf-cafb-0310-a4f2-bffc1f526a37
This commit is contained in:
Malcolm Tredinnick 2008-08-27 07:04:58 +00:00
parent 157dbe2fff
commit c305471610
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
django/contrib/comments/models.py
View File

@ -30,11 +30,10 @@ class BaseCommentAbstractModel(models.Model):
def get_content_object_url(self): def get_content_object_url(self):
""" """
Get a URL suitable for redirecting to the content object. Uses the Get a URL suitable for redirecting to the content object.
``django.views.defaults.shortcut`` view, which thus must be installed.
""" """
return urlresolvers.reverse( return urlresolvers.reverse(
"django.views.defaults.shortcut", "comments-url-redirect",
args=(self.content_type_id, self.object_pk) args=(self.content_type_id, self.object_pk)
) )

4
django/contrib/comments/urls.py
View File

@ -13,3 +13,7 @@ urlpatterns = patterns('django.contrib.comments.views',
url(r'^approved/$', 'moderation.approve_done', name='comments-approve-done'), url(r'^approved/$', 'moderation.approve_done', name='comments-approve-done'),
) )
urlpatterns += patterns('',
url(r'^cr/(\d+)/(\w+)/$', 'django.views.defaults.shortcut', name='comments-url-redirect'),
)