Fixed #24207 -- Added 25D-type geometry field support to ogrinspect

Thanks Michael Diener for the report and sample data, and Tim Graham
for the review.
This commit is contained in:
Claude Paroz 2015-05-06 11:57:43 +02:00
parent 10f7cfeb2d
commit d1df1fd2bb
7 changed files with 19 additions and 9 deletions

View File

@ -85,3 +85,11 @@ class OGRGeomType(object):
elif s == 'Unknown': elif s == 'Unknown':
s = 'Geometry' s = 'Geometry'
return s + 'Field' return s + 'Field'
def to_multi(self):
"""
Transform Point, LineString, Polygon, and their 25D equivalents
to their Multi... counterpart.
"""
if self.name.startswith(('Point', 'LineString', 'Polygon')):
self.num += 3

View File

@ -43,11 +43,9 @@ def mapping(data_source, geom_name='geom', layer_key=0, multi_geom=False):
mfield += 'field' mfield += 'field'
_mapping[mfield] = field _mapping[mfield] = field
gtype = data_source[layer_key].geom_type gtype = data_source[layer_key].geom_type
if multi_geom and gtype.num in (1, 2, 3): if multi_geom:
prefix = 'MULTI' gtype.to_multi()
else: _mapping[geom_name] = str(gtype).upper()
prefix = ''
_mapping[geom_name] = prefix + str(gtype).upper()
return _mapping return _mapping
@ -210,10 +208,9 @@ def _ogrinspect(data_source, model_name, geom_name='geom', layer_key=0, srid=Non
# TODO: Autodetection of multigeometry types (see #7218). # TODO: Autodetection of multigeometry types (see #7218).
gtype = layer.geom_type gtype = layer.geom_type
if multi_geom and gtype.num in (1, 2, 3): if multi_geom:
geom_field = 'Multi%s' % gtype.django gtype.to_multi()
else: geom_field = gtype.django
geom_field = gtype.django
# Setting up the SRID keyword string. # Setting up the SRID keyword string.
if srid is None: if srid is None:

Binary file not shown.

View File

@ -0,0 +1 @@
PROJCS["MGI_Ferro_Austria_GK_East",GEOGCS["GCS_MGI_Ferro",DATUM["D_MGI",SPHEROID["Bessel_1841",6377397.155,299.1528128]],PRIMEM["Ferro",-17.66666666666667],UNIT["Degree",0.0174532925199433]],PROJECTION["Transverse_Mercator"],PARAMETER["False_Easting",0.0],PARAMETER["False_Northing",-5000000.0],PARAMETER["Central_Meridian",34.0],PARAMETER["Scale_Factor",1.0],PARAMETER["Latitude_Of_Origin",0.0],UNIT["Meter",1.0]]

Binary file not shown.

Binary file not shown.

View File

@ -91,6 +91,10 @@ class OGRInspectTest(TestCase):
shp_file = os.path.join(TEST_DATA, 'test_poly', 'test_poly.shp') shp_file = os.path.join(TEST_DATA, 'test_poly', 'test_poly.shp')
model_def = ogrinspect(shp_file, 'MyModel', multi_geom=True) model_def = ogrinspect(shp_file, 'MyModel', multi_geom=True)
self.assertIn('geom = models.MultiPolygonField(srid=-1)', model_def) self.assertIn('geom = models.MultiPolygonField(srid=-1)', model_def)
# Same test with a 25D-type geometry field
shp_file = os.path.join(TEST_DATA, 'gas_lines', 'gas_leitung.shp')
model_def = ogrinspect(shp_file, 'MyModel', multi_geom=True)
self.assertIn('geom = models.MultiLineStringField(srid=-1)', model_def)
def test_date_field(self): def test_date_field(self):
shp_file = os.path.join(TEST_DATA, 'cities', 'cities.shp') shp_file = os.path.join(TEST_DATA, 'cities', 'cities.shp')