test0908
/
django
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed #20961 -- Fixed HttpResponse default empty content 

Thanks epandurski at gmail.com for the report.
This commit is contained in:
Claude Paroz 2013-08-24 18:08:05 +02:00
parent f33db5a09a
commit f4e9804567
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
django/http/response.py
View File

@ -317,7 +317,7 @@ class HttpResponse(HttpResponseBase):
streaming = False streaming = False
def __init__(self, content='', *args, **kwargs): def __init__(self, content=b'', *args, **kwargs):
super(HttpResponse, self).__init__(*args, **kwargs) super(HttpResponse, self).__init__(*args, **kwargs)
# Content is a bytestring. See the `content` property methods. # Content is a bytestring. See the `content` property methods.
self.content = content self.content = content

7
tests/httpwrappers/tests.py
View File

@ -385,6 +385,13 @@ class HttpResponseTests(unittest.TestCase):
self.assertEqual(r.tell(), 6) self.assertEqual(r.tell(), 6)
self.assertEqual(r.content, b'abcdef') self.assertEqual(r.content, b'abcdef')
# with Content-Encoding header
r = HttpResponse()
r['Content-Encoding'] = 'winning'
r.write(b'abc')
r.write(b'def')
self.assertEqual(r.content, b'abcdef')
def test_unsafe_redirect(self): def test_unsafe_redirect(self):
bad_urls = [ bad_urls = [
'data:text/html,<script>window.alert("xss")</script>', 'data:text/html,<script>window.alert("xss")</script>',