From f62e5a1fba0c711706264d6b2ce2f5cd6b2c5073 Mon Sep 17 00:00:00 2001 From: Malcolm Tredinnick Date: Sun, 29 Jun 2008 23:47:31 +0000 Subject: [PATCH] A way better fix for the count() issue in [7787]. The first attempt was brain-damaged. Let's never speak of it again. git-svn-id: http://code.djangoproject.com/svn/django/trunk@7788 bcc190cf-cafb-0310-a4f2-bffc1f526a37 --- django/db/models/sql/query.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/django/db/models/sql/query.py b/django/db/models/sql/query.py index b0c58b969a..764a256006 100644 --- a/django/db/models/sql/query.py +++ b/django/db/models/sql/query.py @@ -218,7 +218,7 @@ class Query(object): obj.select_related = False obj.related_select_cols = [] obj.related_select_fields = [] - if obj.distinct and len(obj.select) > 1: + if len(obj.select) > 1: obj = self.clone(CountQuery, _query=obj, where=self.where_class(), distinct=False) obj.select = [] @@ -1484,6 +1484,8 @@ class Query(object): if not self.select: select = Count() else: + assert len(self.select) == 1, \ + "Cannot add count col with multiple cols in 'select': %r" % self.select select = Count(self.select[0]) else: opts = self.model._meta