From f8a634afa2b5810a7bfc17868ca216d277f0f24b Mon Sep 17 00:00:00 2001 From: Aymeric Augustin Date: Mon, 11 Mar 2013 23:30:02 +0100 Subject: [PATCH] Fixed tests that relied on MANAGERS not being empty. Regression in d0561242. --- tests/middleware/tests.py | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/tests/middleware/tests.py b/tests/middleware/tests.py index 74b8ab9601..f2f7f4df66 100644 --- a/tests/middleware/tests.py +++ b/tests/middleware/tests.py @@ -245,7 +245,8 @@ class CommonMiddlewareTest(TestCase): # Legacy tests for the 404 error reporting via email (to be removed in 1.8) @override_settings(IGNORABLE_404_URLS=(re.compile(r'foo'),), - SEND_BROKEN_LINK_EMAILS=True) + SEND_BROKEN_LINK_EMAILS=True, + MANAGERS=('PHB@dilbert.com',)) def test_404_error_reporting(self): request = self._get_request('regular_url/that/does/not/exist') request.META['HTTP_REFERER'] = '/another/url/' @@ -257,7 +258,8 @@ class CommonMiddlewareTest(TestCase): self.assertIn('Broken', mail.outbox[0].subject) @override_settings(IGNORABLE_404_URLS=(re.compile(r'foo'),), - SEND_BROKEN_LINK_EMAILS=True) + SEND_BROKEN_LINK_EMAILS=True, + MANAGERS=('PHB@dilbert.com',)) def test_404_error_reporting_no_referer(self): request = self._get_request('regular_url/that/does/not/exist') with warnings.catch_warnings(): @@ -267,7 +269,8 @@ class CommonMiddlewareTest(TestCase): self.assertEqual(len(mail.outbox), 0) @override_settings(IGNORABLE_404_URLS=(re.compile(r'foo'),), - SEND_BROKEN_LINK_EMAILS=True) + SEND_BROKEN_LINK_EMAILS=True, + MANAGERS=('PHB@dilbert.com',)) def test_404_error_reporting_ignored_url(self): request = self._get_request('foo_url/that/does/not/exist/either') request.META['HTTP_REFERER'] = '/another/url/' @@ -287,7 +290,10 @@ class CommonMiddlewareTest(TestCase): self.assertEqual(response.status_code, 301) -@override_settings(IGNORABLE_404_URLS=(re.compile(r'foo'),)) +@override_settings( + IGNORABLE_404_URLS=(re.compile(r'foo'),), + MANAGERS=('PHB@dilbert.com',), +) class BrokenLinkEmailsMiddlewareTest(TestCase): def setUp(self):