test0908
/
django
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed #14027 -- Ensure that reverse() raises an exception when you try to reverse None. Thanks to Alex for the report and patch. 

git-svn-id: http://code.djangoproject.com/svn/django/trunk@13499 bcc190cf-cafb-0310-a4f2-bffc1f526a37
This commit is contained in:
Russell Keith-Magee 2010-08-06 14:34:10 +00:00
parent d3ba8cb88b
commit f90a25551d
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
django/core/urlresolvers.py
View File

@ -217,6 +217,7 @@ class RegexURLResolver(object):
else: else:
bits = normalize(p_pattern) bits = normalize(p_pattern)
lookups.appendlist(pattern.callback, (bits, p_pattern)) lookups.appendlist(pattern.callback, (bits, p_pattern))
if pattern.name is not None:
lookups.appendlist(pattern.name, (bits, p_pattern)) lookups.appendlist(pattern.name, (bits, p_pattern))
self._reverse_dict = lookups self._reverse_dict = lookups
self._namespace_dict = namespaces self._namespace_dict = namespaces

4
tests/regressiontests/urlpatterns_reverse/tests.py
View File

@ -154,6 +154,10 @@ class URLPatternReverse(TestCase):
else: else:
self.assertEquals(got, expected) self.assertEquals(got, expected)
def test_reverse_none(self):
# Reversing None should raise an error, not return the last un-named view.
self.assertRaises(NoReverseMatch, reverse, None)
class ResolverTests(unittest.TestCase): class ResolverTests(unittest.TestCase):
def test_non_regex(self): def test_non_regex(self):
""" """