areski
97a38de230
Fixed #23112 -- Field.get_choices tries to index an iterable
2014-07-30 21:35:02 +02:00
Tim Graham
c2ab501bab
Fixed test failure on Windows.
...
os.close(fd) is needed to avoid "The process cannot access the file
because it is being used by another process"
2014-07-30 14:31:59 -04:00
Christoph Heer
d47409831f
Fixed #23067 -- Updated docs to use django-admin
2014-07-30 14:14:03 -04:00
Tim Graham
34c60c42b6
Fixed flake8 errors.
2014-07-30 12:58:53 -04:00
areski
67d7da5fb9
Fixed #23107 -- Made runserver output respect --no-color.
2014-07-30 12:58:53 -04:00
Kit La Touche
17e75d03f9
Fixed #23129 -- Added 'true' and 'false' to `NullBooleanField`.
...
JavaScript serializations of forms will sometimes render the boolean
values as the strings 'true' and 'false', in lower case. Rather than
repeat boilerplate in the JavaScript to circumvent this, it seems
reasonable to allow Django to understand the lower-case versions of the
booleans.
2014-07-29 19:55:55 -04:00
Andrew Godwin
a338e07735
Fixed #23101 : Prefer doing deletes before creates in autodetector.
...
Makes declined or missed renames still work (but drop data).
2014-07-29 09:38:51 -07:00
Marc Tamlyn
ef9f109013
Fixed #22962 -- Default values for ArrayField with migrations.
...
Fields normally try to force the default value to a string. As
translatable strings are not valid default values for ArrayField, we can
remove this behaviour which was causing issues with some migrations.
Thanks to @schinckel for the report.
2014-07-29 10:37:11 +01:00
Andrew Godwin
d6e73a876d
Fixed #23121 : AlterModelOptions operation not changing state right
2014-07-28 10:47:28 -07:00
Andrew Godwin
cb60d22bd9
Fixed #23100 : Individual FK creation missing dependencies
2014-07-28 10:32:43 -07:00
Simon Charette
80708ac772
Fixed #23113 -- ChoiceInput.render should take specified attrs into account.
...
Thanks to Tim Graham for the review.
2014-07-28 10:01:07 -04:00
Aymeric Augustin
729e4ae4f0
Fixed #23074 -- Avoided leaking savepoints in atomic.
...
Thanks Chow Loong Jin for the report and the initial patch.
2014-07-28 14:30:41 +02:00
Florian Apolloner
2f73b527dd
Fixed #23098 -- Checked that lazy choices are not evaluated too soon
...
Thanks Matthieu Agopian for the report.
2014-07-27 13:31:25 +02:00
Tushar Bhatia
11181a64f9
Fixed #22979 -- Moved bug* tests
2014-07-26 21:05:49 -04:00
Abraham Martin
e1347e9253
Fixed #23101 db_table wasn't copied in deconstruct
...
Forward port of 999758fc7a
from
stable/1.7.x
2014-07-26 10:00:02 -07:00
Andrew Godwin
805774df1f
Fixed #22944 : Bad dependency on FK alteration in autodetector
2014-07-26 09:22:19 -07:00
qingfeng
08451f17d0
Fixed #23060 -- Prevented UnicodeDecodeError in debug templatetag
2014-07-26 18:03:19 +02:00
Anubhav Joshi
5cdb8f8c1e
Fixed #16617 -- Added 'value' to BaseValidator params.
...
Also allowed overriding the default messages in subclasses of BaseValidator.
Thanks sperrygrove for initial patch.
2014-07-26 10:03:00 -04:00
Hiroki KIYOHARA
d0889863de
Fixed code to solve #23070 problem
...
Added a class to wrap callable in settings:
* Not to call in the debug page (#21345 ).
* Not to break the debug page if the callable forbidding to set attributes (#23070 ).
Thanks @bmispelon for giving me some advice.
2014-07-26 12:35:51 +02:00
Hiroki KIYOHARA
e569144910
Added test for the #23070 problem
2014-07-26 12:01:44 +02:00
Tim Graham
57d2b3f2a7
Fixed bad usage of rstrip() that caused test failure.
...
If the temporary file name contained a p or y as its last
characters, it would be stripped. refs #23083 .
2014-07-25 15:16:47 -04:00
Tim Graham
b8cb5ba708
Fixed #23083 -- Fixed runserver reloading when deleting a file.
...
Thanks Collin Anderson for the report and hirokiky for the fix.
2014-07-25 13:23:52 -04:00
Andrew Godwin
a64bc3df77
Fixed #23093 : soft application detection for swapped models
2014-07-25 09:35:38 -07:00
Andrew Godwin
ed4812692e
Merge pull request #2938 from dekkers/ticket_23071
...
Fixed #23071 -- Use last migration's name in dependency to other app
2014-07-25 08:53:57 -07:00
Moayad Mardini
6508db2ff9
Fixed #23088 -- Used `six` `range` type in `Paginator.page_range`.
2014-07-25 11:04:58 +03:00
Tim Graham
64e75c47ef
Fixed #23014 -- Infinite migration regression with unique/index_together.
2014-07-24 14:27:10 -04:00
Anubhav Joshi
b1abfb3c59
Fixed #21707 -- Added helpful error message when using {{ block.super }} in base template.
...
Thanks mitar for the suggestion.
2014-07-24 14:22:19 -04:00
Tim Graham
99cd80dc74
Silenced test warning for deprecated IPAddressField.
2014-07-24 11:27:26 -04:00
Tim Graham
66211b4b75
Silenced a Python 2 ImportWarning in a migrations test.
2014-07-24 09:24:52 -04:00
Tim Graham
577ced2aae
Silenced OptionParser deprecation warning in a test.
2014-07-24 08:51:47 -04:00
Tim Graham
936fba5878
Improved patching of sys.stdout in refs #23078 .
2014-07-24 08:46:29 -04:00
Tim Graham
9b1515906e
Removed usage of deprecated switch_to_*() selenium methods.
2014-07-24 08:25:15 -04:00
Nick Sandford
fa3cf006b2
Fixed #23078 -- Regression in update_contenttypes() interactivity.
...
Thanks raymond at adaptiv.nl for the report.
2014-07-23 08:45:09 -04:00
Jeroen Dekkers
3582698c13
Fixed #23071 -- Use last migration's name in dependency to other app
...
Changed the autodetector to lookup the name of the other app's last
migration in the graph and use that as dependency instead of using
__latest__.
2014-07-22 01:03:02 +02:00
Andrew Godwin
e24e9e0438
Fixed #23014 : Renaming not atomic with unique together
2014-07-21 11:36:34 +01:00
Andrew Godwin
7dacc6ae46
Fixed #23009 : Shorten FK identifiers in add_field and make consistent
2014-07-21 10:50:21 +01:00
Andrew Godwin
dcb4ed5170
Fixed #22975 : Don't call rename SQL if not needed
2014-07-21 10:14:00 +01:00
Andrew Godwin
2984b30ce8
Fixed #23039 : Don't try to serialize unmanaged models in tests
2014-07-21 10:09:31 +01:00
Damien Nozay
70c54a3694
Fixed #23028 : Added unique_togther support to inspectdb.
2014-07-18 16:10:59 +00:00
Andrew Godwin
145d231782
Fixed #23041 : Bad base dependencies for proxy models
2014-07-16 09:59:08 -07:00
Tim Graham
5954aa6db0
Added Chrome/IE support for a selenium test.
2014-07-16 10:52:49 -04:00
Claude Paroz
c5d8e4a0d1
Added forgotten files from commit 28efafa24c
2014-07-16 13:50:53 +02:00
Anssi Kääriäinen
f8df55050c
PEP8 cleanup
2014-07-16 12:48:49 +03:00
Gavin Wahl
6e2b82fdf6
Fixed #22998 -- Updated the fast_delete logic for GFKs
2014-07-16 12:28:00 +03:00
Claude Paroz
28efafa24c
Ignored STATIC_ROOT and MEDIA_ROOT in makemessages
...
Also alleviate issues with weird file names typically found in
MEDIA_ROOT directories (#23010 ).
Thanks Tim Graham for the review.
2014-07-16 09:38:57 +02:00
Tim Graham
0154965392
Fixed #23013 -- Fixed removing unique_together/index_together constraints in migrations.
...
Thanks melinath for the report.
2014-07-15 15:20:59 -04:00
Marc Tamlyn
b65a2001e7
Fixed #22907 -- Array contains must have same type.
2014-07-15 19:41:26 +01:00
Tim Graham
9a2ab62977
Fixed #23008 -- Fixed typo causing bad migration dependencies.
...
Thanks semenov for the report and Florian for investigation.
2014-07-15 08:48:29 -04:00
Claude Paroz
4e424084e6
Fixed #22991 -- Prevented *.pyc files in autoreload monitoring
...
This fixes a regression introduced in 6d302f639
.
Thanks lorinkoz at gmail.com for the report, Collin Anderson
for the initial patch and Simon Charette for the review.
2014-07-15 09:57:54 +02:00
Claude Paroz
5dcdbe95c7
Fixed #23005 -- Allowed specifying special fallback languages
...
This fixes the Chinese language issues described in #23005 but
also provides for other fallback exceptions by updating the
LANG_INFO structure.
Thanks caxekis at gmail.com for the report and Tim Graham for the
review.
2014-07-14 20:50:03 +02:00
Shai Berger
dd9b3312d0
Fixed name of database connection feature
2014-07-14 19:23:57 +03:00
Huu Nguyen
f7a78f9bba
Fixed #22791 -- Invoke interactive questioner only for conflicts in specified apps.
...
Thanks bendavis78 for the report and Tim Graham for the review.
2014-07-14 11:00:49 -04:00
Anssi Kääriäinen
efe87d3e48
Fixed #22992 -- regression in .filter(generic_fk=...) error message
...
Generic Foreign Keys can't be used as lhs in lookups for historical
reasons. Django 1.6 gave a FieldDoesNotExist exception when using GFKs
as lhs in lookups, but due to regression caused by lookup refactor patch
(20bab2cf9d
) the exception type was
changed to AttributeError.
It might be a good idea to add support for gfk__exact and gfk__in lookups
later on.
Thanks to glicerinu@gmail.com for the report. The code in this commit
was written by Tim Graham.
2014-07-14 10:50:41 -04:00
Anssi Kääriäinen
9cd5201abd
Fixed #22994 -- regression with generic FK + admin list_view
...
The reason for the regression was that the GenericForeignKey field isn't
something meta.get_field_by_name() should return. The reason is that a
couple of places in Django expects get_field_by_name() to work this way.
It could make sense to return GFKs from get_field_by_name(), but that
should likely be done as part of meta refactoring or virtual fields
refactoring patches.
Thanks to glicerinu@gmail.com for the report and to Tim for working on
the issue.
2014-07-14 10:50:41 -04:00
Tim Graham
38e001ab6c
Fixed #22789 -- Deprecated django.contrib.webdesign.
...
Moved the {% lorem %} tag to built-in tags.
2014-07-14 08:45:19 -04:00
Claude Paroz
22b2fb0ba1
Fixed #22939 -- Delayed admin_static backend detection
...
Thanks generalov for the report.
2014-07-12 18:49:43 +02:00
Andrew Godwin
9e5a37c82d
Fix comment
2014-07-10 10:00:31 -07:00
Andrew Godwin
008bff92b7
Fixed #22970 : Incorrect dependencies for existing migrated apps
2014-07-09 23:53:43 -07:00
Josh Smeaton
b7455b52a0
Fixed #22988 -- Adjusted an introspection test assertion.
...
Also changed test to use assertNotIn.
2014-07-10 00:47:57 -04:00
Anubhav Joshi
011abb7d96
Fixed #19671 -- Added warnings that null and validators are ignored for ManyToManyField.
...
Thanks Loic Bistuer and Tim Graham for help and review.
2014-07-09 16:01:09 -04:00
Tim Graham
5e2c4a4bd1
Fixed #13794 -- Fixed to_field usage in BaseInlineFormSet.
...
Thanks sebastien at clarisys.fr for the report and gautier
for the patch.
2014-07-09 07:59:20 -04:00
Claude Paroz
e167e96cfe
Fixed #22223 -- Prevented over-escaping URLs in reverse()
...
And follow more closely the class of characters defined in the
RFC 3986.
Thanks Erik van Zijst for the report and the initial patch, and
Tim Graham for the review.
2014-07-09 09:54:34 +02:00
Daniel Pyrathon
865bc71783
Added a unit test to ensure models cannot be ordered by a M2M field.
2014-07-08 09:19:08 -04:00
Tim Graham
136a3ffe21
Removed unnecessary directory in dispatch tests.
2014-07-07 19:21:47 -04:00
Tim Graham
fddd95254e
Fixed flake8 errors.
2014-07-07 19:12:39 -04:00
Tim Graham
89b9e6e5d6
Fixed #22909 -- Removed camelCasing in some tests.
...
Thanks brylie.
2014-07-07 19:08:42 -04:00
Claude Paroz
6d302f6396
Fixed pyinotify performance regression in 15f82c7011
...
Refs #9722 . Thanks Tim Graham for the review.
2014-07-06 21:41:02 +02:00
Claude Paroz
b144bfb5ce
Fixed #21079 -- Further normalized table names in inspectdb
...
Thanks Michael Manfre for the report and Tim Graham for the review.
2014-07-06 21:19:27 +02:00
Loic Bistuer
2572c07cc6
Fixed #22906 -- Added a more helpful repr to migrations' ModelState.
...
Thanks Collin Anderson for the report and original patch.
2014-07-06 14:56:18 +07:00
Tim Graham
86c74eacd6
Updated tests per previous commit.
2014-07-05 20:20:19 -04:00
Andrew Godwin
f751109cb2
Merge pull request #2881 from charettes/ticket-22943-compiled-regex-deconstruction
...
Fixed #22943 -- Correctly serialize compiled regexes.
2014-07-05 16:37:10 -07:00
Andrew Godwin
80a12f21e3
Fixed #22960 : Bad handling of relations as PKs in autodetector
2014-07-05 16:33:03 -07:00
Claude Paroz
dd9a23d5cf
Fixed #22950 -- Eased markup customization for choice field rendering
...
Thanks Patrick Robertson for the report.
2014-07-05 13:36:49 +02:00
Claude Paroz
9209049211
Ensured bound field renders as unicode safe data
...
Refs #22950 .
2014-07-05 11:42:27 +02:00
Tim Graham
1f8bb95cc2
Corrected domain max length for EmailValidator; refs #20631 .
...
Thanks MarkusH for the report.
2014-07-04 20:50:28 -04:00
Tim Graham
7fd55c3481
Fixed #20631 -- Increased the default EmailField max_length to 254.
...
Thanks pmartin for the report.
2014-07-04 14:15:00 -04:00
Simon Charette
35c2c37041
Fixed #22943 -- Correctly serialize compiled regexes.
...
Thanks to antialiasis at gmail dot com for the patch.
2014-07-04 13:34:20 -04:00
Loic Bistuer
1966054feb
Fixed #22915 -- Document backward incompatible changes in the ValidationError constructor.
...
This patch also fixes update_error_dict to better handle the use case described
in this ticket, previously the type of the provided container could be lost in
some conditions.
Thanks Russell Keith-Magee for the report and Tim Graham for review.
2014-07-04 17:05:31 +07:00
LarryBrid
1bb1d3168b
Updated urlize regex following a93ee5112d
...
Prevent urlize from turning some.organization, an.intern etc.
into urls. Refs #22941 .
2014-07-04 09:00:16 +02:00
LarryBrid
a93ee5112d
Fixed #22941 - Added support for domain-only links with chars after the TLD to urlize.
...
It now works with something like google.com/foo/bar
2014-07-02 20:36:53 -04:00
Anubhav Joshi
10e83d48a3
Fixed #22935 -- Changed ForeignKey.default_error_messages['invalid'] to refer to correct field.
...
Thanks Tim Graham for suggestion and review.
2014-07-02 13:01:36 -04:00
Colin Wood
27ee608b55
Fixed #22940 -- Added missing string iterpolation parameters in migrations.writer error.
...
Forwardport of f5740af868
from stable/1.7.x
2014-07-02 12:45:02 -04:00
Tim Graham
3de4f8bab6
assertEquals -> assertEqual
2014-07-02 10:11:52 -04:00
Curtis
71461b14ab
Fixed #22691 -- Added aliasing to cached_property.
2014-07-01 06:32:53 -04:00
Anubhav Joshi
34ba86706f
Fixed #14334 -- Query relation lookups now check object types.
...
Thanks rpbarlow for the suggestion; and loic, akaariai, and jorgecarleitao
for reviews.
2014-07-01 06:12:58 -04:00
Julia Matsieva
29c1151a55
Fixed #22756 -- Added view name to technical 404 template if Http404 is raised.
...
Thanks Keryn Knight for the suggestion.
2014-06-30 15:34:35 -04:00
Anubhav Joshi
fd5897193f
Fixed problem with refs #10811 .
...
When 'to_field' is specified with a FK, then we need to check the pk value
the object.
2014-06-30 10:25:57 -04:00
Tim Graham
add78c58b5
Added spaces to message from 4c39c270af
.
2014-06-30 07:39:35 -04:00
Tim Graham
70576740b0
Fixed #22917 -- Fixed typo in AlterIndexTogether.describe().
2014-06-27 10:34:48 -04:00
Riccardo Magliocchetti
68c9a72e29
Fixed #22894 -- Made admin add related/raw ID fields widgets customizable.
...
Decoupled behavior and style from the RelatedFieldWidgetWrapper and
ForeignKeyRawIdWidget.
2014-06-26 15:02:42 -04:00
zsoldosp
7e2c804c94
Split tests.basic.ModelTests in several tests; refs #18586 .
2014-06-25 15:39:56 -04:00
Tim Graham
e0cd07ec2f
Fixed #22903 -- Fixed migration generation if index_together or unique_together is removed from a model.
2014-06-25 10:02:12 -04:00
Tim Graham
e769846eec
Removed unused variable.
2014-06-25 08:37:12 -04:00
Lovas Bence
9385aa3198
Fixed #22050 -- Fixed defer fields on proxy related models.
2014-06-25 07:20:18 -04:00
Tim Graham
815e7a5721
Fixed #20128 -- Made CsrfViewMiddleware ignore IOError when reading POST data.
...
Thanks Walter Doekes.
2014-06-25 07:08:16 -04:00
Duncan Parkes
fd4ccd045c
Fixed #22799 -- Made GET and POST on HttpRequest QueryDicts, and FILES a MultiValueDict.
...
Previously, GET, POST, and FILES on an HttpRequest were created in
the __init__ method as dictionaries. This was not something you would
usually notice causing trouble in production as you'd only see a
WSGIRequest, but in testing using the test client, calling .getlist
on GET, POST, or FILES for a request with no get/post data resulted in
an AttributeError.
Changed GET and POST on an HttpRequest object to be mutable
QueryDicts (mutable because the Django tests, and probably many
third party tests, were expecting it).
2014-06-24 22:03:22 -04:00
Duncan Parkes
d68987ae25
Fixed #22897 -- Made QueryDict query_string argument optional.
...
Now QueryDict() is equivalent to QueryDict('') or QueryDict(None).
2014-06-24 22:02:03 -04:00
Anubhav Joshi
dbbcfca476
Fixed #21668 -- Return detailed error page when SuspiciousOperation is raised and DEBUG=True
...
Thanks GDorn and gox21 for report.
Thanks Tim Graham for idea and review.
2014-06-24 08:55:36 -04:00
Andrew Godwin
fe262c0b84
Fixed #22708 : Typo in autodetector base dependency gen
2014-06-23 20:48:33 -07:00
Andrew Godwin
0b571753a8
Fixed #22889 : Unneeded to_field in fk.deconstruct causing swap issues
2014-06-23 20:39:17 -07:00
Andrew Godwin
0fba4c0ed7
Fixed #22487 : Don't flush out data from before normal TestCases
2014-06-23 20:25:09 -07:00
Anubhav Joshi
7f76251fb7
Refactored common code in handlers/base.py and urlresolvers.py
2014-06-23 15:27:25 -04:00
Anubhav Joshi
1c50d6ae2b
Fixed problem introduced with #refs 13711.
2014-06-23 19:36:40 +03:00
Tim Graham
908160f692
Fixed test failures introduced by refs #22881 .
2014-06-23 09:59:36 -04:00
Claude Paroz
809362518d
Created import-time test temp dirs in known location
...
Refs #17215 . In the same spirit as 5de31cb8cb
.
2014-06-23 14:54:25 +02:00
Claude Paroz
1d9596025e
Ensured cache tests do not leak temp dirs
...
Refs #17215 .
2014-06-23 14:06:04 +02:00
Chris Beaven
21c496ea52
Fixed #22881 -- Better soft_applied migration detection
2014-06-23 13:36:22 +12:00
Andrew Godwin
b30d32ff24
Fixed #22875 : Optimizer did not take through= into account.
2014-06-22 11:23:45 -07:00
Claude Paroz
c6a711d9e5
Removed some apps from ALWAYS_INSTALLED_APPS
2014-06-21 21:01:37 +02:00
Vlastimil Zíma
78c32f1caa
Fixed #22514 -- Prevented indexes on virtual fields [postgres].
2014-06-20 11:59:02 -04:00
Tim Graham
9a46836a0c
Moved a line outside of try/except to prevent an error in finally.
...
Thanks Ian Foote.
2014-06-20 09:13:34 -04:00
Huu Nguyen
fbb684d95e
Fixed #22862 -- Added --noinput option to makemigrations.
...
Thanks artortenburger for the report.
2014-06-20 08:55:02 -04:00
Daniel Pyrathon
d862fae5bb
Refs #12663 -- Added tests for methods in db.models.options.
...
Thanks Russell Keith-Magee and Tim Graham for reviews.
2014-06-19 12:56:36 -04:00
Maxime Turcotte
9996158db4
Fixed #22835 -- Deprecated NoArgsCommand.
2014-06-19 08:54:59 -04:00
Renaud Parent
87d0a3384c
Fixed #22778 -- Added a model Meta option to define default_related_name.
...
Thanks jorgecarleitao and mmardini for reviews.
2014-06-18 13:53:07 -04:00
Alex Gaynor
d015c9d11c
Fixed several flake8 errors
2014-06-18 07:47:13 -07:00
Andrew Godwin
2cee1d4642
Fixed #22861 : Internal migrations done first so __first__ works
...
Thanks to Chris Beaven.
2014-06-17 23:28:35 -07:00
Andrew Godwin
09b63a7cce
Fix __latest__ to actually resolve to the latest migration
2014-06-17 22:12:31 -07:00
Andrew Godwin
405b9dcd8b
Fix broken test
2014-06-17 21:32:23 -07:00
Andrew Godwin
8d2ac948a9
Fixed #22853 : Swapped models are now ignored for migration operations.
2014-06-17 17:45:38 -07:00
Anubhav Joshi
91f1b6dcdc
Fixed #13711 -- Model check added to ensure that auto-generated column name is within limits of the database.
...
Thanks russellm for report and Tim Graham for review.
2014-06-17 16:16:02 -04:00
Andrew Godwin
77ff4a9360
Fix previous commit on python 2
2014-06-17 09:56:22 -07:00
Andrew Godwin
66a99fa210
Merge pull request #2824 from valberg/22577
...
Fixed #22577 : Python 3 broke on non-module migrations directory
2014-06-17 09:54:39 -07:00
Víðir Valberg Guðmundsson
3a6cb9f497
Fixed #22577 : Python 3 broke on non-module migrations directory
2014-06-17 18:21:38 +02:00
Tim Graham
95cc0e15b4
Fixed #22819 -- Renamed output_type -> output_field in query expression API.
...
Thanks jorgecarleitao for the suggestion.
2014-06-17 11:57:16 -04:00
Andrew Godwin
61d7ae31cf
Fix test breakage on MySQL
2014-06-17 00:36:27 -07:00
Andrew Godwin
b22917bd50
Fixed #22851 : BinaryView wasn't getting a binary default
2014-06-16 18:44:08 -07:00
Tim Graham
82c935d44c
Renamed DatabaseFeature.supports_check_constraints to supports_column_check_constraints.
...
Thanks maxi for the suggestion.
2014-06-16 19:25:13 -04:00
Tim Graham
317c480c04
Removed some u'' prefixes to fix Python 3.2.
2014-06-16 18:49:37 -04:00
Vincent-Vega
4529af9ecf
Fixed #22845 -- Correctly handled memcached default timeout value.
2014-06-16 16:34:00 -04:00
Tim Graham
b341f33697
Added database migration for contrib.auth.
...
refs #22170 .
2014-06-16 16:21:37 -04:00
Tim Graham
eb8600a656
Added database migration for contrib.contenttypes.
...
Moved contenttypes tests to allow them to run correctly in the presence of
migrations. refs #22170 .
2014-06-16 15:03:00 -04:00
Andrew Godwin
067b9668fb
Fixed #22783 : Make sure swappable models come first in creation
2014-06-16 10:20:05 -07:00
Matthew Schinckel
bb39037fcb
Fixed #22788 -- Ensured custom migration operations can be written.
...
This inspects the migration operation, and if it is not in the
django.db.migrations module, it adds the relevant imports to the
migration writer and uses the correct class name.
2014-06-16 12:28:52 -04:00
Tim Graham
808388c28c
Removed usaged of contrib.sessions as a placeholder in migration tests.
...
Without this, we're unable to add actual migrations for the app.
2014-06-16 10:15:19 -04:00
Andrew Godwin
c8c79367a2
Fixed #22844 : Duplicate SQL for SQLite FKs
2014-06-16 00:27:32 -07:00
Alex Gaynor
d17a4cb037
Fixed several flake8 errors
2014-06-15 20:45:15 -04:00
Andrew Godwin
c1276785f9
Fixed #22568 : Better proxy model support in migrations
2014-06-15 16:01:49 -07:00
Andrew Godwin
a8ce5fdc28
Fixed #22470 : Full migration support for order_with_respect_to
2014-06-15 14:56:51 -07:00
Andrew Godwin
a58f49d104
Persist non-schema-relevant Meta changes in migrations
2014-06-15 12:34:02 -07:00
Andrew Godwin
f717ef083a
Fixed #22833 : Autodetector not doing through mapping correctly
2014-06-15 12:06:48 -07:00
Claude Paroz
c24e979ece
Fixed #7762 -- Hidden full script name in command error output
2014-06-14 20:01:02 +02:00
Claude Paroz
5949c2118d
Restored command error behavior when called from command line
...
Refs #19973 .
2014-06-14 18:53:33 +02:00
Alex Gaynor
2ca5fc55b0
Fixed several flake8 errors
2014-06-14 10:20:42 -04:00
Claude Paroz
f17b24e407
Converted remaining management commands to argparse
2014-06-14 13:43:44 +02:00
Claude Paroz
4b4524291a
Converted test management command to argparse
...
Keeping backwards compatibility with test_runner.option_list is
tricky and would imply transforming an optparse.Option to an
argparse.Action. I choose to introduce a backwards incompatible
change because it only affects testing, not runtime behavior.
2014-06-14 13:43:39 +02:00
Claude Paroz
8568638603
Fixed #19973 -- Replaced optparse by argparse in management commands
...
Thanks Tim Graham for the review.
2014-06-14 11:17:48 +02:00
Mark Lavin
79956d0694
Fixed #22440 -- Updated ConditionalGetMiddleware to comply with RFC 2616.
2014-06-13 20:01:35 -04:00
Shai Berger
612290400f
Fixed #22816 -- Corrected Oracle feature flag and fixed introspection test
2014-06-14 00:43:49 +03:00
Xavier Fernandez
50b9313e0a
Fixed #22771 -- Fixed test.Client.logout when using custom auth backend.
2014-06-13 13:03:58 -04:00
mlavin
4696cd9671
Fixed #22477 -- Removed contrib middleware from the global settings defaults.
...
Also added a compatibility check for changed middleware defaults.
Forwardport of d94de802d3
from stable/1.7.x
2014-06-13 12:45:56 -04:00
Maxime Turcotte
504c89e800
Fixed #6327 -- Added has_module_permission method to BaseModelAdmin
...
Thanks chrj for the suggestion.
2014-06-13 09:31:40 -04:00
Greg Chapple
bf743a4d57
Fixed #16087 -- Added ResolverMatch instance to test client response.
...
Thanks mrmachine for the suggestion.
2014-06-13 08:50:43 -04:00
Andrew Godwin
7b17350a1b
Fixed #22823 (and partly #22563 ) - FKs from unmigrated apps breaking state.
...
Thanks to bendavis78 for the test and diagnostic work.
2014-06-12 10:22:43 -07:00
Tim Graham
9980f67154
Fixed a staticfiles test on Windows.
2014-06-12 13:08:27 -04:00
Richard Eames
7beaeeed2b
Fixed #22814 -- Allowed ISO-8601 [+-]hh timezone format in parse_datetime
2014-06-12 10:58:50 -06:00
Tim Graham
a2cd0e12c9
Silenced deprecation warnings for refs #22811 and fixed build.
2014-06-12 09:28:36 -04:00
Tim Graham
1c58cabad7
Fixed #22811 -- Allowed setting both the old and new TEST database settings.
...
An ImproperlyConfigured exception will be raised they mismatch.
2014-06-12 08:17:49 -04:00
Shai Berger
64d94cffc7
Fixed #22487 : Separated schema migration from data migration in test
...
The data migration failed on Oracle, killing the entire test suite.
Thanks timo for reporting the Oracle breakage,
and andrewgodwin for suggesting the solution.
2014-06-11 20:25:02 +03:00
Tim Graham
99f5ea9cc8
Fixed #22653 -- Added some database feature flags to tests.
...
Thanks Rahul Priyadarshi.
2014-06-11 11:45:18 -04:00
Moayad Mardini
5a3ae7e260
Created a new tests folder (`model_options`).
...
And moved `tablespaces` option tests to it.
The new folder can be used to test models/options, like the new option
added in refs #22778 .
2014-06-11 11:37:52 -04:00
Preston Timmons
68efbfde5e
Fixed #22068 -- Made runtests.py remove trailing slashes from test labels.
...
When using tab-completion it's easy to accidentally run a test with
a trailing slash, which causes INSTALLED_APPS to be set incorrectly.
Normalize the test labels to avoid this common error.
Thanks MattBlack for the suggestion.
2014-06-11 11:35:33 -04:00
Anubhav Joshi
42736ac8e8
Fixed #21430 -- Added a RuntimeWarning when unpickling Models and QuerySets from a different Django version.
...
Thanks FunkyBob for the suggestion, prasoon2211 for the initial patch,
and akaariai, loic, and charettes for helping in shaping the patch.
2014-06-11 10:03:34 -04:00
Alex Gaynor
e163a3d17b
Removed an unused local variable, fixes a flake8 error
2014-06-11 00:22:30 -07:00
Florian Apolloner
e2efc8965e
Fixed #22680 -- I/O operation on closed file.
...
This patch is two-fold; first it ensure that Django does close everything in
request.FILES at the end of the request and secondly the storage system should
no longer close any files during save, it's up to the caller to handle that --
or let Django close the files at the end of the request.
2014-06-11 08:57:30 +02:00
Tim Schaffer
a1c6cd6a16
Fixed #22780 -- Checked that LOCALE_PATHS is really a tuple
2014-06-10 23:04:24 +02:00
Moayad Mardini
868ff4e37c
Fixed #22798 -- `pluralize()` now adds plural_suffix for any `1 < d < 2`
...
Thanks Odd_Bloke for the report.
2014-06-10 16:04:43 -04:00
Greg Chapple
d8f19bb3b6
Fixed #22792 -- Updated checks for list_display_links in model admin
2014-06-10 09:35:05 -04:00
Aymeric Augustin
df09d85482
Fixed #17552 -- Removed a hack for IE6 and earlier.
...
It prevented the GZipMiddleware from compressing some data types even on
more recent version of IE where the corresponding bug was fixed.
Thanks Aaron Cannon for the report and Tim Graham for the review.
2014-06-10 08:42:31 +02:00
Tim Graham
fea8ccdcc4
Removed unused import.
2014-06-09 18:41:35 -04:00
Aymeric Augustin
40bfd8561d
Fixed #20420 -- Normalized query counts on Oracle.
...
This is achieved by inserting a fake entry in connection.queries when
not releasing a savepoint (since Oracle doesn't support that operation.)
Also removed the can_release_savepoints feature that was recently added,
but is superseded by this solution.
2014-06-09 21:38:10 +02:00
Andrew Godwin
f146e70cb1
Remove overzealous migration flushes from migration test suite
2014-06-09 09:52:23 -07:00
Claude Paroz
96e4b52ab2
Converted Django scripts to argparse
...
Refs #19973 .
2014-06-09 10:13:37 +02:00
Andrew Godwin
7018bcfb71
Fix broken alias testing test
2014-06-08 20:07:35 -07:00
Andrew Godwin
8c12d51ea2
Fixed #22487 : Optional rollback emulation for migrated apps
2014-06-08 19:30:15 -07:00
Andrew Godwin
8721adcbfb
Fix router_honored test to not close connection
2014-06-08 18:57:55 -07:00
Andrew Godwin
3f91238adf
Fixed #22777 : Add dependency on through for autodetected M2M adds
2014-06-08 17:12:59 -07:00
Andrew Godwin
4ce7a6bc84
Fixed #22750 , #22248 : Model renaming now also alters field FKs
2014-06-07 18:18:02 -07:00
Tim Graham
6c27ff957a
Fixed flake8 error.
2014-06-07 20:35:28 -04:00
Víðir Valberg Guðmundsson
f70f669941
Fixed #22749 : Making SQL management commands migration aware.
2014-06-07 17:18:30 -07:00
Andrew Godwin
6fd455adfc
Fixed #22436 : More careful checking on method ref'ce serialization
2014-06-07 17:05:51 -07:00
Aymeric Augustin
1a01e24331
Tested pluralization of decimals.
...
Refs #16723 .
2014-06-07 23:12:13 +02:00
Aymeric Augustin
47a9347b98
Fixed #6992 -- Improved error when middleware omits HttpResponse.
...
Thanks guettli for the report.
2014-06-07 19:48:45 +02:00
Aymeric Augustin
fc31319752
Fixed test again. Refs #12581 .
2014-06-07 17:16:49 +02:00
Aymeric Augustin
58de495c54
Fixed #17427 -- Removed dubious definition of connections equality.
2014-06-07 17:04:10 +02:00
Aymeric Augustin
d98cc41a84
Made a test compatible with Python 2 and 3.
2014-06-07 15:04:06 +02:00
Unai Zalakain
11284a63d4
Fixed #18314 -- Corrected request.build_absolute_uri() handling of paths starting with //
...
``HttpRequest.build_absolute_uri()`` now correctly handles paths starting with ``//``.
``WSGIRequest`` now doesn't remove all the leading slashes either,
because ``http://test/server `` and http://test//server `` aren't the same thing
(RFC2396).
Thanks to SmileyChris for the initial patch.
2014-06-07 08:59:02 -04:00
Aymeric Augustin
cfcca7ccce
Fixed #3711 , #6734 , #12581 -- Bounded connection.queries.
...
Prevented unlimited memory consumption when running background tasks
with DEBUG=True.
Thanks Rob, Alex, Baptiste, and others.
2014-06-07 14:37:43 +02:00
Aymeric Augustin
1181b8a4a9
Merge pull request #2764 from gchp/ticket-20550
...
Fixed #20550 -- Added keepdb argument to destroy_test_db
2014-06-06 14:05:41 +02:00
Claude Paroz
daaeb84158
Fixed #22773 -- Forced templatize() to return unicode
2014-06-06 08:42:52 +02:00
Andrew Godwin
aa12ea05ce
Rewrote migration autodetector to involve actual computer science.
...
Fixes #22605 , #22735 ; also lays the ground for some other fixes.
2014-06-05 23:25:35 -07:00
Andrew Godwin
5826dc5282
Merge pull request #2736 from SmileyChris/migration-run_before
...
Fixed #22725 - Migration.run_before does nothing
2014-06-05 20:29:26 -07:00
Aymeric Augustin
e071f67b7f
Replaced an explicit vendor check by a feature flag.
...
Forward-port of c9aedce0
from stable/1.7.x.
2014-06-06 00:32:13 +02:00
Aymeric Augustin
5c95a55330
Checked can_introspect_null feature in a test.
...
Forward-port of 1238f92c
from stable/1.7.x.
2014-06-06 00:31:51 +02:00
Greg Chapple
72f055e535
Fixed #20550 -- Added keepdb argument to destroy_test_db
2014-06-05 23:17:27 +01:00
Susan Tan
484f3edf1e
Fixed #18400 -- Modified length template filter to return 0 for unknown variables.
...
Thanks Florian for the bug report, luyikei for the initial code patch, and
Bouke for the code review feedback.
2014-06-05 15:41:56 -04:00
Anubhav Joshi
5643a3b51b
Fixed #10811 -- Made assigning unsaved objects to FK, O2O, and GFK raise ValueError.
...
This prevents silent data loss.
Thanks Aymeric Augustin for the initial patch and Loic Bistuer for the review.
2014-06-05 13:12:01 -04:00
Aymeric Augustin
a03d38ddd4
Added a flag for the ability to introspect nullable fields.
...
Previously this was conflated with another Oracle-specific behavior.
2014-06-05 17:56:56 +02:00
Aymeric Augustin
237c229b91
Avoided using BinaryField unecessarily in tests.
...
Several database backends struggle with binary data. This change
minimizes the risk of unrelated tests failures when binary fields
trigger errors.
Forward-port of 2e4bcb9b
from stable/1.7.x.
2014-06-05 17:11:10 +02:00
Aymeric Augustin
ae3fe6ccbb
Reordered setUp code in prefetch_related tests.
...
This allows these tests to run on databases that reject duplicate NULL
values in unique fields e.g. SQL Server.
Forward port of 4fb50a9a
from stable/1.7.x.
2014-06-05 16:33:02 +02:00
Anubhav Joshi
45e049937d
Fixed #13776 -- Fixed ModelForm.is_valid() exception with non-nullable FK and blank=True.
...
Thanks peterbe for the report.
2014-06-04 07:57:19 -04:00
gyx1000
7e2c87809c
Fixed #22684 -- Amended SelectDateWidget.empty_label to accept a tuple of values.
...
Thanks danielsamuels for the report
2014-06-04 07:23:25 -04:00
Claude Paroz
fb9d8f0652
Fixed #22717 -- Auto-corrected missing ending slash in FileSystemStorage
...
Thanks David Fischer for the report and Moayad Mardini for the
review.
2014-06-04 08:53:17 +02:00
Alexandr Shurigin
083d285b82
Fixed #22681 -- Made TarArchive recognize leading directories properly.
2014-06-03 12:00:33 -04:00
Tim Graham
4445d36d47
Fixed #22384 -- Deprecated reversing URLs by dotted path.
2014-06-03 07:30:14 -04:00
Nick Presta
11f0899bbe
Fixed #11776 -- Added CSS class for non-field/top of form errors.
...
Thanks Daniel Pope for the suggestion.
2014-06-02 15:22:15 -04:00
Craig de Stigter
ce993efda8
Fixed #22690 -- Added a check for proxy models containing fields.
...
Removed the FieldError raised by ModelBase.__new__ in this case.
2014-06-02 09:32:38 -04:00
Tim Graham
5046c110cf
Revert "Fixed #19303 -- Fixed ModelAdmin.formfield_overrides on fields with choices"
...
This reverts commit 9d1987d767
.
2014-06-02 07:05:38 -04:00
Vincent-Vega
d04e730224
Fixed #22711 -- Adjusted ordering checks to allow implicit relation fields.
...
refs #19195 .
2014-06-01 15:36:25 -04:00
Simon Charette
7a38f88922
Fixed #22659 -- Prevent model states from sharing field instances.
...
Thanks to Trac alias tbartelmess for the report and the test project.
2014-06-01 15:10:38 -04:00
José L. Patiño
7b064e5390
Split GenericRelationsTests.test_generic_relations into several tests; refs #18586 .
2014-06-01 12:36:32 -04:00
Aymeric Augustin
2a5c750ad1
Merge pull request #2726 from gchp/ticket-20550
...
Fixed #20550 -- Added ability to preserve test db between runs
2014-06-01 17:26:56 +02:00
Florian Apolloner
83e7555ffe
Revert "Making SQL management commands migration aware."
...
This reverts commit cb9c9a7b58
.
2014-06-01 12:00:09 +02:00
Alex Gaynor
a31d7c48b0
Removed an unused import
2014-05-31 10:50:29 -07:00
Moayad Mardini
6f4d7f41b1
Improved the test for refs #22682 .
...
Thanks apollo13 for the review.
2014-05-30 11:00:13 -04:00
Andrew Godwin
9cbf7f25ef
Fix additional test failures caused by migration pollution
2014-05-29 16:44:12 -07:00
Andrew Godwin
347cab4fae
Merge pull request #2744 from mmardini/MIGRATION_MODULES
...
Fixed #22682 -- `makemigrations` will create `MIGRATION_MODULES` package
2014-05-29 15:38:21 -07:00
Moayad Mardini
56cfa508c7
Fixed #22682 -- `makemigrations` will create `MIGRATION_MODULES` package
...
`makemigrations` will automatically create the package specified
in `MIGRATION_MODULES` if it doesn't already exist.
Thanks ovidiuc4 for the report.
2014-05-30 01:23:09 +03:00
Víðir Valberg Guðmundsson
cb9c9a7b58
Making SQL management commands migration aware.
2014-05-29 23:03:10 +02:00
Antonis Christofides
62f9508ade
Fixed #20401 -- ContentTypeManager.get_for_model reads from db_for_read.
...
Thanks Simon Charette and Tim Graham for the reviews.
2014-05-29 23:01:55 +07:00
Chris Beaven
45fa520187
Implement Migration.run_before
...
This attribute (used for reverse dependencies) was previously declared
and mentioned in the code, but never actually used.
2014-05-29 22:42:11 +12:00
Alex Gaynor
d240b29c08
Fixed a typo that Tim Graham noticed
2014-05-28 17:46:06 -07:00
Alex Gaynor
1dcc603eff
Fixed several typos in Django
2014-05-28 17:39:14 -07:00
Andrew Godwin
61185bba72
Merge pull request #2734 from valberg/double_order_trouble
...
Fixed #22720 -- Migrations attempt to create _order twice.
2014-05-28 17:12:01 -07:00
Víðir Valberg Guðmundsson
bf9953cfb8
Adding test to fix of duplicate _order fields ( #22720 )
2014-05-29 01:38:59 +02:00
Shai Berger
69337d485c
Set straight the sense of 'uppercases_column_names' feature flag
2014-05-28 21:16:24 +03:00
Guillaume Pannatier
32586b0ba4
Fixed #22684 -- Added `empty_label` option on `django.forms.extras.widets.SelectDateWidget`
...
Thanks danielsamuels for the report
2014-05-28 13:23:28 -04:00
Greg Chapple
b7aa7c4ab4
Fixed #20550 -- Added ability to preserve test db between runs
2014-05-28 16:22:46 +01:00
Aymeric Augustin
4865326f22
Fixed #22699 -- Configure default settings in some management commands.
...
This makes it possible to run django.setup() in management commands that
don't need a settings module. In addition it simplifies error handling.
Thanks Claude for the review.
2014-05-27 21:43:52 +02:00
Moayad Mardini
2e613ea5c5
Fixed #22675 -- makemigrations --dry-run to output migrations to stdout.
...
`makemigrations --dry-run` will output the complete migrations file
that would be written if it's used along with `--verbosity 3`.
2014-05-27 00:40:55 +03:00
Florian Apolloner
ee51ab9d23
Restored Python 2 compatibility.
2014-05-26 00:07:15 +02:00
Florian Apolloner
9d1bf8f841
Removed executeable bit from a few files.
2014-05-25 23:16:40 +02:00
Florian Apolloner
536ebaa048
Fixed a few warnings in the testsuite.
2014-05-25 23:14:50 +02:00
Loic Bistuer
417ec4a68b
Fixed a ResourceWarning that wasn't properly fixed by the previous commit.
...
Also removed unused import in runtests.py.
2014-05-26 04:01:41 +07:00
Loic Bistuer
b7de5f5d3f
Fixed a few ResourceWarning in the test suite. Refs #22680 .
2014-05-26 03:23:17 +07:00
Moayad Mardini
63fc91b3ca
Fixed #22676 -- makemigrations --dry-run should not ask for defaults
...
Made the fix in InteractiveMigrationQuestioner class code, rather than
MigrationAutodetector, because --dry-run shouldn't affect whether
MigrationAutodetector will detect non-nullable fields, but the
questioner should skip the question and returns a None for default
(since that won't be used anyway) if --dry-run is used.
2014-05-24 09:56:18 -04:00
Marc Tamlyn
9fb0f5dddc
Fixed #22510 -- Harden field removal to only None.
...
Refs #8620 .
If we allow any value to remove form fields then we get name clashes
with method names, media classes etc. There was a backwards
incompatibility introduced meaning ModelForm subclasses with declared
fields called media or clean would lose those fields.
Field removal is now only permitted by using the sentinel value None.
The docs have been slightly reworded to refer to removal of fields
rather than shadowing.
Thanks to gcbirzan for the report and initial patch, and several of the
core team for opinions.
2014-05-24 13:10:50 +01:00
Claude Paroz
f47e226ff7
Moved some imports in runtests.py
2014-05-24 13:29:23 +02:00
Claude Paroz
19b4908206
Made runtests.py use 'set_installed_apps' API
...
This will also trigger the ready method of any tested application,
which was not run before.
2014-05-24 11:02:58 +02:00
Baptiste Mispelon
f01d2a8f9b
Fixed tuple serialization test.
...
Thanks to rockallite for the report.
2014-05-23 14:50:10 +02:00
Huu Nguyen
f851a954ac
Fixed #22602 -- Improved code coverage of makemigrations command tests.
2014-05-23 08:05:46 -04:00
Preston Timmons
be88b062af
Fixed #21357 -- Fixed test client session initialization.
...
The test client will now create a session when it is first accessed
if no session already exists.
2014-05-22 20:29:48 -04:00
Unai Zalakain
4dc4d12e27
Fixed #21598 -- cleaned up template loader overrides in tests
...
- Template loader overriding is managed with contexts.
- The test loader is a class (function based loaders entered deprecation timeline
in 1.4).
- Template loader overrider that overrides with test loader added.
2014-05-22 18:35:16 -04:00
Flavio Curella
beec05686c
Fixed #22667 -- Replaced leader/follower terminology with primary/replica
2014-05-22 11:59:17 -04:00
Moayad Mardini
ad994a3c5b
Fixed #22679 -- Fixed empty tuple serialization in MigrationWriter.
...
Thanks rockallite.wulf for the report.
2014-05-22 16:15:09 +02:00
Marc Tamlyn
635acf42c5
Fix a test dependent on json ordering.
2014-05-22 15:05:19 +01:00
Marc Tamlyn
6ab67919ac
Made nested deconstruction support both forms of deconstruct()
...
Nested deconstruction should (silently) handle Field.deconstruct() as
well as other arbitrary deconstructable objects. This allows having a
field in the deconstruction of another field.
2014-05-22 13:23:51 +01:00
Marc Tamlyn
604162604b
Added array field support for PostgreSQL.
...
The first part of django.contrib.postgres, including model and two form
fields for arrays of other data types.
This commit is formed of the following work:
Add shell of postgres app and test handling.
First draft of array fields.
Use recursive deconstruction.
Stop creating classes at lookup time.
Add validation and size parameter.
Add contained_by lookup.
Add SimpleArrayField for forms.
Add SplitArrayField (mainly for admin).
Fix prepare_value for SimpleArrayField.
Stop using MultiValueField and MultiWidget.
They don't play nice with flexible sizes.
Add basics of admin integration.
Missing:
- Tests
- Fully working js
Add reference document for django.contrib.postgres.fields.ArrayField.
Various performance and style tweaks.
Fix internal docs link, formalise code snippets.
Remove the admin code for now.
It needs a better way of handing JS widgets in the admin as a whole
before it is easy to write. In particular there are serious issues
involving DateTimePicker when used in an array.
Add a test for nested array fields with different delimiters.
This will be a documented pattern so having a test for it is useful.
Add docs for SimpleArrayField.
Add docs for SplitArrayField.
Remove admin related code for now.
definition -> description
Fix typo.
Py3 errors.
Avoid using regexes where they're not needed.
Allow passing tuples by the programmer.
Add some more tests for multidimensional arrays.
Also fix slicing as much as it can be fixed.
Simplify SplitArrayWidget's data loading.
If we aren't including the variable size one, we don't need to search
like this.
2014-05-22 09:53:26 +01:00
Ramiro Morales
fce6a29428
Merge pull request #2498 from ramiro/move-serverhandler
...
Moved ServerHandler helper class to tests.
2014-05-21 18:59:01 -03:00
Ramiro Morales
d731f48ece
Merge pull request #2679 from ramiro/t22421
...
Fixed #22421 -- Regression in fixtures loading.
2014-05-21 18:57:46 -03:00
Martin Brochhaus
bb0a9a070b
Fixed #20477 : Allowed list of modules for FORMAT_MODULE_PATH
...
Previously the FORMAT_MODULE_PATH setting only accepted one string (dotted
module path). A feature has been added to also allow a list of strings.
This is useful when using several reusable third party apps that define new
formats. We can now use them all and we can even override some of the formats
by providing a project-wide format module.
2014-05-21 07:35:47 -04:00
Tim Graham
dfeef8e147
Skipped a migrations test that's not supported on MySQL + Python 3.
2014-05-21 06:54:24 -04:00
Loic Bistuer
870b0a1f86
Fixed the ordering of prefetch lookups so that latter lookups can refer to former lookups.
...
Thanks Anssi Kääriäinen and Tim Graham for the reviews. Refs #17001 and #22650 .
2014-05-21 10:30:48 +07:00
Loic Bistuer
bdf3473e64
Fixed #22650 -- Fixed regression on prefetch_related.
...
Regression from f51c1f59
when using select_related then prefetch_related
on the reverse side of an O2O:
Author.objects.select_related('bio').prefetch_related('bio__books')
Thanks Aymeric Augustin for the report and tests. Refs #17001 .
2014-05-21 10:26:04 +07:00
Alex Gaynor
8a95b4fca7
Merge pull request #2692 from fcurella/patch-5
...
#22667 replaced occurrences of master/slave terminology with leader/follower
2014-05-20 09:37:04 -07:00
Flavio Curella
73a57b06f9
replaced occurrences of master/slave terminology with leader/follower
2014-05-20 11:35:16 -05:00
Denis Cornehl
3bec38888f
Fixed #22557 -- ManifestStaticFilesStorage did not cleanup deleted files.
...
When using ManifestStaticFilesStorage, deleted static files would be
correctly cleaned up by "collectstatic --clear", but the manifest file
would still contain the stale entries.
Thanks to tedtieken for the report
2014-05-20 18:14:49 +02:00
Andrew Godwin
03900a02d5
Fixed #22432 : SQLite M2M repointing now works. Thanks to xelnor.
2014-05-20 16:25:59 +01:00
Andrew Godwin
4e32e47348
Merge pull request #2634 from loic/ticket22424
...
Fixed #22424 -- MySQL doesn't accept migrations' one-off default values ...
2014-05-20 14:25:59 +01:00
Huu Nguyen
44304cf04e
Fixed #22661 -- Move makemigrations tests to the proper class
2014-05-19 20:16:36 -07:00
Marc Tamlyn
3b765029f0
Fix a2dd618
for mysql.
2014-05-19 14:59:02 +01:00
Tim Graham
5abc811a40
Revert "Fixed #20477 : Allowed settings.FORMAT_MODULE_PATH to be a list of modules."
...
This reverts commit 950b6de16a
.
2014-05-19 08:22:46 -04:00
Martin Brochhaus
950b6de16a
Fixed #20477 : Allowed settings.FORMAT_MODULE_PATH to be a list of modules.
...
Previously the FORMAT_MODULE_PATH setting only accepted one string (dotted
module path).
This is useful when using several reusable third party apps that define new
formats. We can now use them all and we can even override some of the formats
by providing a project-wide format module.
2014-05-19 07:59:13 -04:00
Esau Rodriguez
ec9043ab2f
Fixed #21799 - Modified loaddata --ignorenonexistent to ignore models.
2014-05-18 15:52:07 -04:00
Huu Nguyen
949ee521fa
Refs #21230 -- removed direct settings manipulation from staticfile tests
2014-05-18 14:27:35 -04:00
Loic Bistuer
5789ff7330
Failing testcases for #22649 .
2014-05-18 12:46:12 +07:00
Loic Bistuer
1d3d01b4f7
Fixed #22424 -- Fixed handling of default values for TextField/BinaryField on MySQL.
...
Thanks syphar for the review and suggestions.
2014-05-18 11:58:16 +07:00
Ramiro Morales
862e1ff234
Fixed #22421 -- Regression in fixtures loading.
...
Loading fixtures were failing since the refactoring in 244e2b71f5
for
inheritance setups where the chain contains abstract models and the
root ancestor contains a M2M relation.
Thanks Stanislas Guerra for the report.
Refs #20946 .
2014-05-17 17:36:45 -03:00
Markus Amalthea Magnuson
f7845449b4
Moved wordwrap test to their own function
...
The `wordwrap` tests were in the `test_wordcount()` method for some
reason. This moves them to their own method, and make consistent use of
double quotes where needed.
2014-05-17 20:42:58 +02:00
Alex Gaynor
b6b873d2ad
Fixed several flake8 errors, including one where a test wouldn't be run
2014-05-17 09:54:34 -07:00
Marc Tamlyn
a2dd618e3b
Fixed #22648 -- Transform.output_type should respect overridden custom_lookup and custom_transform.
...
Previously, class lookups from the output_type would be used, but any
changes to custom_lookup or custom_transform would be ignored.
2014-05-17 12:26:15 +02:00
Florian Apolloner
11932e978f
Merge pull request #2346 from Markush2010/ticket21905
...
Fixed #21905 -- Add info message if DateField or TimeField use a fixed value
2014-05-17 12:09:04 +02:00
Unai Zalakain
ebb0279f4a
Fixed #16245 -- Included traceback in send_robust()'s response
...
Exceptions from the (receiver, exception) tuples returned by
``send_robust()`` now have always their traceback attached as their
``__traceback__`` argument.
2014-05-16 18:41:40 -04:00
Aymeric Augustin
1109ebd7b3
Optimized make_aware/naive by removing redundant checks. Refs #22625 .
...
Also added tests with pytz and removed misplaced tests.
2014-05-16 23:12:59 +02:00
Aymeric Augustin
fa89acf1d0
Fixed #22625 -- Normalized make_aware/naive errors.
...
Also added tests for is/make_aware/naive.
Thanks Tom Michaelis for the report.
2014-05-16 22:52:10 +02:00
Shai Berger
6bb6df2943
Fix storing of binary fields and unicode textfields for Oracle/Python3
2014-05-16 20:08:52 +03:00
Markus Holtermann
9d8c73f6a1
Fixed #21905 -- Add info message if DateField or TimeField use a fixed value
2014-05-16 18:59:31 +02:00
Stas Rudakou
ebd70d4d00
Fixed #22266 - quote PK before redirecting away from add_view (django.contrib.admin)
2014-05-16 18:33:17 +02:00
Vlad Starostin
1be03aff5c
Fixed #18389 -- Fixed the way contribute_to_class is called
...
Now this method is only called only if the object is an instance.
This allows to have field classes as model class attributes.
2014-05-16 10:40:07 -04:00
Russell Keith-Magee
2c176eb95c
Refs #21798 - Modified error number to provide room for future expansion.
2014-05-16 15:41:17 +02:00
Moayad Mardini
393ddc10a7
Fixed #22531 -- Added tree.Node.__repr__ and tests for the class.
...
While Node class has a useful `__str__`, its `__repr__` is not that
useful. Added a `__repr__` that makes use of the current `__str__`.
This is especially useful since the more popular `Q` class inherits
`tree.Node`. Also created new tests that cover most of `Node` class
functionality.
2014-05-16 09:30:25 -04:00
Alex Gaynor
fadc6cd1bd
Removed an unused import
2014-05-16 09:24:41 -04:00
Nikolaus Schlemm
1ab278f39d
Fixed #22490 -- removed obsolete ComplexFeed class from syndication_tests
...
It was previously used in a test that was deprecated and then removed, this cruft can be removed now.
2014-05-16 09:22:36 -04:00
Erik Romijn
424fe76349
Fixed #22579 -- Corrected validation for email to reject trailing slash
...
Thanks to Claude Paroz for the report and patch and Tomasz
Paczkowski for the review.
2014-05-16 15:13:11 +02:00
Stephen Burrows
d64f192df1
Fixed #22628 -- Took initial forms into account when combining FormSet.min_num and FormSet.extra.
...
Forwardport of 79f15ab1ef
from stable/1.7.x
2014-05-16 06:38:24 -04:00
Marc Tamlyn
4a98130735
Merge pull request #2657 from nschlemm/20140516-test_testcase_ordering
...
cater for running tests from another directory than tests
2014-05-16 12:30:39 +02:00
Nikolaus Schlemm
d11e836203
cater for running tests from another directory than tests - applying existing pattern to newly added test_testcase_ordering as well
2014-05-16 12:11:35 +02:00
Claude Paroz
f5d4b45df1
Fixed #21634 -- Prevented hiding ImproperlyConfigured when command not found
...
Thanks nikolay.v.golub@gmail.com for the report.
2014-05-16 12:08:31 +02:00
Daniel Pyrathon
cb15231888
Fixed #21798 -- Added check for DateTime mutually exclusive options
...
Added DateTimeCheckMixin to avoid the use of default, auto_now, and
auto_now_add options together. Added the fields.E151 Error that is raised
if one or more of these options are used together.
2014-05-16 05:57:19 -04:00
Claude Paroz
e520a73eee
Harmonized some PEP 0263 coding preambles
2014-05-15 19:58:41 +02:00
Anders Steinlein
4ef10f245a
Fixed #17642 -- Added min_num support to modelformsets, inlines, and the admin.
...
Thanks Stephen Burrows for work on the patch as well.
Forwardport of 2914f66983
from stable/1.7.x
2014-05-15 07:25:35 -04:00
Erik Romijn
255449c1ee
Added additional checks in is_safe_url to account for flexible parsing.
...
This is a security fix. Disclosure following shortly.
2014-05-14 10:19:48 +02:00
Aymeric Augustin
3800f63721
Dropped fix_IE_for_vary/attach.
...
This is a security fix. Disclosure following shortly.
2014-05-14 10:19:48 +02:00
Julen Ruiz Aizpuru
5eb81ce445
Fixed #22533 -- Added label_suffix parameter to form fields.
...
Fields can now receive the `label_suffix` attribute, which will override
a form's `label_suffix`.
This enhances the possibility to customize form's `label_suffix`, allowing
to use such customizations while using shortcuts such as
`{{ form.as_p }}`.
Note that the field's own customization can be overridden at runtime by
using the `label_prefix` parameter to `BoundField.label_tag()`.
Refs #18134 .
2014-05-13 09:09:33 -04:00
Tim Graham
5971630de9
Fixed flake8 error.
2014-05-12 07:09:53 -04:00
Ramiro Morales
a9b7f31bfc
Completed long overdue sqlinitialdata deprecation.
2014-05-11 23:15:59 -03:00
Ramiro Morales
c1b412ebd6
Fixed some test models' natural_key() methods.
2014-05-11 23:09:12 -03:00
Ramiro Morales
9762ba2630
Unneeded, Python 3 incompatible code in a75324c6
tests.
2014-05-11 20:39:00 -03:00
Rainer Koirikivi
a75324c654
Fixed #14226 -- Dependency calculation for complex M2M relations.
...
`sort_dependencies` incorrectly interpreted 'complex' M2M relations
(with explicit through models) as dependencies for a model. This caused
circular complex M2M relations to be unserializable by dumpdata.
Thanks to aneil for the report and outofculture for initial tests.
2014-05-11 19:50:01 -03:00
Claude Paroz
4cf82e5bcf
Fixed #21685 -- Displayed app verbose name in admindocs model index
2014-05-10 18:09:07 +02:00
Aymeric Augustin
edecbb551b
Minor cleanup in select_related_regress tests.
2014-05-10 16:41:54 +02:00
Aymeric Augustin
f574220f09
Fixed #22508 -- Avoided overwriting select_related.
...
Previously, known related objects overwrote related objects loaded
though select_related. This could cancel the effect of select_related
when it was used over more than one level.
Thanks boxm for the bug report and timo for bisecting the regression.
2014-05-10 16:39:20 +02:00
Aymeric Augustin
fb90b7cda2
Adjusted refactoring of vendor checks.
...
Thanks Shai for the thorough review.
2014-05-10 14:40:42 +02:00
Stephen Burrows
a5de0df58b
Fixed #22502 -- Fixed microseconds/default/form interaction
...
Made explicit lack of microsecond handling by built-in datetime form
fields. Used that explicitness to appropriately nix microsecond
values in bound fields. Thanks Claude Paroz for the review.
2014-05-10 10:56:39 +02:00
Claude Paroz
35e1b1efab
Used more precise assertions in cache tests
2014-05-09 19:34:53 +02:00
Malcolm Box
66880e4cd1
Fixed #22606 -- Locmemcache has_key() failed for infinite cache expiry
...
Refactored cache expiry logic for Locmemcache to make consistent across
all places where accessed, and correctly handle None as expiry time.
2014-05-09 18:35:07 +02:00
Andrew Godwin
fdbd29dd27
Tests for #22325
2014-05-08 21:48:10 -07:00
David Szotten
7fe60ae64a
Fixed #22588 -- Fix RegexValidator __eq__
...
Compare parameters instead of re.pattern instances, and add the other
parameters to the comparison. Also add a __ne__ to make assertNotEqual
work properly.
2014-05-08 19:51:15 -07:00
Aymeric Augustin
99d9fa329a
Added feature flags for introspection capabilities.
2014-05-08 22:11:20 +02:00
Aymeric Augustin
cff59bedc2
Split ignores_nulls_in_unique_constraints feature.
...
Oracle and SQL Server don't have exactly the same limitations. It's
worth treating them differently.
2014-05-08 22:11:20 +02:00
Aymeric Augustin
c70a61eb49
Replaced vendor checks by three feature flags.
2014-05-08 22:11:15 +02:00
Aymeric Augustin
43a80f4812
Simplified indexes tests.
2014-05-08 21:50:21 +02:00
Aymeric Augustin
d667263169
Reorganized backends tests.
...
This reduces the number of explicit vendor checks.
2014-05-08 21:50:21 +02:00
Aymeric Augustin
b1432bfc22
Appeased flake8.
2014-05-08 21:49:54 +02:00
Andrew Godwin
b25aee3b7b
Fixed #22476 : Couldn't alter attributes on M2Ms with through= set
2014-05-08 10:34:24 -07:00
Andrew Godwin
5a917cfef3
Fixed #22496 : Data migrations get transactions again!
2014-05-07 14:28:34 -07:00
Andrew Godwin
e9a456d11b
Fixed #22581 : Pass default values for schema through get_db_prep_save()
2014-05-07 13:46:23 -07:00
Andrew Godwin
6944418277
Fixed #22337 : FileSystemStorage marked as deconstructible and tested.
2014-05-06 22:23:23 -07:00
Claude Paroz
da9cf53cb5
Fixed #22564 -- Prevented unneeded bytestrings in migrations
...
In some cases, this could lead to migrations written with Python 2
being incompatible with Python 3.
Thanks Tim Graham for the report and Loïc Bistuer for the advices.
2014-05-06 09:13:07 +02:00
Ben Davis
df60db0e78
Fixed #22570 -- Made Form.__getitem__ KeyError more descriptive.
2014-05-05 20:01:15 -04:00
Loic Bistuer
942556df2f
Fixed #22572 -- override_settings(ROOT_URLCONF) didn't clear urlresolvers._urlconfs.
...
Thanks Anubhav Joshi and Tim Graham for the reviews.
2014-05-05 19:29:27 +07:00
Anssi Kääriäinen
3b7c66a3ac
Fixed #22466 -- ordering by reverse foreign key
...
Ordering by reverse foreign key was broken by custom lookups patch
(commit 20bab2cf9d
).
Thanks to everybody who helped solving this issue. Special thanks to
Trac alias takis for reporting this.
2014-05-05 15:28:07 +03:00
Jakub Roztocil
7131e14d00
Fixed #22489 -- missing implemenation for search lookup
...
When custom lookups were added, converting the search lookup to use
the new Lookup infrastructure wasn't done.
Some changes were needed to the added test, main change done by
committer was ensuring the test works on MySQL versions prior to 5.6.
2014-05-05 14:36:15 +03:00
Anssi Kääriäinen
5e1f4656b9
Fixed #22429 -- Incorrect SQL when using ~Q and F
2014-05-05 13:02:11 +03:00
Tim Graham
3818d96426
Fixed #22435 -- Prevented adding a ManyToManyField from prompting for a default.
...
Thanks andrewsg for the report.
2014-05-02 20:46:47 -04:00
Claude Paroz
142c27218a
Fixed #22565 -- Prevented pgettext_lazy crash with bytestring input
...
Thanks ygbo for the report.
2014-05-02 19:33:22 +02:00
Loic Bistuer
d1799233f4
Fixed clash caused by the newly introduced -e shorthand for makemessages --exclude.
...
This fixes a regression caused by 0707b82
. Refs #22328 .
2014-05-02 23:07:17 +07:00
Chris Beaven
a0c4b8465d
Fix migration autodector to work correctly with custom deconstructed values
2014-05-02 15:08:19 +12:00
Yehonatan Daniv
e2e4cdba11
Fixed #22539 -- Copied exclude argument in Model.full_clean() to prevent side effects.
2014-05-01 09:28:11 -04:00
Tim Graham
45c2d1f5d9
flake8 fixes.
2014-04-30 18:33:46 -04:00
Andrew Godwin
e049c88603
Cleanup failing test w/contenttypes and remove useless graph load
2014-04-30 15:11:52 -07:00
Andrew Godwin
8f6dff372b
Fixed #22485 : Include all unmigrated apps in project state by default.
2014-04-30 12:25:12 -07:00
Simon Charette
24ec9538b7
Fixed #19195 -- Allow explicit ordering by a relation `_id` field.
...
Thanks to chrisedgemon for the report and shaib, akaariai and
timgraham for the review.
2014-04-30 14:23:19 -04:00
Doug Beck
a5f6cbce07
Refactored DjangoTranslation class
...
Also fixes #18192 and #21055 .
2014-04-30 18:36:25 +02:00
Claude Paroz
7c54f8cced
Fixed #22474 -- Made migration recorder aware of multiple databases
...
Thanks Tim Graham for the review.
2014-04-30 16:53:20 +02:00
Mike Fogel
7fd1b35ed7
Fixed #22537 -- Add tests and improved docs for field subclass with choices.
2014-04-30 07:56:52 -04:00
Simon Charette
390f888745
Fixed #22447 -- Make sure custom model bases can be migrated.
...
Thanks to cdestigter for the report.
2014-04-29 09:43:08 -04:00
Tim Graham
aabceadd7d
Revert "Fixed #15179 -- middlewares not applied for test client login()"
...
This reverts commit 4fdd51b732
.
See the ticket for concerns with this implementation; it will be revisited.
2014-04-28 18:41:36 -04:00
Alex Gaynor
2bcb8bfc8d
Fix many many typos in comments throughout the codebase
2014-04-26 10:18:45 -07:00
Aymeric Augustin
8b5b199e20
Fixed #3214 -- Stopped parsing SQL with regex.
...
Avoided introducing a new regex-based SQL splitter in the migrations
framework, before we're bound by backwards compatibility.
Adapted this change to the legacy "initial SQL data" feature, even
though it's already deprecated, in order to facilitate the transition
to migrations.
sqlparse becomes mandatory for RunSQL on some databases (all but
PostgreSQL). There's no API to provide a single statement and tell
Django not to attempt splitting. Since we have a more robust splitting
implementation, that seems like a good tradeoff. It's easier to add a
new keyword argument later if necessary than to remove one.
Many people contributed to both tickets, thank you all, and especially
Claude for the review.
Refs #22401 .
2014-04-26 17:46:23 +02:00
Ana Krivokapic
0707b824fe
Fixed #22328 -- Added --exclude option to compilemessages and makemessages.
2014-04-26 17:07:44 +07:00
Tim Graham
d238c58912
Fixed #22499 -- Fixed a typo in an admin_views test that caused failure on Oracle.
2014-04-24 07:06:02 -04:00
Kevin Christopher Henry
91afc00513
Fixed #21157 -- Fixed problems with ResolverMatch
...
- Fixed bug in get_callable() that caused resolve() to put a string
in ResolverMatch.func.
- Made ResolverMatch.url_name match the actual url name (or None).
- Updated tests that used the string value in ResolverMatch.func, and
added regression tests for this bug.
- Corrected test urls whose dummy view paths caused failures (behavior
that was previously masked by this bug).
2014-04-23 20:12:34 -04:00
Malcolm Box
af5f688392
Fixed #22495 -- Locmem cache.add() failed with infinite timeouts
...
cache.add() incorrectly succeeded when there was an existing key
with an infinite (None) timeout.
2014-04-23 14:49:46 +02:00
Preston Timmons
3c06b2f2a3
Fixed #22486 -- Restored the ability to reverse views created using functools.partial.
...
Regression in 8b93b31487
.
Thanks rcoup for the report.
2014-04-23 07:27:52 -04:00
Erik Romijn
75c0d4ea3a
Fixed queries that may return unexpected results on MySQL due to typecasting.
...
This is a security fix; disclosure to follow shortly.
2014-04-21 18:11:26 -04:00
Aymeric Augustin
c083e3815a
Prevented leaking the CSRF token through caching.
...
This is a security fix. Disclosure will follow shortly.
2014-04-21 18:11:26 -04:00
Tim Graham
8b93b31487
Fixed a remote code execution vulnerabilty in URL reversing.
...
Thanks Benjamin Bach for the report and initial patch.
This is a security fix; disclosure to follow shortly.
2014-04-21 18:11:26 -04:00
Claude Paroz
ab90c4707b
Fixed table cleanup in GIS migration tests
2014-04-21 23:08:00 +02:00
Aymeric Augustin
c54e7ec9ca
Merge pull request #2592 from prestontimmons/remove-test-runner-cases
...
Removed old test runner test cases.
2014-04-21 18:06:19 +02:00