Carlton Gibson
77706a3e47
[2.2.x] Fixed CVE-2019-12781 -- Made HttpRequest always trust SECURE_PROXY_SSL_HEADER if set.
...
An HTTP request would not be redirected to HTTPS when the
SECURE_PROXY_SSL_HEADER and SECURE_SSL_REDIRECT settings were used if
the proxy connected to Django via HTTPS.
HttpRequest.scheme will now always trust the SECURE_PROXY_SSL_HEADER if
set, rather than falling back to the request scheme when the
SECURE_PROXY_SSL_HEADER did not have the secure value.
Thanks to Gavin Wahl for the report and initial patch suggestion, and
Shai Berger for review.
Backport of 54d0f5e62f
from master
2019-07-01 07:50:48 +02:00
Jon Dufresne
0cd465b63a
Fixed #29817 -- Deprecated settings.FILE_CHARSET.
2018-10-15 17:15:41 -04:00
Sławek Ehlert
c6238bf02b
Fixed #29467 -- Made override_settings handle errors in setting_changed signal receivers.
2018-07-30 15:59:37 -04:00
Tim Graham
5cc81cd9eb
Reverted "Fixed #29324 -- Made Settings raise ImproperlyConfigured if SECRET_KEY is accessed and not set."
...
This reverts commit b3cffde555
due to
a regression and performance concerns.
2018-05-26 21:06:58 -04:00
Morgan Aubert
704443acac
Fixed #29363 -- Added SimpleTestCase.assertWarnsMessage().
2018-05-09 11:40:28 -04:00
Jon Dufresne
b3cffde555
Fixed #29324 -- Made Settings raise ImproperlyConfigured if SECRET_KEY is accessed and not set.
2018-04-17 13:02:05 -04:00
Tim Graham
fff689ed98
Added a test for a settings error message.
2018-04-17 12:55:26 -04:00
Mads Jensen
a51c4de194
Used assertRaisesMessage() to test Django's error messages.
2017-07-29 19:07:23 -04:00
Anton Samarchyan
c91dcd36fc
Improved test coverage for django.conf.
2017-07-26 20:00:28 -04:00
Tim Graham
6b4f018b2b
Replaced type-specific assertions with assertEqual().
...
Python docs say, "it's usually not necessary to invoke these methods directly."
2017-03-17 07:51:48 -04:00
chillaranand
d6eaf7c018
Refs #23919 -- Replaced super(ClassName, self) with super().
2017-01-25 12:23:46 -05:00
Tim Graham
d170c63351
Refs #23919 -- Removed misc references to Python 2.
2017-01-21 20:02:00 -05:00
Adam Chainz
8669cf0e68
Fixed #27626 -- Moved MEDIA_URL/STATIC_URL validation to a system check.
2016-12-23 10:55:00 -05:00
Adam Chainz
8fb82a315a
Used @override_settings for SECURE_PROXY_SSL_HEADER tests.
2016-12-22 18:52:50 -05:00
za
321e94fa41
Refs #27392 -- Removed "Tests that", "Ensures that", etc. from test docstrings.
2016-11-10 21:30:21 -05:00
Tim Graham
c9ae09addf
Replaced use of TestCase.fail() with assertRaises().
...
Also removed try/except/fail antipattern that hides exceptions.
2016-06-28 11:21:26 -04:00
Jon Dufresne
4f336f6652
Fixed #26747 -- Used more specific assertions in the Django test suite.
2016-06-16 14:19:18 -04:00
Claude Paroz
669c29c8f4
Fixed #26427 -- Ensured deleted setting doesn't appear in dir(settings)
2016-04-23 16:01:16 +02:00
Tim Graham
92053acbb9
Fixed E128 flake8 warnings in tests/.
2016-04-08 10:12:33 -04:00
Hasan
3d0dcd7f5a
Refs #26022 -- Used context manager version of assertRaises in tests.
2016-01-29 12:32:18 -05:00
Tim Graham
849037af36
Refs #23957 -- Required session verification per deprecation timeline.
2015-09-23 19:31:10 -04:00
Tim Graham
04ee4059d7
Refs #24022 -- Removed the ssi tag per deprecation timeline.
2015-09-23 19:31:09 -04:00
Maxime Lorant
5153a3bfdc
Fixed #25331 -- Removed trailing blank lines in docstrings.
2015-08-31 17:37:21 -04:00
Keryn Knight
9c40f01a66
Refs #24121 -- Added repr() to LazySettings, Settings, and UserSettingsHolder.
2015-08-31 16:08:30 -04:00
Tim Graham
aaacaeb096
Renamed RemovedInDjangoXYWarnings for new roadmap.
...
Forwardport of ae1d663b79
from stable/1.8.x plus more.
2015-06-24 16:08:20 -04:00
Simon Charette
be67400b47
Refs #24652 -- Used SimpleTestCase where appropriate.
2015-05-20 13:46:13 -04:00
Tim Graham
3074c5b19e
Fixed typo in settings_tests
2015-05-09 18:23:57 -04:00
Tim Graham
0ed7d15563
Sorted imports with isort; refs #23860 .
2015-02-06 08:16:28 -05:00
darkryder
9ec8aa5e5d
Fixed #24149 -- Normalized tuple settings to lists.
2015-02-03 14:59:45 -05:00
Adam Taylor
039465a6a7
Fixed typos in code comments.
2015-01-20 12:18:03 -05:00
Aymeric Augustin
cf0fd65ed4
Deprecated TEMPLATE_LOADERS.
2014-12-28 17:02:30 +01:00
Tim Graham
b6ea059b4a
Fixed #23957 -- Started deprecation toward requiring session verification.
...
Thanks Carl Meyer for review.
2014-12-05 07:37:34 -05:00
Aymeric Augustin
87f187b960
Adjusted tests for previous commit.
...
The test was testing a use case that doesn't happen in real world
projects: developers don't assign settings at run time (and Django
explicitly doesn't support it).
2014-11-17 23:26:04 +01:00
Thomas Chaumeny
d89f56dc4d
Fixed #21281 -- Made override_settings act at class level when used as a TestCase decorator.
2014-11-03 14:14:39 -05:00
Berker Peksag
f7969b0920
Fixed #23620 -- Used more specific assertions in the Django test suite.
2014-11-03 11:56:37 -05:00
Aymeric Augustin
9562ffea97
Avoid the word "stupid".
...
There's always a better word.
2014-09-09 20:55:57 +02:00
Claude Paroz
885ff6845e
Revert "Fixed #23384 -- Allowed overriding part of a dictionary-type setting"
...
This reverts commit 66757fee7e
.
Discussions have led to think that this functionality does not
bring significant benefits to justify the added complexity.
Read also discussions on ticket #22734 .
2014-09-05 20:06:02 +02:00
Claude Paroz
66757fee7e
Fixed #23384 -- Allowed overriding part of a dictionary-type setting
...
This change is needed for upcoming changes where settings might be
grouped in a parent dictionary.
Thanks Tim Graham for the review.
2014-08-30 12:37:10 +02:00
Alex Gaynor
e163a3d17b
Removed an unused local variable, fixes a flake8 error
2014-06-11 00:22:30 -07:00
Tim Schaffer
a1c6cd6a16
Fixed #22780 -- Checked that LOCALE_PATHS is really a tuple
2014-06-10 23:04:24 +02:00
Claude Paroz
3417ba0309
Also allowed a non-overridden setting to be deleted
...
Refs #20032 , #18824 . Thanks ztorstri at gmail.com for the report.
2014-04-12 15:33:22 +02:00
Rodolfo Carvalho
0d91225892
Fixed many typos in comments and docstrings.
...
Thanks Piotr Kasprzyk for help with the patch.
2014-03-03 07:38:09 -05:00
Alex Gaynor
8482ab6633
Removed some stray newlines which caused flake8 issues
2014-01-20 22:58:05 -06:00
Carl Meyer
6070a5d6a6
Fixes #21833 -- Fix UserSettingsHolder.is_overridden() and add tests.
2014-01-20 20:25:33 -07:00
Aymeric Augustin
553500133c
Removed an obsolete unicity check.
...
It doesn't account for app configs.
Refs #21679 .
2013-12-31 17:29:04 +01:00
Aymeric Augustin
e32095616c
Imported override_settings from its new location.
2013-12-23 21:37:56 +01:00
Aymeric Augustin
5241763c81
Added modify_settings to alter settings containing lists of values.
2013-12-23 21:37:43 +01:00
Aymeric Augustin
3a30b9c575
Fixed a flaky test.
2013-12-22 20:22:56 +01:00
Aymeric Augustin
eabc3b6c8d
Set stacklevel for the override_settings warning.
...
Refs #19031 .
2013-12-20 11:09:06 +01:00
Jason Myers
c3791463a5
Fixing E302 Errors
...
Signed-off-by: Jason Myers <jason@jasonamyers.com>
2013-11-02 23:48:47 -05:00