ce823d3710
Merge pull request #1382 from loic/ticket19617
...
Fixed #19617 -- Refactored form metaclasses to support more inheritance scenarios.
2013-10-15 04:22:34 -07:00
018e2c055a
Fixed #21223 -- Added form.id_for_label to topic guide.
...
Thanks ebertti at yahoo.com.br for the suggestion.
2013-10-14 18:41:22 -04:00
b16dd1fe01
Fixed #8620 -- Updated the Form metaclass to support excluding fields by shadowing them.
2013-10-14 22:42:33 +07:00
ac5ec7b8bc
Fixed #19617 -- Refactored Form metaclasses to support more inheritance scenarios.
...
Thanks apollo13, funkybob and mjtamlyn for the reviews.
2013-10-14 21:59:30 +07:00
54cd930baf
Clarfied the ModelForm docs with respect to generated vs. declared fields.
...
The ModelForm docs suggested that fields defined declaratively override
default fields generated from the form Meta.
This is conceptually wrong, especially with inheritance in mind. Meta is
usually defined on the topmost ModelForm subclass, while fields can come
from anywhere in the MRO, especially base classes; therefore we suggested
that something defined in a base class override something from a subclass.
This patch rephrases the docs around the idea that Meta is used to generate
*missing* fields.
Refs #8620 , #19617 .
Thanks @mjtamlyn and @timgraham for the review.
2013-10-14 10:54:22 -04:00
df27803a55
Fixed #9532 -- Added min_num and validate_min on formsets.
...
Thanks gsf for the suggestion.
2013-09-19 13:11:49 -04:00
18ffdb1772
Fixed #17627 -- Renamed util.py files to utils.py
...
Thanks PaulM for the suggestion and Luke Granger-Brown and
Wiktor Kołodziej for the initial patch.
2013-09-16 12:52:05 -04:00
2fbf949760
Minor spelling correction in ModelForms docs
2013-08-28 16:05:46 +05:30
c33d1ca1d9
Fixed #20852 - Fixed incorrectly generated left quotes in docs.
...
Sphinx generates left single quotes for apostrophes after
code markup, when right single quotes are required. The
easiest way to fix this is just by inserting the unicode
character for a right single quote.
Instances of the problem were found by looking for
">‘" in the generated HTML.
2013-08-06 07:13:17 -04:00
65e03a424e
Fixed #10284 -- ModelFormSet.save(commit=False) no longer deletes objects
...
Thanks laureline.guerin@ and Wedg.
2013-07-23 16:21:23 -04:00
aa41eb9b8b
Fixed #20772 -- Fixed minor typo in form media docs.
2013-07-19 15:48:38 +07:00
fba6c2ede7
Reworked docs for ModelForm validation.
2013-07-16 19:20:53 -04:00
c0f03175ce
Fixed #19695 -- Retitle "Form Media" to "Form Assets".
2013-07-08 13:59:54 -04:00
660c30ed95
Fixed #16965 -- Clarified Formset can_delete docs.
...
Thanks gregcorey@ for the suggestion.
2013-07-08 12:08:30 -04:00
181f63c22d
Fixed #12346 -- Added a note on how to validate InlineFormSets.
...
Thanks johnsmith for the suggestion.
2013-07-08 08:29:28 -04:00
7442eb1a24
Fixed #20224 -- Update docs examples which mention __unicode__
...
Thanks Marc Tamlyn and Tim Graham for the review.
2013-07-05 19:27:07 +02:00
8160e6341d
Fix "semicolon" in docs
2013-07-02 17:52:54 +01:00
1b7634a0d0
Fixed #20464 -- Added a `total_error_count` method on formsets.
...
Thanks to frog32 for the report and to Tim Graham for the review.
2013-06-16 15:49:30 -04:00
9e50833e22
Fixed #20000 -- Allowed ModelForm meta overrides for label, help_text and error_messages
2013-06-13 15:06:25 -04:00
b79aa796d8
FormSet.forms is an iterable, so just iterate over it
2013-06-11 16:05:19 +01:00
9ff5f100dd
Fixed #20578 - Typo in BaseFormSet module name
2013-06-10 14:36:40 -04:00
584bd14dcf
Fixed #18134 -- BoundField.label_tag now includes the form's label_suffix
...
There was an inconsistency between how the label_tag for forms were
generated depending on which method was used: as_p, as_ul and as_table
contained code to append the label_suffix where as label_tag called on a
form field directly did NOT append the label_suffix. The code for
appending the label_suffix has been moved in to the label_tag code of
the field and the HTML generation code for as_p, as_ul and as_table now
calls this code as well.
This is a backwards incompatible change because users who have added the
label_suffix manually in their templates may now get double label_suffix
characters in their forms.
2013-06-10 14:23:15 -04:00
4bd6e5e895
Update media.txt
...
Fixed typo: froms -> forms
2013-06-09 08:23:48 +03:00
1fdc3d256d
Fixed #20523 - Incorrect form field for FilePathField.
...
Thanks sane4ka.sh@ for the report.
2013-05-28 11:54:53 -04:00
2fd61285d1
Fixed #20471 - Typos in topics/forms/formsets.txt
2013-05-20 13:56:19 -04:00
4280217f31
Fixed #20403 -- Ignore forms marked for deletion when validating max_num.
2013-05-20 12:13:21 -04:00
08b501e7d3
add missing imports to the examples in the 'Forms'
2013-05-19 13:31:45 +02:00
756b81dbd1
Fixed #13546 -- Easier handling of localize field options in ModelForm
2013-05-18 14:13:00 +02:00
f026a519ae
Fixed #19733 - deprecated ModelForms without 'fields' or 'exclude', and added '__all__' shortcut
...
This also updates all dependent functionality, including modelform_factory
and modelformset_factory, and the generic views `ModelFormMixin`,
`CreateView` and `UpdateView` which gain a new `fields` attribute.
2013-05-09 16:44:36 +01:00
b47b0211f5
Corrected "it's" to "its" when used possessively.
...
Fixed #20327 .
2013-04-29 17:21:37 +02:00
78c842a323
Adapted uses of versionchanged/versionadded to the new form.
...
Refs #20104 .
2013-04-20 17:18:35 +02:00
1de63cccb1
Fixed #20263 -- Corrected wording in the formset documentation.
...
Thanks to feraudyh at yahoo.com for the report.
2013-04-15 12:19:17 -04:00
4a1d425cfe
Fixed #8649 - Documented a caveat about dynamically adjusting formsets.
2013-03-31 04:34:28 -04:00
f9ab543720
Fixed #20084 -- Provided option to validate formset max_num on server.
...
This is provided as a new "validate_max" formset_factory option defaulting to
False, since the non-validating behavior of max_num is longstanding, and there
is certainly code relying on it. (In fact, even the Django admin relies on it
for the case where there are more existing inlines than the given max_num). It
may be that at some point we want to deprecate validate_max=False and
eventually remove the option, but this commit takes no steps in that direction.
This also fixes the DoS-prevention absolute_max enforcement so that it causes a
form validation error rather than an IndexError, and ensures that absolute_max
is always 1000 more than max_num, to prevent surprising changes in behavior
with max_num close to absolute_max.
Lastly, this commit fixes the previous inconsistency between a regular formset
and a model formset in the precedence of max_num and initial data. Previously
in a regular formset, if the provided initial data was longer than max_num, it
was truncated; in a model formset, all initial forms would be displayed
regardless of max_num. Now regular formsets are the same as model formsets; all
initial forms are displayed, even if more than max_num. (But if validate_max is
True, submitting these forms will result in a "too many forms" validation
error!) This combination of behaviors was chosen to keep the max_num validation
simple and consistent, and avoid silent data loss due to truncation of initial
data.
Thanks to Preston for discussion of the design choices.
2013-03-21 01:27:24 -07:00
7ec2a21be1
Fixed #19686 -- Added HTML5 number input type
...
Thanks Simon Charette for his help on the patch. Refs #16630 .
2013-02-23 10:18:08 +01:00
35c991aa06
Added a default limit to the maximum number of forms in a formset.
...
This is a security fix. Disclosure and advisory coming shortly.
2013-02-19 11:23:30 -07:00
976dc07baf
Removed a misleading examples from documentations ala ticket #19719
2013-02-16 14:30:55 -05:00
74003ca36b
Fixed #19808 Capitalization error in example text
2013-02-12 09:14:19 -05:00
fdaaa24171
Fixed #19700 - Added documentation for BoundField.field.
...
Thanks Tiberiu Ana for the report and patch.
2013-02-02 08:34:42 -05:00
4f16376274
Added HTML5 email input type
...
Refs #16630 .
2013-01-28 22:10:50 +01:00
93e79b45bc
Fixed #17416 -- Added widgets argument to inlineformset_factory and modelformset_factory
2013-01-24 08:58:17 +01:00
0de2645c00
Fixed #19610 - Added enctype note to forms topics doc.
...
Thanks will@ for the suggestion.
2013-01-23 04:49:48 -05:00
5b2d9bacd2
Fixed #19640 - Added inlineformset_factory to reference docs.
...
Thanks wim@ for the suggestion.
2013-01-22 07:55:34 -05:00
71d76ec011
Fixed #10239 - Added docs for modelform_factory
...
Thanks ingenieroariel for the suggestion and slurms for the review.
2013-01-11 06:00:19 -05:00
9b5f64cc6e
Fixed #19516 - Fixed remaining broken links.
...
Added -n to sphinx builds to catch issues going forward.
2013-01-02 18:32:57 -05:00
7ee7599ab3
Removed versionadded/changed annotations dating back to 1.4.
2012-12-29 21:59:08 +01:00
067505ad19
Fixed broken links, round 4. refs #19516
2012-12-29 15:54:33 -05:00
8248d14029
Removed US localflavor-specific tests from core
...
Also fixes #9045 .
2012-12-08 21:07:59 +01:00
d3fd8a1512
Fixed #15591 - Clarified interaction between ModelForm and model validation.
2012-11-05 18:24:28 -05:00
fd02bcff4a
Fixed #18548 - Clarified note regarding reusing model instances when form validation fails.
2012-10-16 20:39:13 -04:00
837425b425
Fixed #18934 - Removed versionadded/changed annotations for Django 1.3
2012-09-20 19:06:55 -04:00
a73838fde3
Fixed #11185 - Expanded docs on customizing widgets; thanks fadeev for the draft patch.
2012-09-15 06:22:00 -04:00
571698997f
fixing modelforms example code, ticket #18832
2012-09-08 12:30:41 -04:00
e57338f2b9
Fixed #18847 - Updated for media examples to use static.example.com. Thanks Jamie Curle.
2012-08-24 08:23:50 -04:00
3fd89d9903
Fixed #14885 - Clarified that ModelForm cleaning may not fully complete if the form is invalid.
...
Thanks Ben Sturmfels for the patch.
2012-08-21 17:32:53 -04:00
ebbc414d17
Fixed #16168 - Added note regarding type requirements when overridng ModelForm fields.
...
Thanks Pieter Swinkels for the patch.
2012-08-01 07:59:28 -04:00
7d06f975fe
Fixed #18614 -- Added missing imports in code samples.
2012-07-25 22:32:53 +02:00
19a810b18c
Fixed #14917 -- Hinted that view should redirect after form post success
2012-06-23 18:47:52 +02:00
c4c7fbcc0d
Fixed #18451 -- Vastly improved class based view documentation.
...
Many thanks to Daniel Greenfeld, James Aylett, Marc Tamlyn, Simon Williams, Danilo Bargen and Luke Plant for their work on this.
2012-06-11 10:40:23 +02:00
7ab6e32843
Revised the text in the 'Processing the data from a form' section.
2012-06-08 12:13:52 +02:00
3c05b500a5
Revised the text in the 'Using a form in a view' section.
2012-06-08 12:03:52 +02:00
33999d9871
Fixed #18445 -- Added a links in the docs.
...
Thanks Audrey Roy for the patch.
2012-06-07 22:11:24 +02:00
c28e700c7e
Removed references to changes made in 1.2.
...
Thanks Florian Apolloner for the patch.
2012-06-07 15:02:35 +02:00
6799ffad9a
Merge pull request #99 from danielroseman/master
...
Docs: "Form in a view" example doesn't use RequestContext
2012-06-04 13:13:14 -07:00
5c59e43aef
Use render shortcut in form example.
2012-05-31 15:33:45 +01:00
6219591f2e
Fixed #18244 -- Documented that formset.has_changed is a 1.4 addition.
2012-05-22 13:56:03 +02:00
596cb9c7e2
Replaced print statement by print function (forward compatibility syntax).
2012-04-30 20:45:03 +02:00
9ed6e08ff9
Removed deprecated URLField.verify_exists.
...
The deprecation schedule was slightly accelerated because of possible security ramifications.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17847 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2012-03-31 13:55:03 +00:00
6ecadcbdd2
Made a bunch more edits up until [17418]
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17428 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2012-02-03 20:45:45 +00:00
e308cfc0e1
Added support for specifying initial values to model formsets and inline formsets.
...
This make them consistent with the similar capability of regular
formsets. Thanks to simon29 form the report and to Claude Paroz for the
patch.
Fixes #14574 .
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17373 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2012-01-15 01:36:14 +00:00
f2d02647fa
Fixed #16851 - Added how-to access form field value in template; thanks yasar11732 for the patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17138 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-11-21 23:33:39 +00:00
d1e5c55258
Fixed many more ReST indentation errors, somehow accidentally missed from [16955]
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16983 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-10-14 00:12:01 +00:00
749f0721c4
Fixed #16985 -- corrected a few grammar errors in the docs.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16925 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-10-04 23:54:12 +00:00
4f109fcbff
Fixed 11674 -- Clarified docs on excluded fields of ModelForms.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16875 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-22 04:52:43 +00:00
3513234cf8
Fixed #16815 -- Rectified the code example for hidden_fields and visible_fields in the forms documentation. Thanks, joonas.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16823 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-13 08:22:53 +00:00
d14bf8c62b
Fixed #11404 . Added ``FormSet.has_changed``, for consistancy with ``Form.has_changed``. Thanks to michelts for the patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16773 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-10 02:42:05 +00:00
01b0eb50fd
Make ``Formset.__getitem__`` O(1), rather than O(n). If you override ``__iter__`` you now need to also override ``__getitem__`` for consistant behavior. Thanks to Carl and Russ for the review.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16770 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-10 01:53:56 +00:00
bdd1409eea
Fixed #16467 -- Restored a previously correct example which was broken in [16564]. Thanks to dmclain for pointing out that the original example was correct.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16623 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-18 21:47:04 +00:00
566b3295fa
Fixed #16621 -- Fixed lots of typos in the docs. Thanks, Bernhard Essl.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16615 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-13 11:58:19 +00:00
0350d65fa4
Fixed #16513 - Add forms import to example; thanks teraom.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16586 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-06 19:02:20 +00:00
8ac23178ad
Fixed #16467 -- Corrected formset code example. Thanks, teraom.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16564 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-07-29 09:40:22 +00:00
1dfa567a23
Fixed typos introduced in r16430 and r16431. Thanks, magopian.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16433 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-06-18 08:48:25 +00:00
2a122be0fc
Fixed #16126 -- Added documentation about DELETE and ORDER fields in formsets. Many thanks to Aleksandra Sendecka.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16430 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-06-17 15:39:28 +00:00
ce3c281090
Fixed #811 -- Added support for IPv6 to forms and model fields. Many thanks to Erik Romijn.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16366 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-06-11 13:48:24 +00:00
fc508fd5d2
Fixed #15990 - Simplified a sentence regarding form validation for ModelForms; thanks jblaine for the suggestion.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16329 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-06-04 21:42:53 +00:00
94af19c43f
Changed e-mail to email throughout documentation and codebase. The one exception is translation strings, which I didn't want to disrupt
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15967 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-04-01 16:10:22 +00:00
413ceb57b2
Changed 'raise' statements to new style syntax in documentation. Thanks DaNmarner. Refs #15635 .
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15874 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-03-17 20:49:31 +00:00
d1290b5b43
Fixed #3094 -- Accelerated deprecation of XMLField, since it hasn't served any useful purpose since oldforms. Thanks to PaulM for driving the issue and providing the patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15723 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-03-03 13:28:20 +00:00
327d69de73
Fixed #15134 -- Placed formset documentation before modelform documentation in the forms topic index to improve the logical flow of information being presented. Thanks to Aryeh Leib Taurog for the report.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15447 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-02-07 23:39:29 +00:00
0f50ef12bf
Fixed #15055 -- added information about (and an example of) the csrf_token template tag to the forms documentation. Thanks to sneakyness for the report and bpeschier for the draft patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15445 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-02-07 22:52:39 +00:00
8fe42053bc
Reworded parts of the staticfiles documentation after receiving various user feedback. Thanks, all!
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15369 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-01-30 17:23:25 +00:00
38d60c3941
Fixed #13949 - Note that readonly fields can't be modified via custom clean methods. thanks alk for the suggestion and elbarto and Gabriel Hurley whose language I used in the final patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15060 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-12-26 21:50:16 +00:00
2ea93f9327
Fixed #14000 - remove versionadded/changed tags for Django 1.0 and 1.1
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15055 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-12-26 00:37:14 +00:00
877963f541
Corrected a markup error introduced in r14986.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14988 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-12-19 15:01:12 +00:00
7adffaeaf6
Fixed #14655 -- Made formsets iterable. This allows a slightly more natural iteration API (`for form in formsets`), and allows you to easily override the form rendering order. Thanks to Kent Hauser for the suggestion and patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14986 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-12-19 13:41:43 +00:00
3ae9117c46
Fixes #7817 and #9456 .
...
- The include tag now has a 'with' option to include to provide extra context
vairables to the included template.
- The include tag now has an 'only' option to exclude the current context
when rendering the included template.
- The with tag now accepts multiple variable assignments.
- The with, include and blocktrans tags now use a new keyword argument format
for variable assignments (e.g. `{% with foo=1 bar=2 %}`).
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14922 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-12-18 02:50:26 +00:00
68548c3eff
Fixed #14897 -- fixed some synax highlighting in the formset documentation. Thanks to marcusf for the patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14912 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-12-13 19:37:18 +00:00
22d4ecb19b
Fixed #14791 - Clarify additional note on save(). Thanks OldTroll.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14740 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-28 18:48:55 +00:00
65b380e74a
Fixed #11418 -- formset.cleaned_data no longer raises AttributeError when is_valid is True. Thanks mlavin!
...
This also introduces a slightly backwards-incompatible change in
FormSet's behavior, see the release docs for details.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14667 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-21 17:27:01 +00:00
c0248f6f07
Corrected some syntax issues in the docs.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14598 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-17 16:08:28 +00:00
Marc Tamlyn
Sorcha Bowler
Loic Bistuer
yokomizor
Tim Graham
Phaneendra Chiruvella
Dominic Rodger
James Bennett
Claude Paroz
Ben Firshman
Baptiste Mispelon
Wilfred Hughes
Gabe Jackson
Kenny Rachuonyo
Ryan Kaskel
leandrafinger
Erik Romijn
Luke Plant
Thomas Thurman
Juan Catalano
Simon Charette
Andrew Gorcester
Aymeric Augustin
Alex Hunley
JonLoy
Nick Sandford
Nick Martini
Florian Apolloner
Jannis Leidel
Audrey Roy
Adrian Holovaty
Daniel Roseman
Ramiro Morales
Alex Gaynor
Paul McMillan
Julien Phalip
Gabriel Hurley
Russell Keith-Magee
Chris Beaven
Honza Král