Loic Bistuer
bed504d70b
Fixed #24351 , #24346 -- Changed the signature of allow_migrate().
...
The new signature enables better support for routing RunPython and
RunSQL operations, especially w.r.t. reusable and third-party apps.
This commit also takes advantage of the deprecation cycle for the old
signature to remove the backward incompatibility introduced in #22583 ;
RunPython and RunSQL won't call allow_migrate() when when the router
has the old signature.
Thanks Aymeric Augustin and Tim Graham for helping shape up the patch.
Refs 22583.
2015-02-20 21:34:09 +07:00
Marc Tamlyn
c490e410af
Fixed #24373 -- Added run_validators to ArrayField.
...
Thanks to DavidMuller for the report.
2015-02-20 11:51:46 +00:00
Marc Tamlyn
32d4db66b9
Update converters to take a consistent set of parameters.
...
As suggested by Anssi. This has the slightly strange side effect of
passing the expression to Expression.convert_value has the expression
passed back to it, but it allows more complex patterns of expressions.
2015-02-20 11:35:52 +00:00
Marc Tamlyn
4755f8fc25
Fixed #24343 -- Ensure db converters are used for foreign keys.
...
Joint effort between myself, Josh, Anssi and Shai.
2015-02-20 11:35:51 +00:00
Tim Graham
c8074d62f8
Fixed typo in error message in the test.
2015-02-19 19:36:20 -05:00
Aymeric Augustin
1bfcc950ab
Set context.template instead of context.engine while rendering.
...
This opens more possibilities, like accessing context.template.origin.
It also follows the chain of objects instead of following a shortcut.
2015-02-19 22:08:11 +01:00
Claude Paroz
efb1f99f94
Fixed #20889 -- Prevented BadHeaderError when Python inserts newline
...
Workaround for http://bugs.python.org/issue20747 .
In some corner cases, Python 2 inserts a newline in a header value
despite `maxlinelen` passed in Header constructor.
Thanks Tim Graham for the review.
2015-02-19 20:18:31 +01:00
Shai Berger
ceadc94f09
Fixed #24307 : Avoided redundant column nullability modifications on Oracle
...
Thanks Joris Benschop for the report, and Tim Graham for the tests.
2015-02-19 02:39:41 +02:00
Shai Berger
f7d34fe741
Fixed #24362 : Made test run each migration operation in its own schema editor
...
Thanks Tim Graham for pointing out the fix.
2015-02-18 22:47:15 +02:00
Marten Kenbeek
15dc8d1c9d
Fixed #24291 - Fixed migration ModelState generation with unused swappable models
...
Swapped out models don't have a _default_manager unless they have
explicitly defined managers. ModelState.from_model() now accounts for
this case and uses an empty list for managers if no explicit managers
are defined and a model is swapped out.
2015-02-18 19:05:10 +01:00
Tim Graham
b8d6cdbcc9
Refs #24324 -- Skipped fixtures_regress tests that fail on Python 2 on a non-ASCII path.
2015-02-18 07:25:36 -05:00
Tim Graham
307c0f299a
Refs #24324 -- Fixed Python 2 test failures when path to Django source contains non-ASCII characters.
2015-02-17 19:03:03 -05:00
Tim Graham
ad50b6c853
Fixed "environment can only contain strings" in model_regress test on Windows.
2015-02-17 13:54:18 -05:00
Tim Graham
d316b43d0a
Refs #24324 -- Fixed UnicodeDecodeError in model_regress test on non-ASCII path.
2015-02-17 07:32:48 -05:00
Tim Graham
8b39f33d78
Fixed #24290 -- Skipped postgres_tests if not running with PostgreSQL.
2015-02-17 06:34:13 -05:00
Tim Graham
3adc5f1ee6
Fixed #24335 -- Bumped required psycopg2 version to 2.4.5 (2.5 for contrib.postgres).
2015-02-16 18:07:27 -05:00
Tim Graham
664c038f2c
Moved contrib.contenttypes tests out of contrib.
2015-02-16 17:45:38 -05:00
Markus Holtermann
d538e37e1b
Added tests for get_related_models_recursive
2015-02-16 19:31:52 +01:00
Markus Holtermann
273bc4b667
Refs #24282 -- Added failing test case for assigning models of wrong type to FK
...
Thanks Jeff Singer for the test case.
2015-02-16 19:31:51 +01:00
Markus Holtermann
cc22b009e0
Refs #24264 -- Added failing test case for updating a FK when changing a PK
...
When the primary key column is altered, foreign keys of referencing
models must be aware of a possible data type change as well and thus
need to be re-rendered.
Thanks Tim Graham for the report.
2015-02-16 19:31:51 +01:00
Claude Paroz
58d0dd9260
Refs #24225 -- Added failing test case for removing a previously added field in migrations
...
When a related field is deleted, the related model must be updated. As
unchanged models are shared in migration states, the related model must
be re-rendered so that the change applies to a new copy of the related
model.
Thanks Henrik Heimbuerger for the report.
2015-02-16 19:31:51 +01:00
Marten Kenbeek
f668bac9d2
Fixed #24345 -- Isolated sitemaps_tests from contenttypes_tests; refs #11505
2015-02-16 08:42:43 -05:00
Loic Bistuer
c5a77721e2
Merged ManyRelatedObjectsDescriptor and ReverseManyRelatedObjectsDescriptor
...
and made all "many" related objects descriptors inherit from
ForeignRelatedObjectsDescriptor.
2015-02-16 20:40:04 +07:00
Aymeric Augustin
15b711b5ee
Deprecated TEMPLATE_DEBUG setting.
2015-02-15 20:47:04 +01:00
Tim Graham
e0b3926026
Isolated auth_tests from contenttypes_tests; refs #11505 .
2015-02-14 22:04:48 -05:00
Michael Angeletti
49647bec6e
Added missing return value to DurationField.prepare_value(); refs #24339 .
2015-02-14 18:38:50 -05:00
Aymeric Augustin
76356d963c
Fixed #24318 -- Set the transaction isolation level with psycopg >= 2.4.2.
2015-02-14 18:51:11 +01:00
Michael Angeletti
8a21d25033
Fixed #24339 -- Fixed crash with empty DurationField form field.
2015-02-14 07:37:18 -05:00
Claude Paroz
1791a7e75a
Fixed #15779 -- Allowed 'add' primary key in admin edition
...
Thanks Marwan Alsabbagh for the report, and Simon Charette and
Tim Graham for the reviews.
2015-02-14 11:19:55 +01:00
Aymeric Augustin
47ee7b48ad
Fixed #24338 -- Accepted Template wrapper in {% extends %}.
...
Explicitly checking for django.template.Template subclasses is
preferrable to duck-typing because both the django.template.Template and
django.template.backends.django.Template have a render() method.
Thanks spectras for the report.
2015-02-14 10:21:06 +01:00
Loic Bistuer
18c0aaa912
Fixed #24289 -- Reversed usage of Field.many_to_one and one_to_many.
...
Thanks Carl Meyer and Tim Graham for the reviews and to all involved
in the discussion.
2015-02-14 02:28:24 +07:00
Andriy Sokolovskiy
5c995dcfc2
Fixed #24320 - Used field.value_to_string() in serialization of foreign key.
...
This fixes serialization of a ForeignKey to a UUIDField as the
test indicates.
2015-02-13 12:37:23 -05:00
Tim Graham
002425fe39
Fixed #24315 -- Fixed auth.views.password_reset_confirm() with a UUID user.
2015-02-13 09:56:31 -05:00
Tim Graham
fdf20093e0
Fixed #24334 -- Allowed admin password reset to work with non-digit custom user model primary key.
...
Thanks Loic for help and Simon for review.
2015-02-13 09:42:49 -05:00
Markus Holtermann
f287bec583
Fixed #24184 -- Prevented automatic soft-apply of migrations
...
Previously Django only checked for the table name in CreateModel
operations in initial migrations and faked the migration automatically.
This led to various errors and unexpected behavior. The newly introduced
--fake-initial flag to the migrate command must be passed to get the
same behavior again. With this change Django will bail out in with a
"duplicate relation / table" error instead.
Thanks Carl Meyer and Tim Graham for the documentation update, report
and review.
2015-02-13 14:29:59 +01:00
Markus Holtermann
b4e1090ab2
Removed explicit pointers to migration modules for contrib apps in runtest
...
Thanks Tim Graham for the patch
2015-02-13 14:29:45 +01:00
Markus Holtermann
b06935a486
Refs #22962 -- Made test case use non-conflicting table names
2015-02-13 14:01:54 +01:00
Loic Bistuer
00a889167f
Fixed #24295 -- Allowed ModelForm meta to specify form field classes.
...
Thanks Carl Meyer and Markus Holtermann for the reviews.
2015-02-13 19:13:05 +07:00
Tim Graham
e8cf4f8abe
Fixed #24332 -- Fixed contrib.sites create_default_site() when 'default' DATABASES is empty.
2015-02-13 07:01:28 -05:00
Josh Smeaton
bd4afef984
Refs #14030 -- Added tests for Value aggregates
2015-02-13 10:06:46 +11:00
Josh Smeaton
de0241eb98
Fixed #24319 -- Added validation for UUID model field
2015-02-13 09:45:53 +11:00
Tim Graham
d64baaef3b
Fixed #24333 -- Fixed admin history view crash with non-integer slug.
2015-02-12 14:19:44 -05:00
Simon Charette
9239f1dda7
Refs #24215 -- Prevented pending lookup pollution by abstract models.
2015-02-12 13:07:09 -05:00
Tim Graham
d7509c5246
Added a test for UUIDField serialization; refs #24320 .
2015-02-12 09:54:42 -05:00
Tim Graham
e4999bf671
Added missing import from last commit.
2015-02-12 08:18:10 -05:00
Tim Graham
27eeb64a96
Fixed #17716 -- Prevented include('...', app_name='...') without a namespace.
2015-02-12 08:07:58 -05:00
Tim Graham
0f7f5bc9e7
Fixed #24161 -- Stored the user primary key as a serialized value in the session.
...
This allows using a UUIDField primary key along with the JSON session
serializer.
Thanks to Trac alias jamesbeith for the report and Simon Charette
for the initial patch.
2015-02-12 07:38:16 -05:00
Lukas Klein
93b3ef9b2e
Fixed #24321 -- Improved `utils.http.same_origin` compliance with RFC6454
2015-02-12 08:58:35 +01:00
Josh Smeaton
e2d6e14662
Refs #14030 -- Improved expression support for python values
2015-02-12 08:46:25 +11:00
Collin Anderson
07cfe1bd82
Refs #14497 -- Handled empty readonly admin FileFields
2015-02-11 13:00:56 -05:00
Tim Graham
8ec306a3a9
Moved contrib.webdesign tests out of contrib.
2015-02-11 12:30:07 -05:00
Tim Graham
7cf3a5786b
Updated docs and runtests.py for removal of tests from contrib.
2015-02-11 10:29:54 -05:00
Tim Graham
ad0be620ae
Moved contrib.gis tests out of contrib.
2015-02-11 10:29:54 -05:00
Tim Graham
5ab327a389
Moved non-documented auth test models to the new test location.
2015-02-11 10:29:48 -05:00
Tim Graham
2d7aca3da0
Moved contrib.auth tests out of contrib.
2015-02-11 10:19:22 -05:00
Tim Graham
8192a164de
Moved contrib.humanize tests out of contrib.
2015-02-11 10:19:22 -05:00
Tim Graham
00da46091a
Moved contrib.redirects tests out of contrib.
2015-02-11 10:19:22 -05:00
Tim Graham
b3cd9e0d07
Moved contrib.messages tests out of contrib.
2015-02-11 10:19:22 -05:00
Tim Graham
fac3a34cbb
Moved contrib.sessions tests out of contrib.
2015-02-11 10:19:22 -05:00
Tim Graham
fbc467c26b
Moved contrib.sitemaps tests out of contrib.
2015-02-11 10:19:22 -05:00
Tim Graham
d8341bf024
Moved contrib.sites tests out of contrib.
2015-02-11 10:19:22 -05:00
Tim Graham
d3a725054f
Moved contrib.flatpages tests out of contrib.
2015-02-11 10:19:22 -05:00
Tim Graham
197dd4b8f1
Prevented some test commands from needlessly running system checks.
...
This is a performance optimization and also fixes test errors with the
upcoming merge of contrib tests into tests/. The tests failed on MySQL
because the models with GeometryField were being checked but the
non-GIS MySQL backend didn't know how to handle them.
2015-02-11 10:14:38 -05:00
Daniel Pyrathon
19188826b4
Fixed #24146 -- Allowed model._meta.get_field() to be used after apps.models_ready
2015-02-10 19:55:06 -05:00
Aymeric Augustin
1b8af4cfa0
Disallowed importing concrete models without an application.
...
Removed fragile algorithm to find which application a model belongs to.
Fixed #21680 , #21719 . Refs #21794 .
2015-02-10 21:41:19 +01:00
Tim Graham
c970018f41
Removed Django 1.7 MIDDLEWARE_CLASSES upgrade check.
2015-02-09 19:16:07 -05:00
Simon Charette
5b75b01939
Refactored an admin_view test case.
...
Used setUpTestData, client login/logout and manager's count() method.
Thanks to Tim for the review.
2015-02-09 15:08:05 -05:00
Simon Charette
8a590c4b7b
Moved a custom admin template test to a more appropriate case.
...
Thanks to Tim for the review.
2015-02-09 15:07:49 -05:00
Claude Paroz
50aa1a790c
Replaced some more hardcoded admin URLs
2015-02-09 17:29:53 +01:00
Tim Graham
2d7c27d387
Fixed #24302 -- Added DurationField.formfield()
2015-02-09 10:20:01 -05:00
Tim Graham
e144e0e237
Removed unnecessary parentheses in model check messages.
2015-02-09 08:53:58 -05:00
Aron Podrigal
4d73303ee9
Fixed #24249 -- Improved field shadowing validation in model multi-inheritance.
2015-02-09 08:37:55 -05:00
Claude Paroz
32e6a7d3a5
Replaced hardcoded URLs in admin_* tests
...
Refs #15779 . This will allow easier admin URL changes, when needed.
Thanks Simon Charette for the review.
2015-02-08 20:55:09 +01:00
Tim Graham
9033003d97
Added check_apps_ready() to Apps.get_containing_app_config()
2015-02-08 14:52:19 -05:00
Varun Sharma
540ca563de
Fixed #24181 -- Fixed multi-char THOUSAND_SEPARATOR insertion
...
Report and original patch by Kay Cha.
2015-02-08 20:00:57 +01:00
Claude Paroz
58afd30b59
Tested DecimalField with scientific notation
...
Refs #15775 .
2015-02-06 22:30:50 +01:00
Collin Anderson
db77915c9f
Fixed E265 comment style
2015-02-06 09:30:35 -05:00
Tim Graham
0ed7d15563
Sorted imports with isort; refs #23860 .
2015-02-06 08:16:28 -05:00
Anssi Kääriäinen
20b74b10be
Added a test for refs #24279
...
This issue was fixed in afe0bb7b13
.
2015-02-06 07:43:59 -05:00
Aymeric Augustin
23a5ec0782
Added trailing comma.
...
Sorry, I couldn't stand the inconsistency between the two databases anymore.
2015-02-06 12:58:45 +01:00
Aymeric Augustin
d39073b8ae
Hid Django installation message when verbosity is 0.
...
This message was introduced to help people figure out quickly when they
aren't running the tests against the copy of Django they're editing.
There's no reason to display it when verbosity is set to 0. It defaults
to 1.
2015-02-06 12:56:53 +01:00
Tim Graham
bbe28496d3
Removed old import aliases.
2015-02-05 19:37:01 -05:00
Tim Graham
0f54cf28c0
Added UUIDField.deconstruct()
2015-02-05 19:15:02 -05:00
Markus Holtermann
235124d3ea
Fixed small regression caused by 0204714b0b
...
Since 1.7 models need to declare an explicit app_label if they are not
in an application in INSTALLED_APPS or were imported before their
application was loaded.
2015-02-06 00:45:07 +01:00
Markus Holtermann
0204714b0b
Cleaned up schema tests
...
Thanks Tim Graham for the review.
2015-02-05 20:11:48 +01:00
Aymeric Augustin
44ad691558
Fixed #24265 -- Preserved template backend loading exceptions.
...
If importing or initializing a template backend fails, attempting to
access this template backend again must raise the same exception.
2015-02-05 20:06:18 +01:00
Aymeric Augustin
31d3a35579
Fixed #24273 -- Allowed copying RequestContext more than once.
...
Thanks Collin Anderson for the report.
2015-02-05 13:21:50 +01:00
Loic Bistuer
71ada3a8e6
Fixed #6707 -- Added RelatedManager.set() and made descriptors' __set__ use it.
...
Thanks Anssi Kääriäinen, Carl Meyer, Collin Anderson, and Tim Graham for the reviews.
2015-02-05 12:45:08 +07:00
Matthew Somerville
caa3562d5b
Fixed #24242 -- Improved efficiency of utils.text.compress_sequence()
...
The function no longer flushes zfile after each write as doing so can
lead to the gzipped streamed content being larger than the original
content; each flush adds a 5/6 byte type 0 block. Removing this means
buf.read() may return nothing, so only yield if that has some data.
Testing shows without the flush() the buffer is being flushed every 17k
or so and compresses the same as if it had been done as a whole string.
2015-02-04 13:04:00 -05:00
mlavin
2730dad0d7
Fixed #24197 -- Added clearing of staticfiles caches on settings changes during tests
...
Cleared caching in staticfiles_storage and get_finder when
relevant settings are changed.
2015-02-04 10:53:04 -05:00
Preston Timmons
23c4cbc0fa
Cleaned up formatting in template_tests.test_custom.
2015-02-04 09:47:24 -05:00
Anssi Kääriäinen
7145c8a62a
Removed EverythingNode
...
At the same time, made sure that empty nodes in where clause match
everything.
2015-02-04 09:26:40 -05:00
Riccardo Magliocchetti
2be621e44c
Fixed #14497 -- Improved admin widget for "read only" FileFields
...
Based on patch by Adam J Forster, Paul Collins, and Julien.
2015-02-04 09:05:23 -05:00
Josh Schneier
7d363ed432
Fixed typos of "select_related" in docs and tests.
2015-02-04 07:31:43 -05:00
Aron Podrigal
79f27f2b61
Fixed #15321 -- Honored ancestors unique checks.
...
Thanks to Tim for the review.
2015-02-03 18:56:53 -05:00
Tim Graham
1fc458b5a3
Removed a useless check in runtests.py
...
Added in 3e97535907
, this check
appears to never be triggered today.
2015-02-03 18:32:00 -05:00
Tim Graham
c0cc8f69e7
Refactored tests that rely on an ImportError for Python 3.5 compatibility
...
A change in Python test discovery [1] causes the old packages that raised
an error to be discovered; now we use a common directory that's
ignored during discovery. Refs #23763 .
[1] http://bugs.python.org/issue7559
2015-02-03 18:30:46 -05:00
Simon Charette
65e005f8cd
Fixed #24266 -- Changed get_parent_list to return a list ordered by MRO.
...
Thanks to Aron Podrigal for the initial patch and Tim for the review.
2015-02-03 16:40:31 -05:00
Tim Graham
0e489c19f1
Reverted "Fixed #24146 -- Fixed a missing fields regression in admin checks."
...
This reverts commit e8171daf0c
.
A new solution is forthcoming.
2015-02-03 15:23:39 -05:00
darkryder
9ec8aa5e5d
Fixed #24149 -- Normalized tuple settings to lists.
2015-02-03 14:59:45 -05:00