Ramiro Morales
fb45e666c2
[1.7.x] Fixed #22421 -- Regression in fixtures loading.
...
Loading fixtures were failing since the refactoring in 244e2b71f5
for
inheritance setups where the chain contains abstract models and the
root ancestor contains a M2M relation.
Thanks Stanislas Guerra for the report.
Refs #20946 .
Backport of 862e1ff234
from master
2014-05-22 07:38:39 -04:00
Tim Graham
f25c5de4ce
[1.7.x] Skipped a migrations test that's not supported on MySQL + Python 3.
...
Backport of dfeef8e147
from master
2014-05-21 07:04:46 -04:00
Andrew Godwin
fd62bc165c
[1.7.x] Fixed #22432 : SQLite M2M repointing now works. Thanks to xelnor.
...
Backport of 03900a02d5
from master
2014-05-21 07:04:46 -04:00
Loic Bistuer
c60240e712
[1.7.x] Failing testcases for #22649 .
...
Backport of 5789ff7330
from master
2014-05-21 07:04:46 -04:00
Loic Bistuer
d61b6224b0
[1.7.x] Fixed #22424 -- Fixed handling of default values for TextField/BinaryField on MySQL.
...
Thanks syphar for the review and suggestions.
Backport of 1d3d01b4f7
from master
2014-05-21 07:04:38 -04:00
Huu Nguyen
f7270dcd9d
[1.7.x] Fixed #22661 -- Move makemigrations tests to the proper class
...
Backport of 44304cf04e
from master
2014-05-21 06:56:23 -04:00
Loic Bistuer
0fa1aeb8d8
[1.7.x] Fixed the ordering of prefetch lookups so that latter lookups can refer to former lookups.
...
Thanks Anssi Kääriäinen and Tim Graham for the reviews. Refs #17001 and #22650 .
Backport of 870b0a1f86
from master
2014-05-21 10:37:41 +07:00
Loic Bistuer
24a41ecc35
[1.7.x] Fixed #22650 -- Fixed regression on prefetch_related.
...
Regression from f51c1f59
when using select_related then prefetch_related
on the reverse side of an O2O:
Author.objects.select_related('bio').prefetch_related('bio__books')
Thanks Aymeric Augustin for the report and tests. Refs #17001 .
Backport of bdf3473e64
from master
2014-05-21 10:37:00 +07:00
Denis Cornehl
0007a43198
[1.7.X] Fixed #22557 -- ManifestStaticFilesStorage did not cleanup deleted files.
...
When using ManifestStaticFilesStorage, deleted static files would be
correctly cleaned up by "collectstatic --clear", but the manifest file
would still contain the stale entries.
Thanks to tedtieken for the report
Backport of 3bec38888f
from master.
2014-05-20 18:19:40 +02:00
Marc Tamlyn
157575c7c8
[1.7.x] Fix a2dd618
for mysql.
...
Backport of 3b76502
from master
2014-05-19 15:05:23 +01:00
Marc Tamlyn
c38925a601
[1.7.x] Fixed #22648 -- Transform.output_type should respect overridden custom_lookup and custom_transform.
...
Previously, class lookups from the output_type would be used, but any
changes to custom_lookup or custom_transform would be ignored.
Backport of a2dd618
from master
2014-05-19 15:05:23 +01:00
Alex Gaynor
8b87473008
[1.7.x] Fixed several flake8 errors, including one where a test wouldn't be run
...
Backport of b6b873d2ad
from master
2014-05-17 13:31:09 -04:00
Shai Berger
b7a67b788c
[1.7.x] Fixed storing of binary fields and unicode textfields for Oracle/Python3
...
Backport of 6bb6df2943
from master
2014-05-17 01:16:06 +03:00
Aymeric Augustin
62de03ee33
[1.7.x] Optimized make_aware/naive by removing redundant checks. Refs #22625 .
...
Also added tests with pytz and removed misplaced tests.
Backport of 1109ebd
from master
2014-05-16 23:14:13 +02:00
Aymeric Augustin
6f8301d6cd
[1.7.x] Fixed #22625 -- Normalized make_aware/naive errors.
...
Also added tests for is/make_aware/naive.
Thanks Tom Michaelis for the report.
Backport of fa89acf
from master
2014-05-16 22:54:21 +02:00
Stas Rudakou
75d2da797e
[1.7.x] Fixed #22266 - quote PK before redirecting away from add_view (django.contrib.admin)
...
Backport of ebd70d4d00
from master.
2014-05-16 18:38:26 +02:00
Erik Romijn
2a66d12e77
[1.7.x] Fixed #22579 -- Corrected validation for email to reject trailing slash
...
Backport of 424fe76349
from master.
2014-05-16 15:19:21 +02:00
Stephen Burrows
79f15ab1ef
[1.7.x] Fixed #22628 -- Took initial forms into account when combining FormSet.min_num and FormSet.extra.
2014-05-16 06:37:05 -04:00
Claude Paroz
e8a7436941
[1.7.x] Harmonized some PEP 0263 coding preambles
...
Backport of e520a73ee
from master.
2014-05-15 20:01:31 +02:00
Anders Steinlein
2914f66983
[1.7.x] Fixed #17642 -- Added min_num support to modelformsets, inlines, and the admin.
...
Thanks Stephen Burrows for work on the patch as well.
2014-05-15 07:02:06 -04:00
Erik Romijn
e7b0cace45
[1.7.x] Added additional checks in is_safe_url to account for flexible parsing.
...
This is a security fix. Disclosure following shortly.
2014-05-14 10:18:27 +02:00
Aymeric Augustin
7fef18ba9e
[1.7.x] Dropped fix_IE_for_vary/attach.
...
This is a security fix. Disclosure following shortly.
2014-05-14 10:18:26 +02:00
Claude Paroz
9d0ebceb32
[1.7.x] Fixed #21685 -- Displayed app verbose name in admindocs model index
...
Backport of 4cf82e5bcf
from master.
2014-05-10 18:10:05 +02:00
Aymeric Augustin
e9d0ef19bc
[1.7.x] Fixed #22508 -- Avoided overwriting select_related.
...
Previously, known related objects overwrote related objects loaded
though select_related. This could cancel the effect of select_related
when it was used over more than one level.
Thanks boxm for the bug report and timo for bisecting the regression.
Backport of f574220f
from master
2014-05-10 17:03:42 +02:00
Aymeric Augustin
c54fb3d922
[1.7.x] Adjusted refactoring of vendor checks.
...
Thanks Shai for the thorough review.
Backport of fb90b7c
from master
2014-05-10 14:55:22 +02:00
Stephen Burrows
0c198035e9
[1.7.x] Fixed #22502 -- Fixed microseconds/default/form interaction
...
Made explicit lack of microsecond handling by built-in datetime form
fields. Used that explicitness to appropriately nix microsecond
values in bound fields. Thanks Claude Paroz for the review.
Backport of a5de0df58
from master.
2014-05-10 10:58:51 +02:00
Malcolm Box
8a090c21f1
[1.7.x] Fixed #22606 -- Locmemcache has_key() failed for infinite cache expiry
...
Refactored cache expiry logic for Locmemcache to make consistent across
all places where accessed, and correctly handle None as expiry time.
Backport of 66880e4cd
from master.
2014-05-09 19:47:43 +02:00
Andrew Godwin
31eac71a76
[1.7.x] Tests for #22325
2014-05-08 21:49:09 -07:00
Andrew Godwin
d2e96b5792
Merge pull request #2637 from davidszotten/validator_comparisons
...
[1.7.x] Fixed #22588 -- Fix RegexValidator __eq__
2014-05-08 19:49:59 -07:00
Aymeric Augustin
7194d40236
[1.7.x] Added feature flags for introspection capabilities.
...
Backport of 99d9fa32
from master
2014-05-08 22:53:21 +02:00
Aymeric Augustin
92a1e71100
[1.7.x] Split ignores_nulls_in_unique_constraints feature.
...
Oracle and SQL Server don't have exactly the same limitations. It's
worth treating them differently.
Backport of cff59bed
from master
2014-05-08 22:53:11 +02:00
Aymeric Augustin
e3bc11cca9
[1.7.x] Replaced vendor checks by three feature flags.
...
Backport of c70a61eb
from master
2014-05-08 22:53:00 +02:00
Aymeric Augustin
7f48d44c60
[1.7.x] Simplified indexes tests.
...
Backport of 43a80f48
from master
2014-05-08 22:52:53 +02:00
Aymeric Augustin
51fed81e33
[1.7.x] Reorganized backends tests.
...
This reduces the number of explicit vendor checks.
Backport of d6672631
from master
2014-05-08 22:52:34 +02:00
Aymeric Augustin
e244e456c7
[1.7.x] Appeased flake8.
...
Backport of b1432bfc
from master
2014-05-08 22:45:26 +02:00
Andrew Godwin
f2bf59a5bc
[1.7.x] Fixed #22476 : Couldn't alter attributes on M2Ms with through= set
2014-05-08 10:34:45 -07:00
Andrew Godwin
7f63ac5a9f
[1.7.x] Fixed #22496 : Data migrations get transactions again!
2014-05-07 14:29:04 -07:00
Andrew Godwin
d8bf415ab2
[1.7.x] Fixed #22581 : Pass default values for schema through get_db_prep_save()
2014-05-07 13:47:02 -07:00
David Szotten
724a7bf222
[1.7.x] Fixed #22588 -- Fix RegexValidator __eq__
...
Compare parameters instead of re.pattern instances, and add the other
parameters to the comparison. Also add a __ne__ to make assertNotEqual
work properly.
2014-05-07 19:28:42 +01:00
Andrew Godwin
f53d1576ca
[1.7.x] Fixed #22337 : FileSystemStorage marked as deconstructible and tested.
2014-05-06 22:24:39 -07:00
Claude Paroz
0d138b9cf4
[1.7.x] Fixed #22564 -- Prevented unneeded bytestrings in migrations
...
In some cases, this could lead to migrations written with Python 2
being incompatible with Python 3.
Thanks Tim Graham for the report and Loïc Bistuer for the advices.
Backport of da9cf53cb
from master.
2014-05-06 09:14:32 +02:00
Ben Davis
549b658241
[1.7.x] Fixed #22570 -- Made Form.__getitem__ KeyError more descriptive.
...
Backport of df60db0e78
from master
2014-05-05 20:02:14 -04:00
Anssi Kääriäinen
76979a257d
[1.7.x] Fixed #22466 -- ordering by reverse foreign key
...
Ordering by reverse foreign key was broken by custom lookups patch
(commit 20bab2cf9d
).
Thanks to everybody who helped solving this issue. Special thanks to
Trac alias takis for reporting this.
Backport of 3b7c66a3ac
from master
2014-05-05 15:29:24 +03:00
Jakub Roztocil
4b6ba2c1d1
[1.7.x] Fixed #22489 -- missing implemenation for search lookup
...
When custom lookups were added, converting the search lookup to use
the new Lookup infrastructure wasn't done.
Some changes were needed to the added test, main change done by
committer was ensuring the test works on MySQL versions prior to 5.6.
Backport of 7131e14d00
from master
2014-05-05 14:40:06 +03:00
Anssi Kääriäinen
402fc4f6c9
[1.7.x] Fixed #22429 -- Incorrect SQL when using ~Q and F
...
Backport of 5e1f4656b9
from master
2014-05-05 13:06:51 +03:00
Tim Graham
f8fa735dc2
[1.7.x] Fixed #22435 -- Prevented adding a ManyToManyField from prompting for a default.
...
Thanks andrewsg for the report.
Backport of 3818d96426
from master
2014-05-02 20:53:39 -04:00
Claude Paroz
61fd00d4fd
[1.7.x] Fixed #22565 -- Prevented pgettext_lazy crash with bytestring input
...
Thanks ygbo for the report.
Backport of 142c27218
from master.
2014-05-02 19:33:58 +02:00
Chris Beaven
5ab93bbe74
[1.7.x] Fix migration autodector to work correctly with custom deconstructed values
2014-05-02 15:12:42 +12:00
Yehonatan Daniv
d56267ba57
[1.7.x] Fixed #22539 -- Copied exclude argument in Model.full_clean() to prevent side effects.
...
Backport of e2e4cdba11
from master
2014-05-01 09:30:49 -04:00
Tim Graham
e5941ba5f3
[1.7.x] flake8 fixes.
...
Backport of 45c2d1f5d9
from master.
2014-04-30 18:35:40 -04:00
Andrew Godwin
6ca5367869
[1.7.x] Cleanup failing test w/contenttypes and remove useless graph load
2014-04-30 15:12:18 -07:00
Andrew Godwin
35c2a14a49
[1.7.x] Fixed #22485 : Include all unmigrated apps in project state by default.
2014-04-30 12:26:11 -07:00
Simon Charette
a6ecd5dbb3
[1.7.x] Fixed #19195 -- Allow explicit ordering by a relation `_id` field.
...
Thanks to chrisedgemon for the report and shaib, akaariai and
timgraham for the review.
Backport of 24ec9538b7
from master
2014-04-30 14:26:39 -04:00
Claude Paroz
1084456ac2
[1.7.x] Fixed #22474 -- Made migration recorder aware of multiple databases
...
Thanks Tim Graham for the review.
Backport of 7c54f8cce
from master.
2014-04-30 16:55:12 +02:00
Mike Fogel
bb5c7e4e8d
[1.7.x] Fixed #22537 -- Add tests and improved docs for field subclass with choices.
...
Backport of 7fd1b35ed7
from master
2014-04-30 07:57:35 -04:00
Simon Charette
cda5745df0
[1.7.x] Fixed #22447 -- Make sure custom model bases can be migrated.
...
Thanks to cdestigter for the report.
Backport of 390f888745
from master
2014-04-29 10:55:45 -04:00
Tim Graham
1d20693fa6
[1.7.x] Revert "Fixed #15179 -- middlewares not applied for test client login()"
...
This reverts commit 4fdd51b732
.
See the ticket for concerns with this implementation; it will be revisited.
Backport of aabceadd7d
from master
2014-04-28 18:49:24 -04:00
Alex Gaynor
996564df4d
[1.7.x] Fix many many typos in comments throughout the codebase
...
Backport of 2bcb8bfc8d
from master
2014-04-26 14:35:57 -04:00
Aymeric Augustin
3bb0f118ca
[1.7.x] Fixed #3214 -- Stopped parsing SQL with regex.
...
Avoided introducing a new regex-based SQL splitter in the migrations
framework, before we're bound by backwards compatibility.
Adapted this change to the legacy "initial SQL data" feature, even
though it's already deprecated, in order to facilitate the transition
to migrations.
sqlparse becomes mandatory for RunSQL on some databases (all but
PostgreSQL). There's no API to provide a single statement and tell
Django not to attempt splitting. Since we have a more robust splitting
implementation, that seems like a good tradeoff. It's easier to add a
new keyword argument later if necessary than to remove one.
Many people contributed to both tickets, thank you all, and especially
Claude for the review.
Refs #22401 .
Backport of 8b5b199
from master
2014-04-26 17:46:57 +02:00
Tim Graham
bee118a701
[1.7.x] Fixed #22499 -- Fixed a typo in an admin_views test that caused failure on Oracle.
...
Backport of d238c58912
from master
2014-04-24 07:06:57 -04:00
Malcolm Box
07235aec9d
[1.7.x] Fixed #22495 -- Locmem cache.add() failed with infinite timeouts
...
cache.add() incorrectly succeeded when there was an existing key
with an infinite (None) timeout.
Backport of af5f688392
from master.
2014-04-23 14:56:54 +02:00
Tim Graham
e192f13103
[1.7.x] Fixed #22486 -- Restored the ability to reverse views created using functools.partial.
...
Regression in 8b93b31487
.
Thanks rcoup for the report.
Backport of 3c06b2f2a3
from master
2014-04-23 08:49:53 -04:00
Claude Paroz
1d0f1ee199
[1.7.x] Fixed table cleanup in GIS migration tests
...
Backport of ab90c4707b
from master.
2014-04-22 19:52:58 +02:00
Preston Timmons
935159d951
[1.7.x] Fixed #22478 -- Regression in test label discovery.
...
As part of the app-loading updates the old test runner was changed to not
require a models module. This introduced a regression in behavior so
applabel.TestCase failed for tests defined in a directory.
The fix is thanks to yakky and rtnpro.
2014-04-22 12:48:39 -04:00
Erik Romijn
34526c2f56
[1.7.x] Fixed queries that may return unexpected results on MySQL due to typecasting.
...
This is a security fix. Disclosure will follow shortly.
Backport of 75c0d4ea3a
from master
2014-04-21 18:29:39 -04:00
Aymeric Augustin
380545bf85
[1.7.x] Prevented leaking the CSRF token through caching.
...
This is a security fix. Disclosure will follow shortly.
Backport of c083e3815a
from master
2014-04-21 18:29:24 -04:00
Tim Graham
546740544d
[1.7.x] Fixed a remote code execution vulnerabilty in URL reversing.
...
Thanks Benjamin Bach for the report and initial patch.
This is a security fix; disclosure to follow shortly.
Backport of 8b93b31487
from master
2014-04-21 18:29:12 -04:00
Florian Apolloner
d7de6ed07e
[1.7.x] Fixed monkeypatching in a staticfiles test.
...
Backport of a4553e0510
from master
2014-04-21 08:58:41 -04:00
Aymeric Augustin
62eb79fc4c
[1.7.x] Appeased flake8 2.1.0.
...
Backport of 428c0bbe1b
from master
2014-04-21 07:50:50 -04:00
Alex Gaynor
50dddbdfc7
[1.7.x] Corrected many style guide violations that the newest version of flake8 catches
...
Backport of 778ce245dd
from master
2014-04-21 07:50:43 -04:00
Aymeric Augustin
0dad0ca55e
[1.7.x] Further consolidated the model_inheritance tests.
...
Backport of 3f01e82
from master
2014-04-21 11:51:21 +02:00
Aymeric Augustin
ab0afef959
[1.7.x] Fixed #22402 -- Consolidated model_inheritance tests.
...
The model_inheritance_same_model_name tests couldn't be run without the
model_inheritance tests. Make the problem go away by merging them.
Thanks timo for the report.
Backport of 0097d38 from master
2014-04-21 11:43:38 +02:00
Simon Charette
33d1dc2eeb
[1.7.x] Fixed flake8 warnings introduced in recent commits.
...
Backport of 79f05616fb
from master
2014-04-20 13:10:52 -04:00
Tim Graham
9e86c3f0a6
[1.7.x] Fixed flake8 errors.
...
Backport of 471fb04a30
from master
2014-04-20 13:09:12 -04:00
Andrew Gorcester
bc5d568e1e
[1.7.x] Fixed #22397 -- Issues removing M2M field with explicit through model
...
Changed the migration autodetector to remove models last so that FK
and M2M fields will not be left as dangling references. Added a check
in the migration state renderer to error out in the presence of
dangling references instead of leaving them as strings. Fixed a bug
in the sqlite backend to handle the deletion of M2M fields with
"through" models properly (i.e., do nothing successfully).
Thanks to melinath for report, loic for tests and andrewgodwin and
charettes for assistance with architecture.
Backport of 956bd64424
from master
2014-04-18 18:34:00 -04:00
Simon Charette
24016c9b62
[1.7.x] Fixed a test failure introduced by 214d1e1b0f
.
...
Backport of 9bc377d7d0
from master
2014-04-18 02:32:24 -04:00
Justin Hamade
7f8bd1a4b3
[1.7.x] Fixed #22434 -- Retain ordering on related sliced subqueries.
...
Thanks maciej.pawlisz for the report, and charettes for the review.
Backport of a13df671a5
from master
2014-04-16 18:02:25 -04:00
Motiejus Jakštys
71c8ae543f
[1.7.x] Fixed #22460 -- Explicity remove constraints when dropping a related field.
...
Backport of 0e45669fa9
from master
2014-04-16 16:37:08 -04:00
Simon Charette
9fb61cb64a
[1.7.x] Fixed #22350 -- Consistently serialize bytes and text in migrations.
...
Thanks to @treyhunner and Loïc for their suggestions and review.
Backport of 72d3889db4
from master
2014-04-13 19:03:20 -04:00
valtron
6b3a8d2705
[1.7.x] Fixed #21760 -- prefetch_related used an inefficient query for reverse FK.
...
Regression introduced by commit 9777442
. Refs #21410 .
Backport of d3b71b976d
from master
2014-04-13 00:51:38 +07:00
Claude Paroz
a6eda3a5fc
[1.7.x] Also allowed a non-overridden setting to be deleted
...
Refs #20032 , #18824 . Thanks ztorstri at gmail.com for the report.
Backport of 3417ba0309
from master.
2014-04-12 15:35:11 +02:00
Claude Paroz
d9f8cc12ae
[1.7.x] Fixed #22102 -- Made SimpleTestCase tests run before unittest.TestCase ones
...
Thanks aptiko for the report and Tim Graham for the review.
Backport of 3e3a7372f5
from master.
2014-04-12 11:43:10 +02:00
Aymeric Augustin
2ad0bc132a
[1.7.x] Fixed #21202 -- Maintained atomicity when the server disconnects.
...
Thanks intgr for the report.
This commit doesn't include a test because I don't know how to emulate a
database disconnection in a cross-database compatible way.
Also simplified a 'backends' test that was constrained by this problem.
Backport of 81761508
from master
2014-04-10 23:18:36 +02:00
Aymeric Augustin
2e42c859da
[1.7.x] Fixed #21239 -- Maintained atomicity when closing the connection.
...
Refs #15802 -- Reverted #7c657b24 as BaseDatabaseWrapper.close() now
has a proper "finally" clause that may need to preserve self.connection.
Backport of 25860096
from master.
2014-04-10 23:18:35 +02:00
Aymeric Augustin
7e89434084
[1.7.x] Fixed #22291 -- Avoided shadowing deadlock exceptions on MySQL.
...
Thanks err for the report.
Backport of 58161e4e
from master.
2014-04-10 23:02:54 +02:00
Tim Graham
ddd25b280f
[1.7.x] Fixed #22194 -- Added --list-tags option to check command.
...
Thanks Elvard for the patch.
Backport of 395d75ea6b
from master
2014-04-10 09:44:43 -04:00
Shai Berger
3a9a4570ef
[1.7.x] Fixed #22343 -- Disallowed select_for_update in autocommit mode
...
The ticket was originally about two failing tests, which are
fixed by putting their queries in transactions.
Thanks Tim Graham for the report, Aymeric Augustin for the fix,
and Simon Charette, Tim Graham & Loïc Bistuer for review.
Backport of b990df1d63 from master
2014-04-10 01:44:30 +03:00
Aymeric Augustin
f6f188ffc7
[1.7.x] Fixed #21553 -- Ensured unusable database connections get closed.
...
Backport of 5f2f47f
from master
2014-04-09 22:50:21 +02:00
Huu Nguyen
f22177a9a3
[1.7.x] Refs #21230 -- removed direct settings manipulation from signed cookies tests
...
Backport of b9bfcd82f0
from master
2014-04-08 12:15:40 -04:00
Alejandro Gómez
5e74d6cf0a
[1.7.x] Fixed #21084 -- Used proxy model's content type for admin log entries.
...
Backport of 7a7f6fccae
from master
2014-04-07 08:59:27 -04:00
Simon Charette
7b3a221ad6
[1.7.x] Fixed #22363 -- Correctly serialize `django.utils.datetime_safe` objects.
...
Thanks to linovia for the report.
Backport of 074d3183d9
from master
2014-04-03 14:56:41 -04:00
Loic Bistuer
6405889a72
[1.7.x] Fixed #22360 -- Fixed two non-deterministic tests in Python 3.4.
...
The order of admin's changelist filters in the querystring relied on
dict ordering.
Backport of 4d996b8e69
from master
2014-03-31 08:24:09 -04:00
Loic Bistuer
5268d71f18
[1.7.x] Fixed #21795 -- Made add_preserved_filters account for url prefixes.
...
Thanks to trac username honyczek for the report. Refs #6903 .
Backport of 4339e9a92d
from master
2014-03-31 07:20:20 -04:00
Loic Bistuer
8e73d3a2c1
[1.7.x] Fixed #22319 -- Fixed migration external dependencies when there are internal dependencies.
...
Backport of 0fd51cf0bd
from master
2014-03-31 06:57:44 -04:00
Loic Bistuer
bdec848063
[1.7.x] Fixed #22359 -- Changing M2M field to blank=True failed on sqlite.
...
Backport of a449e7feec
from master
2014-03-31 06:35:06 -04:00
Tim Graham
0f9f8738d5
[1.7.x] Fixed #22338 -- Fixed a test dependent on dictionary key iteration order.
...
Backport of 69a4f383f6
from master
2014-03-30 14:27:05 -04:00
Tim Graham
c9014a95bc
[1.7.x] Skipped JavascriptI18nTests if Firefox isn't properly configured.
...
Code borrowed from django.contrib.admin.tests. Without this, the class can
throw an exception with something like "The browser appears to have exited
before we could connect. The output was: Error: no display specified"
Backport of e2ac0203d9
from master
2014-03-28 07:30:35 -04:00
Tim Graham
0134d00be5
[1.7.x] Skipped a test that errors rather than marked it as an expectedFailure.
...
The test throws an error which Python 3.4 doesn't seem to catch as an
expectedFailure.
refs 7476d96f83
Backport of c170c3761b
from master
2014-03-27 07:01:20 -04:00
Tim Graham
3d74f1f64a
[1.7.x] Fixed a deprecation warning on Python 3.
...
Backport of c19bbefca2
from master
2014-03-27 07:01:04 -04:00
Loic Bistuer
39fc8d4b8e
[1.7.x] Fixed #22331 -- Made MigrationAutodetector ignore unmanaged models.
...
This commit reverts 69d4b1c
and tackle the issue from a different angle.
Models remain present in the project state, but are now ignored by the
autodetector.
Backport of 42336c84a0
from master
2014-03-25 20:04:49 -04:00
Simon Charette
78211b13a5
[1.7.x] Fixed #12030 -- Validate integer field range at the model level.
...
Thanks to @timgraham for the review.
Backport of 1506c71a95
from master
2014-03-25 14:31:54 -04:00
Tim Graham
d84beb3d91
Revert "[1.7.x] Fixed #22331 -- Fixed migrations ProjectState to ignore unmanaged models."
...
This reverts commit bf69375c4d
.
2014-03-25 12:07:37 -04:00
Loic Bistuer
bf69375c4d
[1.7.x] Fixed #22331 -- Fixed migrations ProjectState to ignore unmanaged models.
...
Backport of 69d4b1c3ea
from master
2014-03-25 10:34:28 -04:00
David Evans
ddcbde41ee
[1.7.x] Fixed #22315 -- str/bytes mismatch in staticfiles
...
Previously, `ManifestFilesMixin.read_manifest` failed in Python 3
because `json.loads` accepts `str` not `bytes`.
Backport of 86dcac4634
from master
2014-03-25 09:55:29 -04:00
Ben Davis
2460484486
[1.7.x] Fixed #22087 -- Made AdminReadonlyField respect ModelForm Meta overrides.
...
Backport of 16afffffe8
from master
2014-03-25 09:34:12 -04:00
Stephen Burrows
b4f165fe94
[1.7.x] Fixed #22300 -- Fixed crash in migrations when changing non-relational field to relational.
...
Backport of 35ed792cf2
from master
2014-03-25 07:46:48 -04:00
Daniel Hahler
21eaad68e6
[1.7.x] Fixed #22293 -- Avoided renaming many-to-many tables to themselves.
...
Fixed this for both implementations of _alter_many_to_many, instead of
in `alter_db_table` itself (more implementations).
Backport of 1edfa155e3
from master
2014-03-24 13:27:06 -04:00
Claude Paroz
d345a030c2
[1.7.x] Fixed #22241 -- Selectively added line breaks in admin read-only fields
...
When content is supposed to contain HTML, we do not try to add
line breaks in read-only contents.
Thanks Alexander Todorov for the report.
Backport of c94bff2
from master.
2014-03-22 17:11:12 +01:00
Patrick Michaud
908bdea482
[1.7.x] Fixed #22256 -- Replaced bad fallback for missing PATH
...
Thanks Baptiste Mispelon for the review.
Backport of acee46fc9
from master.
2014-03-22 16:54:02 +01:00
Claude Paroz
07d4b3c8f2
[1.7.x] Tweaked strip_tags tests to pass on Python 3.3
...
Backport of 6a0291bdaf
from master.
2014-03-22 14:44:13 +01:00
Claude Paroz
80f08dbdbc
[1.7.x] Improved strip_tags and clarified documentation
...
The fact that strip_tags cannot guarantee to really strip all
non-safe HTML content was not clear enough. Also see:
https://www.djangoproject.com/weblog/2014/mar/22/strip-tags-advisory/
Backport of 6ca6c36f82
from master.
2014-03-22 11:01:14 +01:00
Tim Graham
caa753ffd6
[1.7.x] Fixed flake8 warnings.
...
Backport of 35f46ec7a9
from master
2014-03-21 06:25:21 -04:00
Dejan Noveski
b74ec85c1d
[1.7.x] Fixed #22255 -- Added support for specifying re flags in RegexValidator
...
Backport of 4d0c5f6142
from master.
2014-03-21 11:18:26 +01:00
Alex Gaynor
0cf158cf9a
Fixed a small collection of flake8 violations that had snuck in
2014-03-20 10:30:41 -07:00
Andrew Godwin
81f5408c7a
Fixed #22275 : unique_together broken if ForeignKey split into new file.
...
Thanks to bak1an for the patch.
2014-03-19 21:23:21 -07:00
Andrew Godwin
356f064c49
Merge pull request #2221 from bmispelon/LazyObject-refactor
...
Fixed #21840 -- Moved dunder methods from SimpleLazyObject to LazyObject...
2014-03-19 21:01:24 -07:00
Anubhav Joshi
659b5678fc
Fixed #22184 -- Allowed template_tests.tests to be run isolated
2014-03-15 12:34:11 +01:00
Marc Tamlyn
d22b291890
Fixed #22001 -- Ensure db_type is respected.
...
db_parameters should respect an already existing db_type method and
return that as its type string. In particular, this was causing some
fields from gis to not be generated.
Thanks to @bigsassy and @blueyed for their work on the patch.
Also fixed #22260
2014-03-14 22:32:17 +00:00
Baptiste Mispelon
37f7f233f5
Fixed #22272 -- Fixed regression in DecimalField when using decimal_places=0.
...
Thanks to trac user merb for the report.
2014-03-14 17:21:59 +01:00
Claude Paroz
666a2ad22f
Merged model_forms_regress with model_forms tests
2014-03-14 15:18:08 +01:00
Claude Paroz
72cfbdc10a
Fixed #6103 -- Splitted tests in model_forms tests
2014-03-14 09:44:56 +01:00
Claude Paroz
5a976b4bec
Fixed #22245 -- Avoided widget overwrite in forms.IntegerField subclasses
...
Thanks Jeroen Pulles for the report and Simon Charette for the review.
2014-03-13 16:58:14 +01:00
Baptiste Mispelon
61917aa08b
Fixed #21840 -- Moved dunder methods from SimpleLazyObject to LazyObject.
...
This commit also added tests for LazyObject and refactored
the testsuite of SimpleLazyObject so that it can share
test cases with LazyObject.
2014-03-13 10:03:01 +01:00
Shai Berger
4b4c704517
Skip test for saving microseconds on backends which do not support it.
2014-03-13 00:28:05 +02:00
Shai Berger
6983201cfb
Fixed #20292 : Pass datetime objects (not formatted dates) as params to Oracle
...
This seems worthwhile in its own right, but also works around an Oracle
bug (in versions 10 -- 11.1) where the use of Unicode would reset the
date/time formats, causing ORA-01843 errors.
Thanks Trac users CarstenF for the report, jtiai for the initial patch,
and everyone who contributed to the discussion on the ticket.
2014-03-12 23:43:45 +02:00
Shai Berger
fc79c3fb3d
Flake8 corrections
2014-03-12 20:34:05 +02:00
Shai Berger
d181384e5f
Fixed test failure on Oracle: model_fields.tests.test_float_validates_object
...
Failing test introduced in fix for refs #22210 .
2014-03-12 20:17:43 +02:00
Akis Kesoglou
aaad3e27ac
Fixed #22217 - ManyToManyField.through_fields fixes.
...
- Docs description of arguments mix up.
- Keep it from erroneously masking E332 check.
- Add checks E338 and E339, tweak message of E337.
2014-03-11 19:33:04 -03:00
Andrew Godwin
f4d91638fc
Remove failing test while we fix the underlying bug
2014-03-11 10:33:57 -07:00
Tim Graham
c4f772ed34
Fixed test failures on Windows.
...
refs #21092 and 8d7e048a8b
2014-03-11 10:46:13 -04:00
Chris Beaven
107c9f5453
Fix AlterField migrations that are related to a RenameModel migration
2014-03-11 17:13:26 +13:00
Chris Beaven
40f6ca54f8
Fix autodetector creation of RenameModel migration to capitalize model names
2014-03-11 12:23:45 +13:00
Daniel Pyrathon
819e09b848
Fixed #22210 -- Saving model instances to non-related fields.
...
Previously, saving a model instance to a non-related field (in
particular a FloatField) would silently convert the model to an Integer
(the pk) and save it. This is undesirable behaviour, and likely to cause
confusion so the validatio has been hardened.
Thanks to @PirosB3 for the patch and @jarshwah for the review.
2014-03-10 15:25:18 +00:00
Chris Beaven
7feb70eef3
Fixed #22239 -- Add auto detection of renamed models
2014-03-10 13:55:44 +13:00
Claude Paroz
c564277937
Fixed #22237 -- Removed some warnings in the test suite
...
Thanks Aymeric Augustin for the report.
2014-03-09 22:10:49 +01:00
Aymeric Augustin
3a34f71d4d
Removed obsolete hack to run template tests.
2014-03-09 11:07:21 +01:00
Aymeric Augustin
06615d0d6e
Avoided leaking warning filters.
2014-03-09 11:07:21 +01:00
Shai Berger
0615eaf24a
Corrected a few missed references to old test settings
2014-03-09 08:33:33 +02:00
Alex Gaynor
add1584bfa
4 flake8 warning fixes
2014-03-08 16:17:54 -08:00
Andrew Godwin
abccbcf52d
Fixed #21843 : Remove explicit ID column setting in test
2014-03-08 16:04:21 -08:00
Andrew Godwin
6b07804474
Fixed #22183 : Through M2Ms now correctly handled
2014-03-08 15:58:04 -08:00
Andrew Godwin
cdf6eba181
Merge pull request #2315 from bendavis78/issues/22073
...
Fixed #22073 - Ensure CreateTable operation handles backwards migration correctly when M2M fields are present
2014-03-08 15:44:45 -08:00
Andrew Godwin
cd7a2a077e
Fixed #22199 : Bad max_length deconstruction for FileField
2014-03-08 13:59:12 -08:00
Claude Paroz
8d7e048a8b
Improved compatibility in admin_scripts tests
...
Environment keys/values need to use native strings on some
plateforms. Thanks anubhav joshi for detecting the issue and
helping shaping the patch.
2014-03-08 20:58:24 +01:00
Claude Paroz
b787ef2dbf
Fixed #21092 -- Ensured admin_scripts tests are run with warnings off
2014-03-08 12:49:06 +01:00
Claude Paroz
56c80e8b44
Avoided modifying current environment in admin_scripts tests
2014-03-08 12:32:57 +01:00
Claude Paroz
8446a2438f
Added test about error filterwarnings
...
Refs #20083 .
2014-03-08 11:51:49 +01:00
Claude Paroz
0c6a339952
Avoided changing raw DeprecationWarning filter behavior
...
Refs #21188 . Now pure Python DeprecationWarning visibility should
be back to Python defaults.
2014-03-08 11:13:48 +01:00
Claude Paroz
210d0489c5
Fixed #21188 -- Introduced subclasses for to-be-removed-in-django-XX warnings
...
Thanks Anssi Kääriäinen for the idea and Simon Charette for the
review.
2014-03-08 09:57:40 +01:00
Russell Keith-Magee
70ec4d776e
Fixed #22034 -- Added a specific set of relation checks for GenericInlineModelAdmin.
...
Thanks to jwa for the report.
2014-03-08 11:25:23 +08:00
Anssi Kääriäinen
219d928852
Fixed #21863 -- supplemented get_lookup() with get_transform()
...
Also fixed #22124 -- Expanded explanation of exactly what is going on in
as_sql() methods.
2014-03-07 14:52:13 +00:00
Andrew Godwin
e46e15e5a1
Fixed #22204 : Bad circular-dep-breaking if more than one per run
2014-03-06 13:22:42 -08:00
Roger Hu
9b729ddd8f
Fixed #22185 -- Added settings.CSRF_COOKIE_AGE
...
Thanks Paul McMillan for the review.
2014-03-06 08:28:43 -05:00
Gabe Jackson
b77f26313c
Fixed #22207 -- Added support for GenericRelation reverse lookups
...
GenericRelation now supports an optional related_query_name argument.
Setting related_query_name adds a relation from the related object back to
the content type for filtering, ordering and other query operations.
Thanks to Loic Bistuer for spotting a couple of important issues in
his review.
2014-03-05 22:37:53 +02:00
Akis Kesoglou
c627da0ccc
Fixed #14549 - Removed restriction of single FKs on intermediary tables
...
Thanks to Loic Bistuer for review. Minor changes to error messages
done by committer.
2014-03-05 22:33:58 +02:00
Chris Wilson
95c74b9d69
Fixed #22206 -- Passed models.TextField.max_length to forms.CharField.maxlength
2014-03-05 20:09:28 +01:00
Claude Paroz
ac699cdc17
Really hidden warnings in javascript_quote tests
...
Refs #21725 .
2014-03-05 09:00:55 +01:00
Baptiste Mispelon
5a5815d373
Fixed incorrect docstring in cache tests (take two)
...
3e25c8ac69
was an incomplete
merge of the pull request.
Thanks to @ramast for catching this.
2014-03-05 07:35:07 +01:00
Athena
5d568bcfa6
Fixed #7571 -- Fixed parameter matching in include()'d urlpattern
...
Fixed URL resolving in the case where an outer regex includes an inner
regex and both regexes use positional parameters instead of named
groups, causing the outer regex's parameters to override the inner
regex's.
Modified the regex url resolver so that it will concatenates and then
normalizes, instead of normalizing and then concatenating.
2014-03-05 00:35:03 +01:00
Alex Gaynor
a248c88372
Fixed three small flake8 violations.
2014-03-04 15:13:15 -08:00
ramast
3e25c8ac69
Fixed incorrect docstring in cache tests
2014-03-04 21:50:21 +01:00
Andrew Godwin
8fcc0140d0
Merge pull request #2396 from loic/ticket21893
...
Fixed #21893 -- ModelState didn't account for MTI parents inherited from abstract models.
2014-03-04 12:33:51 -08:00
Loic Bistuer
6436f1fad9
Fixed #21893 -- ModelState didn't account for MTI parents inherited from abstract models.
2014-03-05 03:25:14 +07:00
Loic Bistuer
99291f5db0
Added tests for MTI in RunPython.
2014-03-05 03:17:52 +07:00
zedr
6fe22b30e0
Fixed #22085 -- Added a feature for setting non-expiring keys as the default.
...
This feature allows the default `TIMEOUT` Cache argument to be set to `None`,
so that cache instances can set a non-expiring key as the default,
instead of using the default value of 5 minutes.
Previously, this was possible only by passing `None` as an argument to
the set() method of objects of type `BaseCache` (and subtypes).
2014-03-04 21:16:35 +01:00
Chris Wilson
24f0113fb9
Fixed spelling in model_forms test class names
2014-03-04 21:06:30 +01:00
Thomas Sorrel
53c576452e
Fixed #16727 -- Added protocol-relative URL support to contenttypes.views.shortcut.
2014-03-03 22:57:06 +01:00
Loic Bistuer
7bbb6958dc
Allowed custom querysets when prefetching single valued relations
...
The original patch for custom prefetches didn't allow usage of custom
queryset for single valued relations (along ForeignKey or OneToOneKey).
Allowing these enables calling performance oriented queryset methods like
select_related or defer/only.
Thanks @akaariai and @timgraham for the reviews. Refs #17001 .
2014-03-03 21:35:19 +02:00
Baptiste Mispelon
0dffaf9c25
Fixed broken tests on Python 3 after 3c5fc708f1
.
2014-03-03 15:45:48 +01:00
Rodolfo Carvalho
0d91225892
Fixed many typos in comments and docstrings.
...
Thanks Piotr Kasprzyk for help with the patch.
2014-03-03 07:38:09 -05:00
Greg Chapple
6acaa52386
Fixed #22135 -- Added ModelAdmin.get_changeform_initial_data().
...
Allows custom behavior for setting initial form data in ModelAdmin.
By default, initial data is set via GET params. The new method allows
this behavior to be overridden.
Thanks egasimus for the suggestion.
2014-03-03 07:28:24 -05:00
Russell Keith-Magee
6b63742ce5
Corrected expected test output to allow for cleanups in signal and compatibility checks.
2014-03-03 19:29:50 +08:00
Russell Keith-Magee
82ac389486
Edited model and field checks for grammar and consistency.
2014-03-03 18:18:39 +08:00
Russell Keith-Magee
bc4dc6e99c
Edited model check messages for grammar and consistency.
2014-03-03 15:35:42 +08:00
Russell Keith-Magee
f7587b20da
Edited MySQL-specific check messages for grammar and consistency.
2014-03-03 14:31:55 +08:00
Russell Keith-Magee
55ba92a9c9
Edited contrib.sites check messages for grammar and consistency.
2014-03-03 14:27:22 +08:00
Russell Keith-Magee
57e08aa232
Cleanup of contrib.contenttypes check messages.
2014-03-03 14:19:06 +08:00
Russell Keith-Magee
3c5fc708f1
Edited contrib.admin check messages for grammar and consistency.
2014-03-03 13:27:17 +08:00
Erik Romijn
6268792e19
Fixed #22130 -- fixed template_tests/defaultfilters order dependent test failure
2014-03-02 09:02:42 +01:00
Tim Graham
f732d55dfc
Added newline for flake8.
2014-03-01 15:46:23 -05:00
Anubhav Joshi
bb2ca9fe6c
Fixed #22172 -- Allowed index_together to be a single list (rather than list of lists)..
...
Thanks EmilStenstrom for the suggestion.
2014-03-01 15:44:42 -05:00
Erik Romijn
775975f15d
Fixed #22130 -- Deprecated fix_ampersands, removed utils.clean_html()
2014-03-01 14:07:57 +01:00
Sergey Kolosov
8c98f39624
Fixed #15318 -- Added settings for language cookie max-age, path, domain
...
Introduced a number of settings to configure max-age, path, and domain
for the language cookie: LANGUAGE_COOKIE_AGE, LANGUAGE_COOKIE_PATH and
LANGUAGE_COOKIE_DOMAIN.
Thanks sahid for the suggestion.
2014-03-01 07:52:45 -05:00
Baptiste Mispelon
c679cb7f60
Fixed #22168 -- Fixed migrations failing on sqlite when column names are SQL keywords
...
Thanks to trac user fallen_flint for the report and initial patch.
2014-03-01 13:45:45 +01:00
Claude Paroz
75d0dcbf84
Added patch_formats utility for i18n formatting tests
2014-03-01 10:25:06 +01:00
Tim Graham
8137215973
Added release note and regression test for refs #21643 .
...
This will be backported to stable/1.6.x along with the original fix.
2014-02-28 20:42:56 -05:00
Tim Graham
72b080c2c8
Removed Django 1.5 upgrade hints for {% url %} tag.
...
Refs #19280 and Refs #19392 .
2014-02-28 07:18:45 -05:00
vvojvoda
c23b3717be
Fixed #21962 -- Added escape_html flag to ErrorDict.as_json()
2014-02-28 07:05:55 -05:00
Claude Paroz
7b4743580a
Replaced deprecated assertEquals
2014-02-28 09:54:53 +01:00
Claude Paroz
4622d23ccf
Fixed #22056 -- Omitted non-package directories when collecting tests
...
This allows us to ignore empty dirs or other unrelated dirs.
Thanks Sebastian Pawluś for the report and the initial patch.
2014-02-26 17:46:24 +01:00
Bouke Haarsma
2bab9d6d9e
Fixed #21389 -- Accept most valid language codes
...
By removing the 'supported' keyword from the detection methods and only relying
on a cached settings.LANGUAGES, the speed of said methods has been improved;
around 4x raw performance. This allows us to stop checking Python's incomplete
list of locales, and rely on a less restrictive regular expression for
accepting certain locales.
HTTP Accept-Language is defined as being case-insensitive, based on this fact
extra performance improvements have been made; it wouldn't make sense to
check for case differences.
2014-02-26 16:58:04 +01:00
Greg Chapple
b1d10205ce
Added tests for django.contrib.admindocs
...
Refs #22015
2014-02-23 21:36:25 +01:00
Alex Gaynor
a8a5c31966
Two whitespace changes to appease flake8
2014-02-23 11:07:52 -06:00
Andrew Gorcester
202bf69c2f
Fixed #22095 -- Enabled backward migrations for RunPython operations
...
Added reversible property to RunPython so that migrations will not
refuse to reverse migrations including RunPython operations, so long as
reverse_code is set in the RunPython constructor. Included tests to
check the reversible property on RunPython and the similar RunSQL.
2014-02-23 09:30:02 +01:00
Baptiste Mispelon
7e1376c2b0
Fixed #21741 -- Fixed render_to_string to stop pushing empty dictionaries to its Context
...
Thanks to kezabelle for the report and original patch
and to numerodix for his improved patch.
2014-02-22 23:33:48 +01:00
Erik Romijn
8cd32f0965
Fixed #22120 -- Documented persistent activation of languages and cleaned up language session key use
2014-02-22 18:29:06 +01:00
Erik Romijn
98f13762d7
Fixed #22123 -- EmailValidator now also accepts IPv6 literals in addresses
2014-02-22 17:45:33 +01:00
Baptiste Mispelon
173aa51997
Fixed #21435 -- Improved error message when urlconf is empty.
...
The new error message now hints that the most likely issue
is a circular import.
Thanks to trac user elena for the report and to
bpeschier for the original patch.
2014-02-22 15:36:49 +01:00
Baptiste Mispelon
926e18d7d1
Deprecated django.utils.text.javascript_quote.
...
Refs #21725 .
2014-02-22 13:50:12 +01:00
Baptiste Mispelon
847171b0d0
Fixed test failures when running in a narrow Python build.
2014-02-22 13:50:12 +01:00