Alexandr Shurigin
8d6e0d4588
[1.7.x] Fixed #22681 -- Made TarArchive recognize leading directories properly.
...
Backport of 083d285b82
from master
2014-06-03 15:03:32 -04:00
Craig de Stigter
724e600872
[1.7.x] Fixed #22690 -- Added a check for proxy models containing fields.
...
Removed the FieldError raised by ModelBase.__new__ in this case.
Backport of ce993efda8
from master
2014-06-02 09:34:31 -04:00
Alex Gaynor
160fd6c7c1
[1.7.x] Removed an unused import
...
Backport of a31d7c48b0
from master
2014-06-02 07:14:02 -04:00
Tim Graham
f8dd382a48
[1.7.x] Revert "Fixed #19303 -- Fixed ModelAdmin.formfield_overrides on fields with choices"
...
This reverts commit 9d1987d767
.
Backport of 5046c110cf
from master
2014-06-02 07:13:03 -04:00
Vincent-Vega
d773a08b27
[1.7.x] Fixed #22711 -- Adjusted ordering checks to allow implicit relation fields.
...
refs #19195 .
Backport of d04e730224
from master
2014-06-01 15:37:57 -04:00
Simon Charette
33511662dd
[1.7.x] Fixed #22659 -- Prevent model states from sharing field instances.
...
Thanks to Trac alias tbartelmess for the report and the test project.
Backport of 7a38f88922
from master
2014-06-01 15:12:23 -04:00
Florian Apolloner
ba31e45f08
[1.7.x] Revert "Making SQL management commands migration aware."
...
This reverts commit cb9c9a7b58
.
Backport of 83e7555ffe
from master.
2014-06-01 12:01:29 +02:00
Moayad Mardini
08a2b3b9cf
[1.7.x] Improved the test for refs #22682 .
...
Thanks apollo13 for the review.
Backport of 6f4d7f41b1
from master
2014-05-30 11:01:42 -04:00
Andrew Godwin
16d037c4f0
[1.7.x] Fix additional test failures caused by migration pollution
2014-05-29 16:44:29 -07:00
Moayad Mardini
e4eae5df0e
[1.7.x] Fixed #22682 -- `makemigrations` will create `MIGRATION_MODULES` package
...
`makemigrations` will automatically create the package specified
in `MIGRATION_MODULES` if it doesn't already exist.
Thanks ovidiuc4 for the report.
2014-05-29 15:39:02 -07:00
Víðir Valberg Guðmundsson
b6a960cd1d
[1.7.x] Making SQL management commands migration aware.
2014-05-29 15:36:30 -07:00
Tim Graham
c5afdc3d73
[1.7.x] Removed unused import.
2014-05-29 09:28:58 -04:00
Alex Gaynor
d192e02b27
[1.7.x] Fixed a typo that Tim Graham noticed
...
Backport of d240b29c08
from master
2014-05-29 07:53:08 -04:00
Alex Gaynor
3d98941d5c
[1.7.x] Fixed several typos in Django
...
Backport of 1dcc603eff
from master
2014-05-29 07:53:02 -04:00
Víðir Valberg Guðmundsson
ce1dd6a730
[1.7.x] Adding test to fix of duplicate _order fields ( #22720 )
...
Backport of bf9953cfb8
from master
2014-05-29 07:52:48 -04:00
Shai Berger
b8b1fbd4c1
[1.7.x] Set straight the sense of 'uppercases_column_names' feature flag
2014-05-28 21:26:08 +03:00
Aymeric Augustin
430faebe3b
[1.7.x] Fixed #22699 -- Configure default settings in some management commands.
...
This makes it possible to run django.setup() in management commands that
don't need a settings module. In addition it simplifies error handling.
Thanks Claude for the review.
Backport of 4865326f
from master.
2014-05-27 21:46:30 +02:00
Moayad Mardini
c0a56001e0
[1.7.x] Fixed #22675 -- makemigrations --dry-run to output migrations to stdout.
...
`makemigrations --dry-run` will output the complete migrations file
that would be written if it's used along with `--verbosity 3`.
Backport of 2e613ea5c5
from master
2014-05-26 20:03:41 -04:00
Florian Apolloner
47d345fe6d
[1.7.x] Restored Python 2 compatibility.
...
Backport of ee51ab9d23
from master.
2014-05-26 00:07:57 +02:00
Florian Apolloner
1992d55eb3
[1.7.x] Fixed a few warnings in the testsuite.
...
Backport of 536ebaa048
from master.
2014-05-25 23:15:31 +02:00
Moayad Mardini
a59870e217
[1.7.x] Fixed #22676 -- makemigrations --dry-run should not ask for defaults
...
Made the fix in InteractiveMigrationQuestioner class code, rather than
MigrationAutodetector, because --dry-run shouldn't affect whether
MigrationAutodetector will detect non-nullable fields, but the
questioner should skip the question and returns a None for default
(since that won't be used anyway) if --dry-run is used.
Backport of ee14961a2a
from master
2014-05-24 09:56:43 -04:00
Marc Tamlyn
be733bf672
[1.7.x] Fixed #22510 -- Harden field removal to only None.
...
Refs #8620 .
If we allow any value to remove form fields then we get name clashes
with method names, media classes etc. There was a backwards
incompatibility introduced meaning ModelForm subclasses with declared
fields called media or clean would lose those fields.
Field removal is now only permitted by using the sentinel value None.
The docs have been slightly reworded to refer to removal of fields
rather than shadowing.
Thanks to gcbirzan for the report and initial patch, and several of the
core team for opinions.
Backport of 9fb0f5dddc
from master
2014-05-24 13:11:50 +01:00
Claude Paroz
8dad90911a
[1.7.x] Made runtests.py use 'set_installed_apps' API
...
This will also trigger the ready method of any tested application,
which was not run before.
Backport of 19b4908206
from master.
2014-05-24 11:03:45 +02:00
Baptiste Mispelon
8f87b679ed
[1.7.x] Fixed tuple serialization test.
...
Thanks to rockallite for the report.
Backport of f01d2a8f9b
from master.
2014-05-23 14:51:22 +02:00
Huu Nguyen
8462883f9b
[1.7.x] Fixed #22602 -- Improved code coverage of makemigrations command tests.
...
Backport of f851a954ac
from master
2014-05-23 08:07:58 -04:00
Moayad Mardini
7d4a51e239
[1.7.x] Fixed #22679 -- Fixed empty tuple serialization in MigrationWriter.
...
Thanks rockallite.wulf for the report.
Backport of ad994a3c5b
from master.
2014-05-22 16:20:21 +02:00
Ramiro Morales
fb45e666c2
[1.7.x] Fixed #22421 -- Regression in fixtures loading.
...
Loading fixtures were failing since the refactoring in 244e2b71f5
for
inheritance setups where the chain contains abstract models and the
root ancestor contains a M2M relation.
Thanks Stanislas Guerra for the report.
Refs #20946 .
Backport of 862e1ff234
from master
2014-05-22 07:38:39 -04:00
Tim Graham
f25c5de4ce
[1.7.x] Skipped a migrations test that's not supported on MySQL + Python 3.
...
Backport of dfeef8e147
from master
2014-05-21 07:04:46 -04:00
Andrew Godwin
fd62bc165c
[1.7.x] Fixed #22432 : SQLite M2M repointing now works. Thanks to xelnor.
...
Backport of 03900a02d5
from master
2014-05-21 07:04:46 -04:00
Loic Bistuer
c60240e712
[1.7.x] Failing testcases for #22649 .
...
Backport of 5789ff7330
from master
2014-05-21 07:04:46 -04:00
Loic Bistuer
d61b6224b0
[1.7.x] Fixed #22424 -- Fixed handling of default values for TextField/BinaryField on MySQL.
...
Thanks syphar for the review and suggestions.
Backport of 1d3d01b4f7
from master
2014-05-21 07:04:38 -04:00
Huu Nguyen
f7270dcd9d
[1.7.x] Fixed #22661 -- Move makemigrations tests to the proper class
...
Backport of 44304cf04e
from master
2014-05-21 06:56:23 -04:00
Loic Bistuer
0fa1aeb8d8
[1.7.x] Fixed the ordering of prefetch lookups so that latter lookups can refer to former lookups.
...
Thanks Anssi Kääriäinen and Tim Graham for the reviews. Refs #17001 and #22650 .
Backport of 870b0a1f86
from master
2014-05-21 10:37:41 +07:00
Loic Bistuer
24a41ecc35
[1.7.x] Fixed #22650 -- Fixed regression on prefetch_related.
...
Regression from f51c1f59
when using select_related then prefetch_related
on the reverse side of an O2O:
Author.objects.select_related('bio').prefetch_related('bio__books')
Thanks Aymeric Augustin for the report and tests. Refs #17001 .
Backport of bdf3473e64
from master
2014-05-21 10:37:00 +07:00
Denis Cornehl
0007a43198
[1.7.X] Fixed #22557 -- ManifestStaticFilesStorage did not cleanup deleted files.
...
When using ManifestStaticFilesStorage, deleted static files would be
correctly cleaned up by "collectstatic --clear", but the manifest file
would still contain the stale entries.
Thanks to tedtieken for the report
Backport of 3bec38888f
from master.
2014-05-20 18:19:40 +02:00
Marc Tamlyn
157575c7c8
[1.7.x] Fix a2dd618
for mysql.
...
Backport of 3b76502
from master
2014-05-19 15:05:23 +01:00
Marc Tamlyn
c38925a601
[1.7.x] Fixed #22648 -- Transform.output_type should respect overridden custom_lookup and custom_transform.
...
Previously, class lookups from the output_type would be used, but any
changes to custom_lookup or custom_transform would be ignored.
Backport of a2dd618
from master
2014-05-19 15:05:23 +01:00
Alex Gaynor
8b87473008
[1.7.x] Fixed several flake8 errors, including one where a test wouldn't be run
...
Backport of b6b873d2ad
from master
2014-05-17 13:31:09 -04:00
Shai Berger
b7a67b788c
[1.7.x] Fixed storing of binary fields and unicode textfields for Oracle/Python3
...
Backport of 6bb6df2943
from master
2014-05-17 01:16:06 +03:00
Aymeric Augustin
62de03ee33
[1.7.x] Optimized make_aware/naive by removing redundant checks. Refs #22625 .
...
Also added tests with pytz and removed misplaced tests.
Backport of 1109ebd
from master
2014-05-16 23:14:13 +02:00
Aymeric Augustin
6f8301d6cd
[1.7.x] Fixed #22625 -- Normalized make_aware/naive errors.
...
Also added tests for is/make_aware/naive.
Thanks Tom Michaelis for the report.
Backport of fa89acf
from master
2014-05-16 22:54:21 +02:00
Stas Rudakou
75d2da797e
[1.7.x] Fixed #22266 - quote PK before redirecting away from add_view (django.contrib.admin)
...
Backport of ebd70d4d00
from master.
2014-05-16 18:38:26 +02:00
Erik Romijn
2a66d12e77
[1.7.x] Fixed #22579 -- Corrected validation for email to reject trailing slash
...
Backport of 424fe76349
from master.
2014-05-16 15:19:21 +02:00
Stephen Burrows
79f15ab1ef
[1.7.x] Fixed #22628 -- Took initial forms into account when combining FormSet.min_num and FormSet.extra.
2014-05-16 06:37:05 -04:00
Claude Paroz
e8a7436941
[1.7.x] Harmonized some PEP 0263 coding preambles
...
Backport of e520a73ee
from master.
2014-05-15 20:01:31 +02:00
Anders Steinlein
2914f66983
[1.7.x] Fixed #17642 -- Added min_num support to modelformsets, inlines, and the admin.
...
Thanks Stephen Burrows for work on the patch as well.
2014-05-15 07:02:06 -04:00
Erik Romijn
e7b0cace45
[1.7.x] Added additional checks in is_safe_url to account for flexible parsing.
...
This is a security fix. Disclosure following shortly.
2014-05-14 10:18:27 +02:00
Aymeric Augustin
7fef18ba9e
[1.7.x] Dropped fix_IE_for_vary/attach.
...
This is a security fix. Disclosure following shortly.
2014-05-14 10:18:26 +02:00
Claude Paroz
9d0ebceb32
[1.7.x] Fixed #21685 -- Displayed app verbose name in admindocs model index
...
Backport of 4cf82e5bcf
from master.
2014-05-10 18:10:05 +02:00
Aymeric Augustin
e9d0ef19bc
[1.7.x] Fixed #22508 -- Avoided overwriting select_related.
...
Previously, known related objects overwrote related objects loaded
though select_related. This could cancel the effect of select_related
when it was used over more than one level.
Thanks boxm for the bug report and timo for bisecting the regression.
Backport of f574220f
from master
2014-05-10 17:03:42 +02:00
Aymeric Augustin
c54fb3d922
[1.7.x] Adjusted refactoring of vendor checks.
...
Thanks Shai for the thorough review.
Backport of fb90b7c
from master
2014-05-10 14:55:22 +02:00
Stephen Burrows
0c198035e9
[1.7.x] Fixed #22502 -- Fixed microseconds/default/form interaction
...
Made explicit lack of microsecond handling by built-in datetime form
fields. Used that explicitness to appropriately nix microsecond
values in bound fields. Thanks Claude Paroz for the review.
Backport of a5de0df58
from master.
2014-05-10 10:58:51 +02:00
Malcolm Box
8a090c21f1
[1.7.x] Fixed #22606 -- Locmemcache has_key() failed for infinite cache expiry
...
Refactored cache expiry logic for Locmemcache to make consistent across
all places where accessed, and correctly handle None as expiry time.
Backport of 66880e4cd
from master.
2014-05-09 19:47:43 +02:00
Andrew Godwin
31eac71a76
[1.7.x] Tests for #22325
2014-05-08 21:49:09 -07:00
Andrew Godwin
d2e96b5792
Merge pull request #2637 from davidszotten/validator_comparisons
...
[1.7.x] Fixed #22588 -- Fix RegexValidator __eq__
2014-05-08 19:49:59 -07:00
Aymeric Augustin
7194d40236
[1.7.x] Added feature flags for introspection capabilities.
...
Backport of 99d9fa32
from master
2014-05-08 22:53:21 +02:00
Aymeric Augustin
92a1e71100
[1.7.x] Split ignores_nulls_in_unique_constraints feature.
...
Oracle and SQL Server don't have exactly the same limitations. It's
worth treating them differently.
Backport of cff59bed
from master
2014-05-08 22:53:11 +02:00
Aymeric Augustin
e3bc11cca9
[1.7.x] Replaced vendor checks by three feature flags.
...
Backport of c70a61eb
from master
2014-05-08 22:53:00 +02:00
Aymeric Augustin
7f48d44c60
[1.7.x] Simplified indexes tests.
...
Backport of 43a80f48
from master
2014-05-08 22:52:53 +02:00
Aymeric Augustin
51fed81e33
[1.7.x] Reorganized backends tests.
...
This reduces the number of explicit vendor checks.
Backport of d6672631
from master
2014-05-08 22:52:34 +02:00
Aymeric Augustin
e244e456c7
[1.7.x] Appeased flake8.
...
Backport of b1432bfc
from master
2014-05-08 22:45:26 +02:00
Andrew Godwin
f2bf59a5bc
[1.7.x] Fixed #22476 : Couldn't alter attributes on M2Ms with through= set
2014-05-08 10:34:45 -07:00
Andrew Godwin
7f63ac5a9f
[1.7.x] Fixed #22496 : Data migrations get transactions again!
2014-05-07 14:29:04 -07:00
Andrew Godwin
d8bf415ab2
[1.7.x] Fixed #22581 : Pass default values for schema through get_db_prep_save()
2014-05-07 13:47:02 -07:00
David Szotten
724a7bf222
[1.7.x] Fixed #22588 -- Fix RegexValidator __eq__
...
Compare parameters instead of re.pattern instances, and add the other
parameters to the comparison. Also add a __ne__ to make assertNotEqual
work properly.
2014-05-07 19:28:42 +01:00
Andrew Godwin
f53d1576ca
[1.7.x] Fixed #22337 : FileSystemStorage marked as deconstructible and tested.
2014-05-06 22:24:39 -07:00
Claude Paroz
0d138b9cf4
[1.7.x] Fixed #22564 -- Prevented unneeded bytestrings in migrations
...
In some cases, this could lead to migrations written with Python 2
being incompatible with Python 3.
Thanks Tim Graham for the report and Loïc Bistuer for the advices.
Backport of da9cf53cb
from master.
2014-05-06 09:14:32 +02:00
Ben Davis
549b658241
[1.7.x] Fixed #22570 -- Made Form.__getitem__ KeyError more descriptive.
...
Backport of df60db0e78
from master
2014-05-05 20:02:14 -04:00
Anssi Kääriäinen
76979a257d
[1.7.x] Fixed #22466 -- ordering by reverse foreign key
...
Ordering by reverse foreign key was broken by custom lookups patch
(commit 20bab2cf9d
).
Thanks to everybody who helped solving this issue. Special thanks to
Trac alias takis for reporting this.
Backport of 3b7c66a3ac
from master
2014-05-05 15:29:24 +03:00
Jakub Roztocil
4b6ba2c1d1
[1.7.x] Fixed #22489 -- missing implemenation for search lookup
...
When custom lookups were added, converting the search lookup to use
the new Lookup infrastructure wasn't done.
Some changes were needed to the added test, main change done by
committer was ensuring the test works on MySQL versions prior to 5.6.
Backport of 7131e14d00
from master
2014-05-05 14:40:06 +03:00
Anssi Kääriäinen
402fc4f6c9
[1.7.x] Fixed #22429 -- Incorrect SQL when using ~Q and F
...
Backport of 5e1f4656b9
from master
2014-05-05 13:06:51 +03:00
Tim Graham
f8fa735dc2
[1.7.x] Fixed #22435 -- Prevented adding a ManyToManyField from prompting for a default.
...
Thanks andrewsg for the report.
Backport of 3818d96426
from master
2014-05-02 20:53:39 -04:00
Claude Paroz
61fd00d4fd
[1.7.x] Fixed #22565 -- Prevented pgettext_lazy crash with bytestring input
...
Thanks ygbo for the report.
Backport of 142c27218
from master.
2014-05-02 19:33:58 +02:00
Chris Beaven
5ab93bbe74
[1.7.x] Fix migration autodector to work correctly with custom deconstructed values
2014-05-02 15:12:42 +12:00
Yehonatan Daniv
d56267ba57
[1.7.x] Fixed #22539 -- Copied exclude argument in Model.full_clean() to prevent side effects.
...
Backport of e2e4cdba11
from master
2014-05-01 09:30:49 -04:00
Tim Graham
e5941ba5f3
[1.7.x] flake8 fixes.
...
Backport of 45c2d1f5d9
from master.
2014-04-30 18:35:40 -04:00
Andrew Godwin
6ca5367869
[1.7.x] Cleanup failing test w/contenttypes and remove useless graph load
2014-04-30 15:12:18 -07:00
Andrew Godwin
35c2a14a49
[1.7.x] Fixed #22485 : Include all unmigrated apps in project state by default.
2014-04-30 12:26:11 -07:00
Simon Charette
a6ecd5dbb3
[1.7.x] Fixed #19195 -- Allow explicit ordering by a relation `_id` field.
...
Thanks to chrisedgemon for the report and shaib, akaariai and
timgraham for the review.
Backport of 24ec9538b7
from master
2014-04-30 14:26:39 -04:00
Claude Paroz
1084456ac2
[1.7.x] Fixed #22474 -- Made migration recorder aware of multiple databases
...
Thanks Tim Graham for the review.
Backport of 7c54f8cce
from master.
2014-04-30 16:55:12 +02:00
Mike Fogel
bb5c7e4e8d
[1.7.x] Fixed #22537 -- Add tests and improved docs for field subclass with choices.
...
Backport of 7fd1b35ed7
from master
2014-04-30 07:57:35 -04:00
Simon Charette
cda5745df0
[1.7.x] Fixed #22447 -- Make sure custom model bases can be migrated.
...
Thanks to cdestigter for the report.
Backport of 390f888745
from master
2014-04-29 10:55:45 -04:00
Tim Graham
1d20693fa6
[1.7.x] Revert "Fixed #15179 -- middlewares not applied for test client login()"
...
This reverts commit 4fdd51b732
.
See the ticket for concerns with this implementation; it will be revisited.
Backport of aabceadd7d
from master
2014-04-28 18:49:24 -04:00
Alex Gaynor
996564df4d
[1.7.x] Fix many many typos in comments throughout the codebase
...
Backport of 2bcb8bfc8d
from master
2014-04-26 14:35:57 -04:00
Aymeric Augustin
3bb0f118ca
[1.7.x] Fixed #3214 -- Stopped parsing SQL with regex.
...
Avoided introducing a new regex-based SQL splitter in the migrations
framework, before we're bound by backwards compatibility.
Adapted this change to the legacy "initial SQL data" feature, even
though it's already deprecated, in order to facilitate the transition
to migrations.
sqlparse becomes mandatory for RunSQL on some databases (all but
PostgreSQL). There's no API to provide a single statement and tell
Django not to attempt splitting. Since we have a more robust splitting
implementation, that seems like a good tradeoff. It's easier to add a
new keyword argument later if necessary than to remove one.
Many people contributed to both tickets, thank you all, and especially
Claude for the review.
Refs #22401 .
Backport of 8b5b199
from master
2014-04-26 17:46:57 +02:00
Tim Graham
bee118a701
[1.7.x] Fixed #22499 -- Fixed a typo in an admin_views test that caused failure on Oracle.
...
Backport of d238c58912
from master
2014-04-24 07:06:57 -04:00
Malcolm Box
07235aec9d
[1.7.x] Fixed #22495 -- Locmem cache.add() failed with infinite timeouts
...
cache.add() incorrectly succeeded when there was an existing key
with an infinite (None) timeout.
Backport of af5f688392
from master.
2014-04-23 14:56:54 +02:00
Tim Graham
e192f13103
[1.7.x] Fixed #22486 -- Restored the ability to reverse views created using functools.partial.
...
Regression in 8b93b31487
.
Thanks rcoup for the report.
Backport of 3c06b2f2a3
from master
2014-04-23 08:49:53 -04:00
Claude Paroz
1d0f1ee199
[1.7.x] Fixed table cleanup in GIS migration tests
...
Backport of ab90c4707b
from master.
2014-04-22 19:52:58 +02:00
Preston Timmons
935159d951
[1.7.x] Fixed #22478 -- Regression in test label discovery.
...
As part of the app-loading updates the old test runner was changed to not
require a models module. This introduced a regression in behavior so
applabel.TestCase failed for tests defined in a directory.
The fix is thanks to yakky and rtnpro.
2014-04-22 12:48:39 -04:00
Erik Romijn
34526c2f56
[1.7.x] Fixed queries that may return unexpected results on MySQL due to typecasting.
...
This is a security fix. Disclosure will follow shortly.
Backport of 75c0d4ea3a
from master
2014-04-21 18:29:39 -04:00
Aymeric Augustin
380545bf85
[1.7.x] Prevented leaking the CSRF token through caching.
...
This is a security fix. Disclosure will follow shortly.
Backport of c083e3815a
from master
2014-04-21 18:29:24 -04:00
Tim Graham
546740544d
[1.7.x] Fixed a remote code execution vulnerabilty in URL reversing.
...
Thanks Benjamin Bach for the report and initial patch.
This is a security fix; disclosure to follow shortly.
Backport of 8b93b31487
from master
2014-04-21 18:29:12 -04:00
Florian Apolloner
d7de6ed07e
[1.7.x] Fixed monkeypatching in a staticfiles test.
...
Backport of a4553e0510
from master
2014-04-21 08:58:41 -04:00
Aymeric Augustin
62eb79fc4c
[1.7.x] Appeased flake8 2.1.0.
...
Backport of 428c0bbe1b
from master
2014-04-21 07:50:50 -04:00
Alex Gaynor
50dddbdfc7
[1.7.x] Corrected many style guide violations that the newest version of flake8 catches
...
Backport of 778ce245dd
from master
2014-04-21 07:50:43 -04:00
Aymeric Augustin
0dad0ca55e
[1.7.x] Further consolidated the model_inheritance tests.
...
Backport of 3f01e82
from master
2014-04-21 11:51:21 +02:00
Aymeric Augustin
ab0afef959
[1.7.x] Fixed #22402 -- Consolidated model_inheritance tests.
...
The model_inheritance_same_model_name tests couldn't be run without the
model_inheritance tests. Make the problem go away by merging them.
Thanks timo for the report.
Backport of 0097d38 from master
2014-04-21 11:43:38 +02:00
Simon Charette
33d1dc2eeb
[1.7.x] Fixed flake8 warnings introduced in recent commits.
...
Backport of 79f05616fb
from master
2014-04-20 13:10:52 -04:00
Tim Graham
9e86c3f0a6
[1.7.x] Fixed flake8 errors.
...
Backport of 471fb04a30
from master
2014-04-20 13:09:12 -04:00