704443acac
Fixed #29363 -- Added SimpleTestCase.assertWarnsMessage().
2018-05-09 11:40:28 -04:00
a9189d27ef
Fixed #29353 -- Made StaticFilesHandler return a 404 response when settings.DEBUG is False
2018-04-25 10:38:13 +02:00
3aae43d800
Fixed #28973 -- Silenced copying/linking messages in collectstatic's default verbosity.
2018-04-23 23:04:02 -04:00
362813d628
Fixed hanging indentation in various code.
2018-03-16 10:54:34 +01:00
7d607127e3
Refs #21221 -- Deprecated staticfiles and admin_static template tag libraries.
2018-01-23 10:30:10 -05:00
ff05de760c
Fixed #29038 -- Removed closing slash from HTML void tags.
2018-01-21 02:09:10 -05:00
59b1aaa5a5
Added a couple tests for collectstatic.
2018-01-15 11:15:14 -05:00
83a36ac49a
Removed unnecessary trailing commas and spaces in various code.
2017-12-28 21:07:29 +01:00
6c0042430e
Fixed #28776 -- Fixed a/an/and typos in docs and comments.
2017-11-06 22:41:03 -05:00
6e4c6281db
Reverted "Fixed #27818 -- Replaced try/except/pass with contextlib.suppress()."
...
This reverts commit 550cb3a365
2017-09-07 08:16:21 -04:00
09b3e46635
Fixed #27796 -- Prevented middleware being loaded twice with runserver
...
Thanks Tim Graham for the review.
2017-08-23 23:05:18 +02:00
a51c4de194
Used assertRaisesMessage() to test Django's error messages.
2017-07-29 19:07:23 -04:00
550cb3a365
Fixed #27818 -- Replaced try/except/pass with contextlib.suppress().
2017-06-28 14:07:55 -04:00
cde31daf88
Sorted imports per isort 4.2.9.
2017-06-01 13:23:48 -04:00
b536dcf656
Fixed #27948 -- Removed incorrect unquote() in static serving views.
2017-03-17 07:55:00 -04:00
8e3f9d3ee2
Fixed #27741 -- Isolated TestCollectionHashedFilesCache in a tmpdir.
2017-02-03 18:49:08 -05:00
8838d4dd49
Refs #23919 -- Replaced kwargs.pop() with keyword-only arguments.
2017-02-01 11:41:56 -05:00
0ec4dc91e0
Fixed #27661 -- Moved FileSystemFinder's ImproperlyConfigured exceptions to system checks.
...
Thanks Simon Charette, Mariusz Felisiak, Tim Graham, and Adam Johnson
for review.
2017-02-01 09:48:24 -05:00
6478e07a62
Refs #23919 -- Replaced tempfile.mkdtemp() with TemporaryDirectory() context manager.
2017-01-26 13:54:16 -05:00
11856ea44e
Refs #27741 -- Fixed staticfiles_tests.test_views when run in isolation.
2017-01-25 13:53:38 -05:00
d6eaf7c018
Refs #23919 -- Replaced super(ClassName, self) with super().
2017-01-25 12:23:46 -05:00
632c4ffd9c
Refs #23919 -- Replaced errno checking with PEP 3151 exceptions.
2017-01-25 10:13:08 -05:00
2366100872
Removed unneeded force_text calls in the test suite
2017-01-24 18:45:54 +01:00
7aba69145d
Refs #23919 -- Removed django.test.mock Python 2 compatibility shim.
2017-01-20 08:17:20 -05:00
4e729feaa6
Refs #23919 -- Removed django.utils._os.upath()/npath()/abspathu() usage.
...
These functions do nothing on Python 3.
2017-01-20 08:01:02 -05:00
5320fa77c3
Refs #23919 -- Removed obsolete contextlib.closing() calls (for Python 2).
2017-01-19 08:50:28 -05:00
cecc079168
Refs #23919 -- Stopped inheriting from object to define new style classes.
2017-01-19 08:39:46 +01:00
2b281cc35e
Refs #23919 -- Removed most of remaining six usage
...
Thanks Tim Graham for the review.
2017-01-18 21:33:28 +01:00
7b2f2e74ad
Refs #23919 -- Removed six.<various>_types usage
...
Thanks Tim Graham and Simon Charette for the reviews.
2017-01-18 20:18:46 +01:00
c716fe8782
Refs #23919 -- Removed six.PY2/PY3 usage
...
Thanks Tim Graham for the review.
2017-01-18 16:21:28 +01:00
d7b9aaa366
Refs #23919 -- Removed encoding preambles and future imports
2017-01-18 09:55:19 +01:00
53bffe8d03
Fixed #24452 -- Fixed HashedFilesMixin correctness with nested paths.
2017-01-11 09:21:29 -05:00
c85831e4b7
Fixed #27658 -- Prevented collectstatic from overwriting newer files in remote storages.
...
Thanks revimi for the initial patch.
2017-01-04 12:50:31 -05:00
f60d4e704d
Tested collectstatic's deleting of files/symlinks when toggling --link.
2017-01-04 12:49:57 -05:00
bff4abacad
Refs #15035 -- Corrected a bug and improved comments for a staticfiles test.
2017-01-03 19:22:19 -05:00
e233f357bd
Refs #25484 -- Removed incorrect unquoting in {% static %}.
...
Regression in 374e6230ca
2016-12-19 16:18:06 -05:00
374e6230ca
Fixed #25484 -- Made {% static %} render escaped URLs.
2016-12-17 10:03:44 -05:00
321e94fa41
Refs #27392 -- Removed "Tests that", "Ensures that", etc. from test docstrings.
2016-11-10 21:30:21 -05:00
8c054ed71d
Fixed #27108 -- Displayed collectstatic's delete/overwrite warnings only if some files exist in STATIC_ROOT.
2016-09-02 14:53:18 -04:00
3f2c945257
Added tests for collectstatic interactivity.
2016-09-01 19:46:03 -04:00
08ed3cc6d1
Fixed #26671 -- Made HashedFilesMixin ignore the 'chrome' scheme.
2016-07-12 08:20:39 -04:00
81cdcb66bc
Fixed #26791 -- Replaced LiveServerTestCase port ranges with binding to port 0.
2016-06-23 12:04:05 -04:00
17e661641d
Refs #26666 -- Added ALLOWED_HOSTS validation when running tests.
...
Also used ALLOWED_HOSTS to check for external hosts in assertRedirects().
2016-06-20 11:07:46 -04:00
4f336f6652
Fixed #26747 -- Used more specific assertions in the Django test suite.
2016-06-16 14:19:18 -04:00
359be1c870
Fixed #26691 -- Removed checking for a file's existence before deleting.
...
File operations always raise a ENOENT error when a file doesn't exist.
Checking the file exists before the operation adds a race condition
condition where the file could be removed between operations. As the
operation already raises an error on a missing file, avoid this race and
avoid checking the file exists twice. Instead only check a file exists
by catching the ENOENT error.
2016-05-31 12:03:27 -04:00
f4c2b8e04a
Fixed #20189 -- Allowed customizing staticfiles ignored_patterns list
...
Thanks Tim Graham for the review.
2016-04-22 09:56:06 +02:00
edcecaf0de
Fixed #19670 -- Applied CachedFilesMixin patterns to specific extensions
...
Thanks Simon Meers for the initial patch, and Tim Graham for the review.
2016-03-30 14:34:41 +02:00
859fc64338
Cleaned class inheritances in staticfiles tests
...
Thanks Tim Graham for precious inputs.
2016-03-28 19:46:03 +02:00
28bcff82c5
Fixed #26297 -- Fixed `collectstatic --clear` crash if storage doesn't implement path().
2016-03-17 09:49:57 -04:00
4e2da368db
Cleaned up TestStaticFilePermissions to use call_command().
2016-03-03 21:58:23 +01:00
1ff6e37de4
Fixed #23832 -- Added timezone aware Storage API.
...
New Storage.get_{accessed,created,modified}_time() methods convert the
naive time from now-deprecated {accessed,created_modified}_time()
methods into aware objects in UTC if USE_TZ=True.
2016-02-23 18:51:43 -05:00
7f6fbc906a
Prevented static file corruption when URL fragment contains '..'.
...
When running collectstatic with a hashing static file storage backend,
URLs referencing other files were normalized with posixpath.normpath.
This could corrupt URLs: for example 'a.css#b/../c' became just 'c'.
Normalization seems to be an artifact of the historical implementation.
It contained a home-grown implementation of posixpath.join which relied
on counting occurrences of .. and /, so multiple / had to be collapsed.
The new implementation introduced in the previous commit doesn't suffer
from this issue. So it seems safe to remove the normalization.
There was a test for this normalization behavior but I don't think it's
a good test. Django shouldn't modify CSS that way. If a developer has
rendundant /s, it's mostly an aesthetic issue and it isn't Django's job
to fix it. Conversely, if the user wants a series of /s, perhaps in the
URL fragment, Django shouldn't destroy it.
Refs #26249 .
2016-02-23 19:35:16 +01:00
706b33fef8
Fixed #26249 -- Fixed collectstatic crash for files in STATIC_ROOT referenced by absolute URL.
...
collectstatic crashed when:
* a hashing static file storage backend was used
* a static file referenced another static file located directly in
STATIC_ROOT (not a subdirectory) with an absolute URL (which must
start with STATIC_URL, which cannot be empty)
It seems to me that the current code reimplements relative path joining
and doesn't handle edge cases correctly. I suspect it assumes that
STATIC_URL is of the form r'/[^/]+/'.
Throwing out that code in favor of the posixpath module makes the logic
easier to follow. Handling absolute paths correctly also becomes easier.
2016-02-23 19:34:21 +01:00
269b5f262c
Used call_command return value in staticfiles tests
...
Refs #26190 .
2016-02-23 09:12:12 +01:00
26ad01719d
Refs #26022 -- Replaced six.assertRaisesRegex with assertRaisesMessage as appropriate.
2016-01-29 13:37:33 -05:00
3d0dcd7f5a
Refs #26022 -- Used context manager version of assertRaises in tests.
2016-01-29 12:32:18 -05:00
20e2b228aa
Refs #21221 -- Added test for legacy static usage in form Media.
...
Before cf546e1
2016-01-19 06:57:20 -05:00
cf546e11ac
Fixed #21221 -- Made form Media and static template tag use staticfiles if installed.
2015-12-10 14:30:19 -05:00
93452a70e8
Fixed many spelling mistakes in code, comments, and docs.
2015-12-03 12:48:24 -05:00
6ca163d7cc
Fixed #25784 -- Prevented an exception on collectstatic help
...
Made the `manage.py help collectstatic` don't fail if the `STATIC_ROOT`
setting is empty.
2015-11-22 20:32:14 +01:00
7624fdb9f8
Fixed #25283 -- Fixed collectstatic crash if a URL contains a fragment with a path.
...
A @font-face declaration may contain a fragment that looks like a relative path,
e.g. @font-face { src: url('../fonts/font.svg#../path/like/fragment'); }
In this case, an incorrect path was passed to the storage backend, which raised
an error that caused collectstatic to crash.
2015-11-12 19:30:48 -05:00
0922bbf18d
Fixed #25346 -- Allowed collectstatic to delete broken symlinks.
2015-10-17 14:13:31 -04:00
bf2c969eb7
Prevented staticfiles test from colliding when run in parallel.
...
This requires that each test never alters files in static directories
collected by other tests. The alternative is to add a temporary
directory to STATICFILES_DIRS or a new app to INSTALLED_APPS.
2015-09-09 23:01:17 +02:00
b40c551fdf
Fixed some unclosed objects in tests
2015-07-06 10:10:40 -04:00
b35b43dff8
Fixed #24982 -- Split staticfiles tests into multiple files
2015-07-01 09:41:27 -04:00
5304494585
Fixed #24890 -- Added warning to collectstatic when static files have clashing names
2015-06-13 20:34:24 -04:00
be67400b47
Refs #24652 -- Used SimpleTestCase where appropriate.
2015-05-20 13:46:13 -04:00
389baccac5
Fixed staticfiles test on Windows; refs #23986 .
2015-03-11 14:49:15 -04:00
87d78241a2
Fixed #23986 -- Fixed collectstatic --clear failure if STATIC_ROOT dir doesn't exist.
2015-03-07 10:47:07 -05:00
952ce778c6
Fixed a test failure under Windows and Python 2.
2015-02-23 18:36:15 +01:00
934400759d
Guaranteed removal of temporary files during tests.
...
Dropped the DJANGO_TEST_TEMP_DIR environment variable.
Before this change, proper removal depended on the developer passing
dir=os.environ['DJANGO_TEST_TMP_DIR'] to tempfile functions.
2015-02-23 16:55:26 +01:00
c688460df6
Removed rmtree_errorhandler.
...
The stated reason for its introduction in d18d37ce
2015-02-22 23:09:42 +01:00
787dd6519a
Removed obsolete reference to media directory.
2015-02-21 17:52:24 +01:00
bd059e3f8c
Removed workaround for SVN limitations.
...
In addition to simplifying the code, this reduces the number of writes.
2015-02-21 17:52:24 +01:00
2bb5b0e098
Avoided collecting admin static files in tests.
...
This makes the staticfiles tests 2.5 times faster.
2015-02-21 17:46:26 +01:00
1d9d39fa1c
Removed TestServeAdminMedia.
...
It should have been removed when the ADMIN_MEDIA_PREFIX setting was deprecated.
2015-02-21 17:46:26 +01:00
307c0f299a
Refs #24324 -- Fixed Python 2 test failures when path to Django source contains non-ASCII characters.
2015-02-17 19:03:03 -05:00
0ed7d15563
Sorted imports with isort; refs #23860 .
2015-02-06 08:16:28 -05:00
2730dad0d7
Fixed #24197 -- Added clearing of staticfiles caches on settings changes during tests
...
Cleared caching in staticfiles_storage and get_finder when
relevant settings are changed.
2015-02-04 10:53:04 -05:00
9ec8aa5e5d
Fixed #24149 -- Normalized tuple settings to lists.
2015-02-03 14:59:45 -05:00
b9feec959b
Fixed #23700 -- Fixed non-deterministic static files test failures on Windows.
...
This partially reverts commit 949ee521fa#21230 .
2015-01-01 13:57:52 -05:00
fd60e6c887
Refs #23947 -- Prevented staticfiles tests from having side effects.
2014-12-09 11:17:05 -05:00
c0c1bb9e64
Avoided using private API get_template_from_string.
2014-10-31 11:38:53 +01:00
9562ffea97
Avoid the word "stupid".
...
There's always a better word.
2014-09-09 20:55:57 +02:00
3a44e20005
Fixed #23374 -- Renamed StaticLiveServerCase to StaticLiveServerTestCase
...
Refs #20739 . Thanks Raphaël Hertzog for the report and the initial
patch.
2014-08-28 08:44:26 +02:00
d38a00332e
Updated tests for added newlines in 6868643063.
2014-08-12 20:16:04 -04:00
6868643063
Added newlines to the ends of CSS, HTML, and JavaScript files missing them.
2014-08-12 19:22:09 -04:00
c6a711d9e5
Removed some apps from ALWAYS_INSTALLED_APPS
2014-06-21 21:01:37 +02:00
f17b24e407
Converted remaining management commands to argparse
2014-06-14 13:43:44 +02:00
9980f67154
Fixed a staticfiles test on Windows.
2014-06-12 13:08:27 -04:00
3bec38888f
Fixed #22557 -- ManifestStaticFilesStorage did not cleanup deleted files.
...
When using ManifestStaticFilesStorage, deleted static files would be
correctly cleaned up by "collectstatic --clear", but the manifest file
would still contain the stale entries.
Thanks to tedtieken for the report
2014-05-20 18:14:49 +02:00
949ee521fa
Refs #21230 -- removed direct settings manipulation from staticfile tests
2014-05-18 14:27:35 -04:00
a4553e0510
Fixed monkeypatching in a staticfiles test.
2014-04-21 14:51:52 +02:00
428c0bbe1b
Appeased flake8 2.1.0.
2014-04-21 12:27:34 +02:00
cd914e31c9
Fixed #21977 -- Deprecated SimpleTestCase.urls
2014-04-06 17:33:43 -04:00
d73d0e071c
Fixed #22218 -- Deprecated django.conf.urls.patterns.
...
Thanks Carl Meyer for the suggestion and Alex Gaynor and Carl for reviews.
2014-04-03 07:28:10 -04:00
86dcac4634
Fixed #22315 -- str/bytes mismatch in staticfiles
...
Previously, `ManifestFilesMixin.read_manifest` failed in Python 3
because `json.loads` accepts `str` not `bytes`.
2014-03-25 09:53:24 -04:00
7e27885c6e
Reworked the detection of local storages for the collectstatic command.
...
Before 4befb30#21581 .
2014-02-12 11:00:01 -05:00
29345390b8
Minor edits to new findstatic functionality; refs #19879 .
...
Hopefully fixes a test failure on Jenkins.
2014-02-09 15:39:04 -05:00
f90be002d9
Fixed #20780 -- Get rid of stale symlinks when using collectstatic.
...
Thanks to John Giannelos for the initial patch.
2014-02-09 14:48:11 +00:00
Morgan Aubert
Claude Paroz
Mariusz Felisiak
Jon Dufresne
Mads Jensen
Дилян Палаузов
Tim Graham
David Sanders
Vytis Banaitis
Ling-Xiao Yang
Chillar Anand
Simon Charette
alix-
za
François Freitag
Andrew Nester
Tobias McNulty
Berker Peksag
James Aylett
Aymeric Augustin
Hasan
Johannes Hoppe
Josh Soref
Alex Morozov
msaelices
Yusuke Miyazaki
Andriy Sokolovskiy
Moritz Sichert
Markus Amalthea Magnuson
Simon Charette
Sztrovacsek
Aymeric Augustin
mlavin
darkryder
Diego Guimarães
Trey Hunner
Denis Cornehl
Huu Nguyen
Florian Apolloner
Anubhav Joshi
David Evans
Loic Bistuer
Jannis Leidel